Page MenuHomePhabricator

[WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.
ClosedPublic

Authored by sunfish on Sat, Aug 1, 7:53 AM.

Details

Summary

This allows people to use int8_t instead of char, -funsigned-char,
and generally decouples SIMD from the specialness of char.

And it makes intrinsics like __builtin_wasm_add_saturate_s_i8x16
and __builtin_wasm_add_saturate_u_i8x16 use signed and unsigned
element types, respectively.

Diff Detail

Event Timeline

sunfish created this revision.Sat, Aug 1, 7:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Aug 1, 7:53 AM
sunfish requested review of this revision.Sat, Aug 1, 7:53 AM
tlively accepted this revision.Sun, Aug 2, 10:54 AM

Nice! Thanks for doing that :)

This revision is now accepted and ready to land.Sun, Aug 2, 10:54 AM
sunfish updated this revision to Diff 282608.Mon, Aug 3, 6:45 AM
  • Update clang/test/CodeGen/builtins-wasm.c.
This revision was landed with ongoing or failed builds.Tue, Aug 4, 12:49 PM
This revision was automatically updated to reflect the committed changes.