Page MenuHomePhabricator

[Attributor][Not for commit] Make call site specific deduction default.
Needs ReviewPublic

Authored by kuter on Tue, Jul 28, 6:55 AM.

Details

Summary

Interesting, not as many tests as I expected where effected.
I will look for tests that should have been effected but are not.

I have tried increasing the default depth argument

Diff Detail

Event Timeline

kuter created this revision.Tue, Jul 28, 6:55 AM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
kuter requested review of this revision.Tue, Jul 28, 6:55 AM
kuter planned changes to this revision.Tue, Jul 28, 7:59 AM

Some Attributes that have CBContext doesn't seem to be querying the CB specific attributes.
I will update this once I have a solution.

llvm/test/Transforms/Attributor/nocapture-2.ll
319

Is this normal ?

kuter updated this revision to Diff 281521.Wed, Jul 29, 4:39 AM

add auto context injection.

I looked at some and we need to check what is happening.

llvm/test/Transforms/Attributor/ArgumentPromotion/control-flow.ll
36

Something is off.

llvm/test/Transforms/Attributor/IPConstantProp/solve-after-each-resolving-undefs-for-function.ll
65

I don't see this.

llvm/test/Transforms/Attributor/memory_locations.ll
614

This should be 1, shouldn't it?

llvm/test/Transforms/Attributor/nocapture-2.ll
319

It can make sense, haven't verified it though.