- User Since
- Mar 5 2020, 1:46 PM (23 w, 1 d)
Mon, Aug 3
Sat, Aug 1
Thu, Jul 30
Wed, Jul 29
add auto context injection.
Tue, Jul 28
Some Attributes that have CBContext doesn't seem to be querying the CB specific attributes.
I will update this once I have a solution.
remove unused header.
add unit test.
fix bug (😄)
Mon, Jul 27
Manually requesting review, since the Phabricator wasn't able to built this. From what I can see it was missing the parent revision with the last build.
Pre-merge checks should be ok now.
add range contents as test.
Sat, Jul 25
Fri, Jul 24
add missing code.
remove unneeded definies.
Thu, Jul 23
Mon, Jul 20
Memory usage for this patch:
comand: $LLVM_BIN/opt -S -attributor-cgscc test-suit/CTMark/SPASS/clause.ll
calls to allocation functions: 78794 (82506/s) temporary memory allocations: 3942 (4127/s) peak heap memory consumption: 2.58MB peak RSS (including heaptrack overhead): 355.73MB total memory leaked: 140.33KB
calls to allocation functions: 78802 (86977/s) temporary memory allocations: 3942 (4350/s) peak heap memory consumption: 2.59MB peak RSS (including heaptrack overhead): 356.60MB total memory leaked: 140.33KB
calls to allocation functions: 8 (-163/s) temporary memory allocations: 0 (0/s) peak heap memory consumption: 8.26KB peak RSS (including heaptrack overhead): 0B total memory leaked: 0B
Interesting, there doesn't seem to be much of a difference.
Sun, Jul 19
fix wording. use pointer_iterator instead of for loop.
Sat, Jul 18
add missing documentation.
improve formating and readability.
rename command line option
fix run lines (there was a mistake in the earlier revision).
Add test combinations.
improve code readability.
Fri, Jul 17
Thu, Jul 16
add attributor-enable-call-site-specific=false as a test.
fix the run lines.
Jul 15 2020
merge with D83299
add positive and negative tests.
Jul 14 2020
merged with D83744
Jul 13 2020
D83744 uses this and has tests.
Hi @bbn when will commit this ?
Jul 12 2020
Jul 11 2020
- Better comments.
- Remove unneeded lines from the test.
Jul 8 2020
Jul 7 2020
Jul 6 2020
Introduce test for the command line option
Jul 5 2020
Replace ternary expression with early return
This seems like too much code duplication.
I think we can have a macro to declare getIdAddr and the getName function.
I am curious what other people think about this.
Jul 4 2020
Jul 3 2020
Jul 2 2020
Btw this patch introduces 8 bytes per attribute because of the CBContext.
I think we would ideally move it to a map inside the attributor.
general bug fix.
Jun 29 2020
Hi can you rebase this.
Jun 26 2020
Jun 25 2020
Jun 16 2020
Jun 11 2020
@bbn Soo, I just realized that this way of implementing GraphTraits might be problematic with
graph iterators like (scc_iterator, df_ iterator) since they require a single entry point to correctly handle
disconnected graphs and the Attributor dependencies are disconnected. Most disconnected graphs use a "synthetic node"
because of this.
Jun 8 2020
What do you mean by "put the GraphTraits in llvm namespace"?
This does not compile for me. The compiler error that I get is about creating a GraphTraits specialization outside of the llvm namespace.
When i put the GraphTraits specializations in llvm namespace it does compile.
Jun 5 2020
add newline after function declaration
Jun 4 2020
- rename ::runScheduler to ::runTillFixpoint
- improve comments for ::runTillFixpoint
Jun 2 2020
Jun 1 2020
Hi, what is the state of this ?
As of D78729 a AbstractAttribute keeps track of its own dependencies.
Apr 10 2020
Small logic change in GEPOperator::accumulateConstantOffset to bailout on scalable vector types
except for when the offset is zero.
Not allowing zero breaks @test_accumulate_constant_offset_vscale_zero
Mar 26 2020
Mar 25 2020
Eliminated redundant debug messages, Style fixes, Added negative test case,
Don't use external analysis if the get operand is a struct type.