Page MenuHomePhabricator

kuter (Kuter Dinel)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2020, 1:46 PM (23 w, 1 d)

Recent Activity

Mon, Aug 3

kuter added inline comments to D85131: [NFC][APInt][DenseMapInfo] Move DenseMapAPIntKeyInfo into DenseMap.h as DenseMapInfo<APInt>.
Mon, Aug 3, 8:34 AM · Restricted Project
kuter added inline comments to D85131: [NFC][APInt][DenseMapInfo] Move DenseMapAPIntKeyInfo into DenseMap.h as DenseMapInfo<APInt>.
Mon, Aug 3, 7:30 AM · Restricted Project

Sat, Aug 1

kuter added a comment to D85065: [Attributor][NFC] Update description for the dependency graph.

Thank you.

Sat, Aug 1, 6:01 AM · Restricted Project

Thu, Jul 30

kuter committed rG49def10e02e3: [Attributor] Add time trace support. (authored by kuter).
[Attributor] Add time trace support.
Thu, Jul 30, 5:19 PM
kuter closed D84980: [Attributor] Add time trace support..
Thu, Jul 30, 5:18 PM · Restricted Project
kuter added a comment to D84980: [Attributor] Add time trace support..

Really cool :) LGTM

Thu, Jul 30, 2:12 PM · Restricted Project
kuter requested review of D84980: [Attributor] Add time trace support..
Thu, Jul 30, 1:38 PM · Restricted Project

Wed, Jul 29

kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Wed, Jul 29, 9:19 PM · Restricted Project
kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Wed, Jul 29, 9:09 PM · Restricted Project
kuter added inline comments to D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..
Wed, Jul 29, 4:48 AM · Restricted Project
kuter added a comment to D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..

Can you, maybe as a separate patch, run the update script with the call site deduction enabled *before* this patch and *after* to get the difference on all tests we have?

Wed, Jul 29, 4:44 AM · Restricted Project
kuter updated the diff for D84751: [Attributor][Not for commit] Make call site specific deduction default..

add auto context injection.

Wed, Jul 29, 4:39 AM · Restricted Project

Tue, Jul 28

kuter planned changes to D84751: [Attributor][Not for commit] Make call site specific deduction default..

Some Attributes that have CBContext doesn't seem to be querying the CB specific attributes.
I will update this once I have a solution.

Tue, Jul 28, 7:59 AM · Restricted Project
kuter requested review of D84751: [Attributor][Not for commit] Make call site specific deduction default..
Tue, Jul 28, 6:55 AM · Restricted Project
kuter retitled D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead. from Call site specific AAValueSimplification and AAIsDead. to [Attributor] Call site specific AAValueSimplification and AAIsDead..
Tue, Jul 28, 5:02 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

remove unused header.

Tue, Jul 28, 5:00 AM · Restricted Project
kuter retitled D83738: [Attributor]Introduce call base context argument pathway. from [Attributor][WIP]Introduce call base context argument pathway. to [Attributor]Introduce call base context argument pathway..
Tue, Jul 28, 4:57 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

add unit test.
fix bug (😄)
fix typo.

Tue, Jul 28, 4:56 AM · Restricted Project

Mon, Jul 27

kuter requested review of D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead..

Manually requesting review, since the Phabricator wasn't able to built this. From what I can see it was missing the parent revision with the last build.
Pre-merge checks should be ok now.

Mon, Jul 27, 9:53 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

bug fix.
add range contents as test.

Mon, Jul 27, 7:25 PM · Restricted Project

Sat, Jul 25

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix tests.

Sat, Jul 25, 4:53 PM · Restricted Project

Fri, Jul 24

kuter added inline comments to D84532: [Attributor] Fix qualifier warning of the unittest.
Fri, Jul 24, 8:25 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

add missing code.
remove unneeded definies.
fix bug.

Fri, Jul 24, 6:48 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

LGTM with nits.

Fri, Jul 24, 4:37 PM · Restricted Project

Thu, Jul 23

kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

fix styling.

Thu, Jul 23, 5:21 PM · Restricted Project

Mon, Jul 20

kuter retitled D81929: [Attributor] Introduce CallBaseContext to the IRPosition from [WIP][Attributor] Introduce CallBaseContext to the IRPosition to [Attributor] Introduce CallBaseContext to the IRPosition.
Mon, Jul 20, 9:33 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Add unittest.

Mon, Jul 20, 9:32 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Memory usage for this patch:
comand: $LLVM_BIN/opt -S -attributor-cgscc test-suit/CTMark/SPASS/clause.ll
before:

calls to allocation functions: 78794 (82506/s)
temporary memory allocations: 3942 (4127/s)
peak heap memory consumption: 2.58MB
peak RSS (including heaptrack overhead): 355.73MB
total memory leaked: 140.33KB

after:

calls to allocation functions: 78802 (86977/s)
temporary memory allocations: 3942 (4350/s)
peak heap memory consumption: 2.59MB
peak RSS (including heaptrack overhead): 356.60MB
total memory leaked: 140.33KB

difference:

calls to allocation functions: 8 (-163/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: 8.26KB
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Interesting, there doesn't seem to be much of a difference.

Mon, Jul 20, 9:16 PM · Restricted Project

Sun, Jul 19

kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

All this is missing now is a test :). We can just check for the debug output.

Sun, Jul 19, 5:32 PM · Restricted Project
kuter added inline comments to D83744: [Attributor] Attributor call site specific AAValueConstantRange.
Sun, Jul 19, 11:31 AM · Restricted Project
kuter added inline comments to D83738: [Attributor]Introduce call base context argument pathway..
Sun, Jul 19, 12:41 AM · Restricted Project
kuter updated the diff for D83738: [Attributor]Introduce call base context argument pathway..

fix wording. use pointer_iterator instead of for loop.
fix naming.

Sun, Jul 19, 12:39 AM · Restricted Project

Sat, Jul 18

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

small improvements.

Sat, Jul 18, 11:48 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

add missing documentation.
improve formating and readability.
fix typos.
rename command line option

Sat, Jul 18, 9:05 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix run lines (there was a mistake in the earlier revision).

Sat, Jul 18, 4:53 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Add test combinations.

Sat, Jul 18, 4:23 PM · Restricted Project
kuter added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Some minor comments below.

Upload diffs with full context please.

Sat, Jul 18, 3:29 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

fix typo.
improve code readability.

Sat, Jul 18, 3:28 PM · Restricted Project

Fri, Jul 17

kuter added inline comments to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.
Fri, Jul 17, 8:19 PM · Restricted Project

Thu, Jul 16

kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

add attributor-enable-call-site-specific=false as a test.
fix the run lines.

Thu, Jul 16, 4:29 PM · Restricted Project

Jul 15 2020

kuter added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

Cool! As discussed, merge D83299 and add new call sites for test1.

Jul 15 2020, 2:33 PM · Restricted Project
kuter updated the diff for D83744: [Attributor] Attributor call site specific AAValueConstantRange.

merge with D83299
add positive and negative tests.

Jul 15 2020, 8:25 AM · Restricted Project

Jul 14 2020

kuter abandoned D83299: [Attributor] [WIP] Introduce callbase context bridges..

merged with D83744

Jul 14 2020, 8:42 AM · Restricted Project

Jul 13 2020

kuter updated the summary of D83744: [Attributor] Attributor call site specific AAValueConstantRange.
Jul 13 2020, 11:08 PM · Restricted Project
kuter added a comment to D83299: [Attributor] [WIP] Introduce callbase context bridges..

Can we include some code that triggers this so we can tests it?

D83744 uses this and has tests.

Jul 13 2020, 11:07 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Fix typo

Jul 13 2020, 10:42 PM · Restricted Project
kuter planned changes to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 13 2020, 10:31 PM · Restricted Project
kuter retitled D83744: [Attributor] Attributor call site specific AAValueConstantRange from [Attributor] Attributor call base specific AAValueConstantRange to [Attributor] Attributor call site specific AAValueConstantRange.
Jul 13 2020, 10:25 PM · Restricted Project
Herald added a project to D83744: [Attributor] Attributor call site specific AAValueConstantRange: Restricted Project.
Jul 13 2020, 10:16 PM · Restricted Project
kuter updated the summary of D83738: [Attributor]Introduce call base context argument pathway..
Jul 13 2020, 9:05 PM · Restricted Project
Herald added a project to D83738: [Attributor]Introduce call base context argument pathway.: Restricted Project.
Jul 13 2020, 9:03 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

Hi @bbn when will commit this ?

Jul 13 2020, 5:16 PM · Restricted Project

Jul 12 2020

kuter added a comment to D82861: [Attributor] Add AAValueSimplifyCallSiteArgument::manifest.

Can you merge this?

Do I have a right to merge this by myself? I did arc patch and tried to git push https://github.com/llvm/llvm-project.git HEAD:master according to the document, but I failed to do that.

Did you get the commit access? If so, what problems did you have with git push?

I got the following message with git push

remote: Permission to llvm/llvm-project.git denied to okuraofvegetable.
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403

From this message, it seems to me that I don't have commit access.

Jul 12 2020, 4:58 AM · Restricted Project
kuter closed D83185: [Attributor] Introduce Attribute seed allow list..
Jul 12 2020, 4:32 AM · Restricted Project

Jul 11 2020

kuter committed rG4dbe82eef34e: [Attributor] Introudce attribute seed allow list. (authored by kuter).
[Attributor] Introudce attribute seed allow list.
Jul 11 2020, 4:42 PM
kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..
  1. Better comments.
  2. Remove unneeded lines from the test.
Jul 11 2020, 9:54 AM · Restricted Project

Jul 8 2020

kuter added inline comments to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 8 2020, 2:18 PM · Restricted Project
kuter added a comment to D83297: [Attributor][WIP] Attribute scheduling visualization..
In D83297#2138744, @bbn wrote:

Can we just merge the dependency graph and the "SchedulingGraph" because I think they are quite similar.

Jul 8 2020, 2:14 PM · Restricted Project

Jul 7 2020

kuter updated the diff for D83299: [Attributor] [WIP] Introduce callbase context bridges..
Jul 7 2020, 5:17 AM · Restricted Project
Herald added a project to D83299: [Attributor] [WIP] Introduce callbase context bridges.: Restricted Project.
Jul 7 2020, 5:07 AM · Restricted Project
kuter updated the summary of D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 7 2020, 5:00 AM · Restricted Project
Herald added a project to D83297: [Attributor][WIP] Attribute scheduling visualization.: Restricted Project.
Jul 7 2020, 5:00 AM · Restricted Project

Jul 6 2020

kuter added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Either is fine but I think it is more natural to forbid an empty list.

Do you mean returning a error if a empty --attributor-seed-allow-list option is present ?
Currently the size of list is being used to tell if a list is present or not.
I think I can use getNumOccurrences() to replace this behaviour .

Yes, I think replacing ZeroOrMore with OneOrMore is enoguh

Jul 6 2020, 3:27 PM · Restricted Project
kuter added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Either is fine but I think it is more natural to forbid an empty list.

Jul 6 2020, 3:02 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.
In D78861#2133485, @bbn wrote:

This looks pretty good :). Nice active review :)

I have some minor comments below. We also should add a test for the print and dot output.

I need some help here:
Is there a way to test the dot output? I checked the .dot file and found it hard to write CHECK lines (see below) because we are interested in the link between different graph nodes (line 3 and line 4)

	Node0x55be15e4f7d0 [shape=record,label="{[AAValueSimplify] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{arg: [@0]\} with state simplified\n}"];
	Node0x55be15e4f810 [shape=record,label="{[AANoUnwind] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{fn:checkAndAdvance [checkAndAdvance@-1]\} with state nounwind\n}"];
	Node0x55be15e4f810 -> Node0x55be15e500b0;
	Node0x55be15e4f810 -> Node0x55be15e500b0;

I have referred to some other similar tests like the *cfg_deopt_unreach.ll*, but none of theme shows how to write check lines for such testcases.

Jul 6 2020, 2:48 PM · Restricted Project
kuter added inline comments to D83185: [Attributor] Introduce Attribute seed allow list..
Jul 6 2020, 5:59 AM · Restricted Project
kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..

Introduce test for the command line option

Jul 6 2020, 5:57 AM · Restricted Project

Jul 5 2020

kuter updated the diff for D83185: [Attributor] Introduce Attribute seed allow list..

Replace ternary expression with early return

Jul 5 2020, 5:35 PM · Restricted Project
Herald added a reviewer for D83185: [Attributor] Introduce Attribute seed allow list.: uenoku.
Jul 5 2020, 5:35 PM · Restricted Project
kuter added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.
In D83172#2131779, @bbn wrote:

Attributes are going to be decleared outside of the Attributor soon.

Do you mean that there might be other abstract attributes defined outside the AttributorAttributes.cpp ?

As of yesterday, there is an AA outside of AttributorAttributes :). You should rebase.

so I think we can have a macro like this:

#define ATTRIBUTE_BOILER(CLASS)                    \
    const char *getIdAddr() { return &ID}                 \
    const std::string getName() { return #CLASS;}   \
    static const char ID;

Yes this could work, but I am still unsure about it..... I'd also like to hear what others think about this.

I mean it is not that much code. Maybe I'm missing something, but why not just use ID directly?

Jul 5 2020, 5:19 AM · Restricted Project
kuter added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.
In D83172#2131751, @bbn wrote:

@kuter Do you mean we can use macro inside the header file? for example, we create such macro and use it inside the declaration of the class, but I still think it is not clean.

Jul 5 2020, 3:12 AM · Restricted Project
kuter added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.

This seems like too much code duplication.
I think we can have a macro to declare getIdAddr and the getName function.
I am curious what other people think about this.

Jul 5 2020, 1:33 AM · Restricted Project

Jul 4 2020

kuter added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 4 2020, 8:35 AM · Restricted Project

Jul 3 2020

kuter added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 3 2020, 1:03 AM · Restricted Project

Jul 2 2020

kuter added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 2 2020, 11:10 PM · Restricted Project
kuter added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 2 2020, 9:35 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

Btw this patch introduces 8 bytes per attribute because of the CBContext.
I think we would ideally move it to a map inside the attributor.

Jul 2 2020, 9:03 PM · Restricted Project
kuter updated the diff for D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

general bug fix.

Jul 2 2020, 9:01 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

We need some way of testing this, so tests that enable this and some way of checking the output. We could look for the debug output or add some other way of checking

Reverse ping. Unit tests might also be an option.

Wouldn't just testing the uses of this path enough.
For example if we have are getting a correct call site constant range would that be enough ?

Is the CBContext already used? I might have to take another look at this, sorry.

Jul 2 2020, 5:50 PM · Restricted Project
kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

We need some way of testing this, so tests that enable this and some way of checking the output. We could look for the debug output or add some other way of checking

Reverse ping. Unit tests might also be an option.

Jul 2 2020, 3:08 PM · Restricted Project

Jun 29 2020

Herald added a reviewer for D78861: [Attributor] Track AA dependency using dependency graph: homerdin.

Hi can you rebase this.

Jun 29 2020, 7:47 PM · Restricted Project

Jun 26 2020

kuter added a comment to D82625: [Attributor][NFC] Replace call site with call base..

I think replacing all makes the code hard to understand (because "call base" is just a name of LLVM class)
Personally, I prefer maintaining "call site"

Jun 26 2020, 5:48 PM · Restricted Project

Jun 25 2020

kuter created D82625: [Attributor][NFC] Replace call site with call base..
Jun 25 2020, 11:25 PM · Restricted Project

Jun 16 2020

kuter added a comment to D81929: [Attributor] Introduce CallBaseContext to the IRPosition.

TODO: comments

Jun 16 2020, 5:31 AM · Restricted Project
Herald added a reviewer for D81929: [Attributor] Introduce CallBaseContext to the IRPosition: sstefan1.
Jun 16 2020, 5:31 AM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.
Jun 16 2020, 3:50 AM · Restricted Project

Jun 11 2020

kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

@bbn Soo, I just realized that this way of implementing GraphTraits might be problematic with
graph iterators like (scc_iterator, df_ iterator) since they require a single entry point to correctly handle
disconnected graphs and the Attributor dependencies are disconnected. Most disconnected graphs use a "synthetic node"
because of this.

Jun 11 2020, 4:13 AM · Restricted Project

Jun 8 2020

kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

What do you mean by "put the GraphTraits in llvm namespace"?

Jun 8 2020, 6:50 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

This does not compile for me. The compiler error that I get is about creating a GraphTraits specialization outside of the llvm namespace.
When i put the GraphTraits specializations in llvm namespace it does compile.

But when I run it I get a segfault.

Jun 8 2020, 6:50 PM · Restricted Project
kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

This does not compile for me. The compiler error that I get is about creating a GraphTraits specialization outside of the llvm namespace.
When i put the GraphTraits specializations in llvm namespace it does compile.

Jun 8 2020, 6:17 PM · Restricted Project

Jun 5 2020

kuter updated the diff for D81022: [Attributor] Split the Attributor::run() into multiple functions..

add newline after function declaration

Jun 5 2020, 6:27 PM · Restricted Project

Jun 4 2020

kuter updated the diff for D81022: [Attributor] Split the Attributor::run() into multiple functions..
  1. rename ::runScheduler to ::runTillFixpoint
  2. improve comments for ::runTillFixpoint
Jun 4 2020, 4:36 PM · Restricted Project

Jun 2 2020

Herald added a reviewer for D81022: [Attributor] Split the Attributor::run() into multiple functions.: sstefan1.
Jun 2 2020, 11:32 AM · Restricted Project

Jun 1 2020

kuter added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

Hi, what is the state of this ?
As of D78729 a AbstractAttribute keeps track of its own dependencies.

Jun 1 2020, 7:28 AM · Restricted Project

Apr 10 2020

kuter added a comment to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Apologies for the delay, can you rebase this and provide me with "Firstname Lastname <email>" from you so I can attribute it to you?

Apr 10 2020, 4:49 AM · Restricted Project
kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Rebased.
Small logic change in GEPOperator::accumulateConstantOffset to bailout on scalable vector types
except for when the offset is zero.
Not allowing zero breaks @test_accumulate_constant_offset_vscale_zero

Apr 10 2020, 4:49 AM · Restricted Project

Mar 26 2020

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Mar 26 2020, 5:57 PM · Restricted Project

Mar 25 2020

kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Simplfy accumulateConstantOffset

Mar 25 2020, 2:38 PM · Restricted Project
kuter added inline comments to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Mar 25 2020, 8:37 AM · Restricted Project
kuter updated the diff for D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..

Eliminated redundant debug messages, Style fixes, Added negative test case,
Don't use external analysis if the get operand is a struct type.

Mar 25 2020, 8:04 AM · Restricted Project