This is an archive of the discontinued LLVM Phabricator instance.

Differential D84686

[OldPM] Print out a bit more when passes lie about changing IR
ClosedPublic

Authored by jroelofs on Jul 27 2020, 11:37 AM.

Details

Reviewers
serge-sans-paille

Diff Detail

Unit TestsFailed

TimeTest
190 mslinux > Polly.ScopInfo::Unknown Unit Message ("")

Event Timeline

jroelofs created this revision.Jul 27 2020, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2020, 11:37 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B65885: Diff 280994!Jul 27 2020, 12:56 PM
serge-sans-paille accepted this revision.Jul 27 2020, 1:25 PM

LGTM, that's indeed a more helpful message. Thanks!

This revision is now accepted and ready to land.Jul 27 2020, 1:25 PM
jroelofs mentioned this in rG736423af53d7: [OldPM] Print out a bit more when passes lie about changing IR.Jul 28 2020, 9:01 AM
jroelofs closed this revision.Jul 28 2020, 10:29 AM

736423af53d707e097a174c3a91b75132b8dc6b1

Revision Contents

PathSize
llvm/
lib/
IR/
9 lines

Diff 280994

llvm/lib/IR/LegacyPassManager.cpp

Show All 17 Lines
{ {
PassManagerPrettyStackEntry X(FP, F); PassManagerPrettyStackEntry X(FP, F);
TimeRegion PassTimer(getPassTimer(FP)); TimeRegion PassTimer(getPassTimer(FP));
#ifdef EXPENSIVE_CHECKS #ifdef EXPENSIVE_CHECKS
uint64_t RefHash = StructuralHash(F); uint64_t RefHash = StructuralHash(F);
#endif #endif
LocalChanged |= FP->runOnFunction(F); LocalChanged |= FP->runOnFunction(F);
#ifdef EXPENSIVE_CHECKS #if defined(EXPENSIVE_CHECKS) && !defined(NDEBUG)
assert((LocalChanged || (RefHash == StructuralHash(F))) && if (!LocalChanged && (RefHash != StructuralHash(F))) {
"Pass modifies its input and doesn't report it."); llvm::errs() << "Pass modifies its input and doesn't report it: "
<< FP->getPassName() << "\n";
assert(false && "Pass modifies its input and doesn't report it.");
}
#endif #endif
if (EmitICRemark) { if (EmitICRemark) {
unsigned NewSize = F.getInstructionCount(); unsigned NewSize = F.getInstructionCount();
// Update the size of the function, emit a remark, and update the size // Update the size of the function, emit a remark, and update the size
// of the module. // of the module.
if (NewSize != FunctionSize) { if (NewSize != FunctionSize) {
Show All 17 Lines