Page MenuHomePhabricator

jroelofs (Jon Roelofs)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2013, 1:02 PM (348 w, 5 d)

Recent Activity

Yesterday

jroelofs committed rG7f1556f292cc: Fix typo: s/epomymous/eponymous/ NFC (authored by jroelofs).
Fix typo: s/epomymous/eponymous/ NFC
Mon, Aug 3, 1:10 PM
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..
Mon, Aug 3, 8:48 AM · Restricted Project, Restricted Project

Fri, Jul 31

jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?

Fri, Jul 31, 11:26 AM · Restricted Project, Restricted Project
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Mind doing the same thing for libcxxabi? I think it has the same problem.

Fri, Jul 31, 9:02 AM · Restricted Project, Restricted Project
jroelofs accepted D85004: [libunwind] Make the test depend on the libunwind explicitly..

LGTM, thank you!

Fri, Jul 31, 9:02 AM · Restricted Project, Restricted Project

Thu, Jul 30

jroelofs committed rGafae6d97fa55: [SelectionDAG] Fix lowering of vector geps (authored by jroelofs).
[SelectionDAG] Fix lowering of vector geps
Thu, Jul 30, 1:57 PM
jroelofs closed D84884: [SelectionDAG] Fix lowering of vector geps.
Thu, Jul 30, 1:57 PM · Restricted Project

Wed, Jul 29

jroelofs abandoned D23838: Unsuccessful stab at fuzzing for the bug in D23362.
Wed, Jul 29, 2:00 PM
jroelofs abandoned D32178: Delete unstable integration tests.
Wed, Jul 29, 1:59 PM
jroelofs abandoned D32866: Fix -DLLVM_BUILD_TESTS=ON lldb build.
Wed, Jul 29, 1:58 PM
jroelofs abandoned D39146: WIP: fix ldscript AT> parsing.
Wed, Jul 29, 1:58 PM
jroelofs requested review of D84884: [SelectionDAG] Fix lowering of vector geps.
Wed, Jul 29, 12:18 PM · Restricted Project

Tue, Jul 28

jroelofs added inline comments to D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Tue, Jul 28, 4:30 PM · Restricted Project
jroelofs updated subscribers of D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Tue, Jul 28, 4:28 PM · Restricted Project
jroelofs added a comment to rG7bae3188e087: [clang-tidy][NFC] Make OptionsView methods as const where missing.

@njames93 I believe this change broke one of the buildbots (verified by reverting it locally). Mind taking a look? From a quick glance, I can't tell where the functional change is here.

Tue, Jul 28, 1:00 PM
jroelofs closed D84686: [OldPM] Print out a bit more when passes lie about changing IR.

736423af53d707e097a174c3a91b75132b8dc6b1

Tue, Jul 28, 10:29 AM · Restricted Project
jroelofs committed rG736423af53d7: [OldPM] Print out a bit more when passes lie about changing IR (authored by jroelofs).
[OldPM] Print out a bit more when passes lie about changing IR
Tue, Jul 28, 9:01 AM
jroelofs added a reverting change for rGb647d5d21dd8: [lit] Remove --repeat option, which wasn't that useful.: D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Tue, Jul 28, 8:24 AM
jroelofs requested review of D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Tue, Jul 28, 8:24 AM · Restricted Project

Mon, Jul 27

jroelofs committed rG6dadf7cb654c: [llvm][examples][SimplifyCFG] Fix pass's IR changed reporting (authored by jroelofs).
[llvm][examples][SimplifyCFG] Fix pass's IR changed reporting
Mon, Jul 27, 12:40 PM
Herald added a project to D84686: [OldPM] Print out a bit more when passes lie about changing IR: Restricted Project.
Mon, Jul 27, 11:37 AM · Restricted Project
jroelofs added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

LG to me, but probably wait a bit for @jroelofs.

Mon, Jul 27, 10:15 AM · Restricted Project
jroelofs committed rG88ce9f9b441e: [TableGen][CGS] Print better errors on overlapping InstRW (authored by jroelofs).
[TableGen][CGS] Print better errors on overlapping InstRW
Mon, Jul 27, 8:41 AM
jroelofs closed D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Mon, Jul 27, 8:41 AM · Restricted Project
jroelofs committed rGf5e1ec8c5804: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv (authored by jroelofs).
[AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv
Mon, Jul 27, 8:18 AM
jroelofs closed D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Mon, Jul 27, 8:18 AM · Restricted Project

Fri, Jul 24

jroelofs added a comment to rGf7ffb122d08e: [libFuzzer] Instrument bcmp.

4dc3014c51fda2a3189318c4ae54c4da9cfc6a0e

Fri, Jul 24, 1:56 PM
jroelofs committed rG4dc3014c51fd: [compiler-rt][fuzzer] Disable bcmp.test on darwin (authored by jroelofs).
[compiler-rt][fuzzer] Disable bcmp.test on darwin
Fri, Jul 24, 1:56 PM
jroelofs added a comment to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Optional: since they are really small tests, you can try if it is convenient to have them all in one file, but separate is fine too I think.

Fri, Jul 24, 1:48 PM · Restricted Project
jroelofs added a comment to D84450: Testcase for "More conservatively report status from LoopIdiomRecognize".

Thanks for sharing. I did not manage to get it to crash with the patches removed though :(

Fri, Jul 24, 1:45 PM · Restricted Project
jroelofs added a comment to rGf7ffb122d08e: [libFuzzer] Instrument bcmp.

@MaskRay I believe this broke one of the buildbots when it landed. Mind taking a look?

Fri, Jul 24, 12:30 PM
jroelofs added a comment to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Kinda verbose, but it works. This would be so much easier if we had a way to dump mir from llvm-mc.

Fri, Jul 24, 10:06 AM · Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

rm subsumed test

Fri, Jul 24, 10:05 AM · Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Fri, Jul 24, 10:03 AM · Restricted Project
jroelofs added inline comments to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Fri, Jul 24, 9:41 AM · Restricted Project
jroelofs added inline comments to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Fri, Jul 24, 9:39 AM · Restricted Project
jroelofs added inline comments to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Fri, Jul 24, 9:25 AM · Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.
Fri, Jul 24, 8:52 AM · Restricted Project
jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Add mir tests for each of the affected instructions.

Fri, Jul 24, 8:18 AM · Restricted Project

Thu, Jul 23

jroelofs updated the diff for D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

Add a test for the changes for fjcvtzs.

Thu, Jul 23, 12:56 PM · Restricted Project
jroelofs added a comment to D84071: More conservatively report status from LoopIdiomRecognize.

Do you happen to still have the test case for this? If it is reasonably small, would it be possible to add to the tests?

I have the IR, but the assert doesn't repro if I run it through the pass via opt. I'll see if I can reduce it a bit so we at least have a test where the PM reports the change.

Thu, Jul 23, 11:06 AM · Restricted Project
Herald added a project to D84450: Testcase for "More conservatively report status from LoopIdiomRecognize": Restricted Project.
Thu, Jul 23, 11:04 AM · Restricted Project
jroelofs added a comment to D84071: More conservatively report status from LoopIdiomRecognize.

Do you happen to still have the test case for this? If it is reasonably small, would it be possible to add to the tests?

Thu, Jul 23, 9:22 AM · Restricted Project

Wed, Jul 22

jroelofs added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Wed, Jul 22, 4:28 PM · Restricted Project
jroelofs added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Wed, Jul 22, 4:20 PM · Restricted Project
jroelofs updated the diff for D83588: [TableGen][CGS] Print better errors on overlapping InstRW.

add test case, clang-format

Wed, Jul 22, 3:14 PM · Restricted Project
jroelofs added inline comments to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..
Wed, Jul 22, 10:32 AM · Restricted Project
jroelofs added a comment to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv.

@SjoerdMeijer mind double-checking me on this?

Wed, Jul 22, 9:45 AM · Restricted Project
jroelofs added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

Good call. This is definitely a better place for that to live.

Wed, Jul 22, 9:23 AM · Restricted Project

Tue, Jul 21

jroelofs updated the diff for D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
  • Add back the "also matches previous" part of the diagnostics.
  • Fix formatting that the linter complains about.
Tue, Jul 21, 11:58 AM · Restricted Project
jroelofs committed rGb9fc20ebe7cd: [compiler-rt][test][profile] Fix missing include (authored by jroelofs).
[compiler-rt][test][profile] Fix missing include
Tue, Jul 21, 11:00 AM
jroelofs closed D84207: [compiler-rt][test][profile] Fix missing include.
Tue, Jul 21, 11:00 AM · Restricted Project
jroelofs added a comment to D84207: [compiler-rt][test][profile] Fix missing include.

LGTM. Thanks for fixing it!

... on systems where wait() isn't one of the declarations transitively included via unistd.h.

Hope you can just be more specific about this - on which particular system wait() isn't transitively included via unistd.h
It conveys more information and helps posterity when they are reading the log.

Tue, Jul 21, 10:55 AM · Restricted Project
jroelofs committed rGdc09c65f638f: LoopIdiomRecognize: use ExpandedValuesCleaner in another place (authored by jroelofs).
LoopIdiomRecognize: use ExpandedValuesCleaner in another place
Tue, Jul 21, 8:32 AM
jroelofs committed rG4d75cc4b0a64: More conservatively report status from LoopIdiomRecognize (authored by jroelofs).
More conservatively report status from LoopIdiomRecognize
Tue, Jul 21, 8:32 AM
jroelofs closed D84174: LoopIdiomRecognize: use ExpandedValuesCleaner in another place.
Tue, Jul 21, 8:32 AM · Restricted Project
jroelofs closed D84071: More conservatively report status from LoopIdiomRecognize.
Tue, Jul 21, 8:32 AM · Restricted Project
jroelofs updated the diff for D84207: [compiler-rt][test][profile] Fix missing include.

review feedback

Tue, Jul 21, 7:32 AM · Restricted Project
jroelofs added inline comments to D84207: [compiler-rt][test][profile] Fix missing include.
Tue, Jul 21, 7:31 AM · Restricted Project

Mon, Jul 20

Herald added a project to D84207: [compiler-rt][test][profile] Fix missing include: Restricted Project.
Mon, Jul 20, 9:16 PM · Restricted Project
jroelofs added inline comments to D84071: More conservatively report status from LoopIdiomRecognize.
Mon, Jul 20, 7:52 AM · Restricted Project
Herald added a project to D84174: LoopIdiomRecognize: use ExpandedValuesCleaner in another place: Restricted Project.
Mon, Jul 20, 7:51 AM · Restricted Project

Fri, Jul 17

Herald added a project to D84071: More conservatively report status from LoopIdiomRecognize: Restricted Project.
Fri, Jul 17, 2:03 PM · Restricted Project

Thu, Jul 16

jroelofs committed rG2cf3458c3b29: [tsan][go] Fix for missing symbols needed by GotsanRuntimeCheck (authored by jroelofs).
[tsan][go] Fix for missing symbols needed by GotsanRuntimeCheck
Thu, Jul 16, 4:01 PM
jroelofs committed rGa0537fc35f0e: [SimplifyCFG] Fix crash in the EXPENSIVE_CHECKS build (authored by jroelofs).
[SimplifyCFG] Fix crash in the EXPENSIVE_CHECKS build
Thu, Jul 16, 2:35 PM
jroelofs closed D83985: [SimplifyCFG] Fix crash in the EXPENSIVE_CHECKS build.
Thu, Jul 16, 2:35 PM · Restricted Project
Herald added a project to D83985: [SimplifyCFG] Fix crash in the EXPENSIVE_CHECKS build: Restricted Project.
Thu, Jul 16, 2:20 PM · Restricted Project
jroelofs abandoned D83908: [Local] Fix removeUnreachableBlocks change reporting.

I found a way to repro it, and this patch doesn't have an effect on it.

Thu, Jul 16, 9:29 AM · Restricted Project

Wed, Jul 15

Herald added a project to D83908: [Local] Fix removeUnreachableBlocks change reporting: Restricted Project.
Wed, Jul 15, 2:29 PM · Restricted Project
jroelofs added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

I don't understand the clang-tidy/clang-format complaints. I've formatted the code based on how the surrounding code is formatted.

Wed, Jul 15, 10:32 AM · Restricted Project

Tue, Jul 14

Herald added a project to D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv: Restricted Project.
Tue, Jul 14, 2:52 PM · Restricted Project

Mon, Jul 13

jroelofs updated the diff for D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Mon, Jul 13, 8:22 AM · Restricted Project
jroelofs added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Mon, Jul 13, 7:46 AM · Restricted Project

Fri, Jul 10

Herald added a project to D83588: [TableGen][CGS] Print better errors on overlapping InstRW: Restricted Project.
Fri, Jul 10, 2:01 PM · Restricted Project

Jul 2 2020

jroelofs committed rG3c72cafdf407: Fix missing build dependencies on omp_gen (authored by jroelofs).
Fix missing build dependencies on omp_gen
Jul 2 2020, 7:00 AM
jroelofs added a comment to D83003: Fix missing build dependencies on omp_gen.
Jul 2 2020, 7:00 AM · Restricted Project
jroelofs closed D83003: Fix missing build dependencies on omp_gen.
Jul 2 2020, 7:00 AM · Restricted Project

Jul 1 2020

jroelofs created D83003: Fix missing build dependencies on omp_gen.
Jul 1 2020, 3:40 PM · Restricted Project

Jun 1 2020

jroelofs accepted D80947: Add to the Coding Standard our that single-line bodies omit braces.

LGTM

Jun 1 2020, 12:59 PM · Restricted Project

May 29 2020

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

There's probably not much risk of false negatives with that, but I don't know for sure.

May 29 2020, 8:39 AM · Restricted Project

May 27 2020

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

This will still cause a small number of false positives (e.g. the three llvm-readobj tests would all generate them, I believe), but it would be easier to reorganise the comment to not trip over it without making it look "ugly" and inconsistent with other comments elsewhere. I guess there might be some false negatives, but I doubt there'd be all that many at all?

I like that too. I'll prototype this, and see if I can get some concrete numbers on the change in diagnosed cases. Also promise to summarize on llvm-dev (haven't sparked that discussion back up yet since I've been quite busy, but I definitely see the importance / value of it).

May 27 2020, 11:23 AM · Restricted Project

May 26 2020

jroelofs committed rG1e06b169be3e: [clang][docs] Document additional bits of libc that -ffreestanding envs must… (authored by jroelofs).
[clang][docs] Document additional bits of libc that -ffreestanding envs must…
May 26 2020, 2:45 PM
jroelofs closed D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide.

1e06b169be3e59799b8dcaf16d1d03bd4c12da42

May 26 2020, 2:44 PM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

The error message improvement will help somewhat, but it doesn't solve the initial problem of "I wrote my comment in the same style as all the surrounding tests, it is easy to read in its current form, but not FileCheck wants me to change it to something that doesn't read as well (because it starts looking like a FileCheck/lit directive which has some meaning)."

May 26 2020, 11:25 AM · Restricted Project

May 22 2020

jroelofs created D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide.
May 22 2020, 6:23 AM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

I saw the benefit initially when the proposal was made, but now seeing the consequence in practice in the tools tests at least makes me realise I'm not a fan of the change to make FileCheck error if it sees the string somewhere else in the line. In particular, GNU and LLVM are common prefixes used to distinguish checks for different output modes, but also will often appear in comments to explain the test cases. Similar comments apply to the machine names etc. Needing to add COM is unobvious, and makes the comments messier to read, I found, as soon as I started reading.

Let’s not lose sight of the fact that this whole change is a trade off: we are attempting to trade comment succinctness/obviousness for the ability to diagnose a particularly nasty failure mode of missing colons. This comment thing may not be the right tradeoff, but given how constrained the problem space is, I suspect we will end up sacrificing a bit of intuitiveness somewhere regardless. So long as these new diagnosed-but-unintuitive cases aren’t too frequent/annoying, IMO that’s a better place to be than having room for the other not-diagnosable-and-unintuitive failure mode.

May 22 2020, 5:51 AM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

Why was this landed? There was varying degrees of dislike from more than one reviewer (myself, and @MaskRay at least). Please revert pending a conclusion to the discussion. This has hardly reached consensus.

May 22 2020, 5:18 AM · Restricted Project
jroelofs committed rG5a8db275f8fc: Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in… (authored by jroelofs).
Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in…
May 22 2020, 4:45 AM
jroelofs added a reverting change for rG183d6af08189: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC: rG5a8db275f8fc: Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in….
May 22 2020, 4:45 AM

May 21 2020

jroelofs committed rG5fb979dd0697: [llvm][test] Add missing FileCheck colons. NFC (authored by jroelofs).
[llvm][test] Add missing FileCheck colons. NFC
May 21 2020, 8:36 AM
jroelofs committed rG183d6af08189: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC (authored by jroelofs).
[llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC
May 21 2020, 8:36 AM
jroelofs closed D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

183d6af081899973f00fc24aeafcfc32de732f02

May 21 2020, 8:36 AM · Restricted Project

May 20 2020

jroelofs added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

@atanasyan there's one more case of this in llvm/test/CodeGen/Mips/ci2.ll. Looks like the constant has been de-duplicated since that test was written. Mind checking whether that's correct behavior for your target? (it does seem better, but I don't want to assume).

May 20 2020, 1:11 PM · Restricted Project

May 15 2020

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

The first patch seemed fine and pretty useful. I'm not certain that this is a particularly fun idea as far as having to redo all comments etc.

May 15 2020, 6:29 PM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

I saw the benefit initially when the proposal was made, but now seeing the consequence in practice in the tools tests at least makes me realise I'm not a fan of the change to make FileCheck error if it sees the string somewhere else in the line. In particular, GNU and LLVM are common prefixes used to distinguish checks for different output modes, but also will often appear in comments to explain the test cases. Similar comments apply to the machine names etc. Needing to add COM is unobvious, and makes the comments messier to read, I found, as soon as I started reading.

May 15 2020, 8:07 AM · Restricted Project
jroelofs updated the diff for D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

Implement review feedback

May 15 2020, 8:06 AM · Restricted Project

May 14 2020

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

This looks like a move in the right direction to me, but I'm biased.

May 14 2020, 4:53 PM · Restricted Project
jroelofs added inline comments to D77789: [llvm-dwarfdump][Stats] Clean up.
May 14 2020, 2:08 PM · Restricted Project, debug-info
jroelofs created D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.
May 14 2020, 2:08 PM · Restricted Project

Apr 25 2020

jroelofs committed rG42bf0756d426: [docs] Fix :option: links (authored by jroelofs).
[docs] Fix :option: links
Apr 25 2020, 3:24 PM