This is an archive of the discontinued LLVM Phabricator instance.

[MSAN] Never allow checking calls to __sanitizer_unaligned_{load,store}
ClosedPublic

Authored by guiand on Jul 22 2020, 11:20 AM.

Details

Summary

These functions expect the caller to always pass shadows over TLS.

Split off of https://reviews.llvm.org/D83427.

Diff Detail

Event Timeline

guiand created this revision.Jul 22 2020, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2020, 11:20 AM

This patch actually has no dependency on clang emitting noundef, so it should be good to go.

Please add a test (instrumentation only, no need for a compiler-rt test).

llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
3592

add another underscore at the end

guiand updated this revision to Diff 279966.Jul 22 2020, 4:30 PM

Added a test case

guiand marked an inline comment as done.Jul 22 2020, 4:30 PM
eugenis accepted this revision.Jul 22 2020, 4:42 PM

LGTM

This revision is now accepted and ready to land.Jul 22 2020, 4:42 PM
vitalybuka accepted this revision.Jul 22 2020, 7:24 PM
This revision was automatically updated to reflect the committed changes.