This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg] Add vectorization transform for CopyOp
ClosedPublic

Authored by ThomasRaoux on Jul 13 2020, 9:14 PM.

Details

Summary

CopyOp get vectorized to vector.transfer_read followed by vector.transfer_write.

Diff Detail

Event Timeline

ThomasRaoux created this revision.Jul 13 2020, 9:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 9:14 PM
aartbik added inline comments.Jul 14 2020, 10:44 AM
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
114

can you please add a test case for this also? (copy that falls into scalar code)
since technically that is a new path through the code now

Handle scalar case and add a test for it.

ThomasRaoux marked an inline comment as done.Jul 15 2020, 10:26 AM
ThomasRaoux added inline comments.
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
114

Thanks Aart. Added a test for it and fixed the code to make it work.

aartbik accepted this revision.Jul 16 2020, 7:31 PM
This revision is now accepted and ready to land.Jul 16 2020, 7:31 PM
This revision was automatically updated to reflect the committed changes.