[NFC][llvm-reduce] Don't `rm -rf` in tests, `rm -f` is enough

[MaskRay]

Thanks!

[dblaikie]

If the test is writing the output file anyway - is the rm necessary? (lots of tests write to output files via "-o %t" from some tool or another and most don't delete %t before doing so)

[lebedev.ri]

In D83432#2140532, @dblaikie wrote:

If the test is writing the output file anyway - is the rm necessary? (lots of tests write to output files via "-o %t" from some tool or another and most don't delete %t before doing so)

They were added by you in rL372054, so indeed the revert of that commit would be the best solution now.

[dblaikie]

In D83432#2141025, @lebedev.ri wrote:

In D83432#2140532, @dblaikie wrote:

If the test is writing the output file anyway - is the rm necessary? (lots of tests write to output files via "-o %t" from some tool or another and most don't delete %t before doing so)

They were added by you in rL372054, so indeed the revert of that commit would be the best solution now.

Thought it might've been my fault :) great - removed in 8769611f0af2598177d8d03ad6dbbe064210bfed

[lebedev.ri]

In D83432#2142154, @dblaikie wrote:

In D83432#2141025, @lebedev.ri wrote:

In D83432#2140532, @dblaikie wrote:

If the test is writing the output file anyway - is the rm necessary? (lots of tests write to output files via "-o %t" from some tool or another and most don't delete %t before doing so)

They were added by you in rL372054, so indeed the revert of that commit would be the best solution now.

Thought it might've been my fault :) great - removed in 8769611f0af2598177d8d03ad6dbbe064210bfed

Thanks, that'll do.

llvm/test/Reduce/remove-args.ll

 ; Test that llvm-reduce can remove uninteresting function arguments from function definitions as well as their calls.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-args.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
 
 ; CHECK: @interesting(i32 %interesting)
 define void @interesting(i32 %uninteresting1, i32 %interesting, i32 %uninteresting2) {
 entry:
   ; CHECK: call void @interesting(i32 0)
   call void @interesting(i32 -1, i32 0, i32 -1)
   ret void
 }

llvm/test/Reduce/remove-funcs.ll

 ; Test that llvm-reduce can remove uninteresting functions as well as
 ; their InstCalls.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-funcs.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
 
 define i32 @uninteresting1() {
 entry:
   ret i32 0
 }
 

llvm/test/Reduce/remove-global-vars.ll

 ; Test that llvm-reduce can remove uninteresting Global Variables as well as
 ; their direct uses (which in turn are replaced with 'undef').
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-global-vars.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
 
 ; CHECK: @interesting = global
 @interesting = global i32 0, align 4
 @uninteresting = global i32 1, align 4
 
 define i32 @main() {

llvm/test/Reduce/remove-metadata.ll

 ; Test that llvm-reduce can remove uninteresting metadata from an IR file.
 ; The Metadata pass erases named & unnamed metadata nodes.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-metadata.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=! %s
 
 @global = global i32 0, !dbg !0
 
 define void @main() !dbg !0 {
    ret void, !dbg !0
 }
 
 !uninteresting = !{!0}
 ; CHECK: !interesting = !{!0}
 !interesting = !{!1}
 
 !0 = !{!"uninteresting"}
 ; CHECK: !0 = !{!"interesting"}
 !1 = !{!"interesting"}

llvm/test/Reduce/remove-multiple-use-of-args-in-same-instruction.ll

 ; Test that llvm-reduce can remove uninteresting function arguments from function definitions as well as their calls.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-multiple-use-of-args-in-same-instruction.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
 
 declare void @use(i32, i32, i32)
 
 ; CHECK-LABEL: @interesting(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3
 define void @interesting(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3) {
 entry:
   ; CHECK: call void @use(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3)
   call void @use(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3)
   call void @use(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3)
   call void @use(i32 %uninteresting1, i32 %uninteresting2, i32 %uninteresting3)
   ret void
 }

llvm/test/Reduce/remove-multiple-use-of-global-vars-in-same-instruction.ll

 ; Test that llvm-reduce can remove uninteresting function arguments from function definitions as well as their calls.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-multiple-use-of-global-vars-in-same-instruction.py %s -o %t
 ; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s
 
 ; CHECK: @uninteresting1 = global
 ; CHECK: @uninteresting2 = global
 ; CHECK: @uninteresting3 = global
 @uninteresting1 = global i32 0, align 4
 @uninteresting2 = global i32 0, align 4

llvm/test/Reduce/remove-operand-bundles.ll

 ; Test that llvm-reduce can remove uninteresting operand bundles from calls.
 ;
-; RUN: rm -rf %t
+; RUN: rm -f %t
 ; RUN: llvm-reduce --test FileCheck --test-arg --check-prefixes=CHECK-ALL,CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
 ; RUN: cat %t | FileCheck --check-prefixes=CHECK-ALL,CHECK-FINAL %s
 
 ; CHECK-ALL: declare void @f1()
 ; CHECK-ALL: declare void @f2()
 ; CHECK-ALL: declare void @f3()
 declare void @f1()
 declare void @f2()