This is an archive of the discontinued LLVM Phabricator instance.

[Coroutines] Fix test breakage in D82928
ClosedPublic

Authored by lxfind on Jul 1 2020, 11:09 AM.

Details

Summary

The test file in D82928 generated temp files within the test directory, causing test failures. Fix it.

Diff Detail

Event Timeline

lxfind created this revision.Jul 1 2020, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2020, 11:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
modocache accepted this revision.Jul 1 2020, 11:16 AM

Thanks for the fix!

This revision is now accepted and ready to land.Jul 1 2020, 11:16 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Jul 1 2020, 1:57 PM

That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change.

lxfind added a comment.Jul 1 2020, 2:08 PM

That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change.

It's in https://reviews.llvm.org/D82992 if you could help accept it. Thanks!