Page MenuHomePhabricator

[mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS.
ClosedPublic

Authored by dfki-mako on Jun 15 2020, 5:08 AM.

Details

Summary

This PR fixes several build issues using GCC and shared libraries that have been introduced by the most recent BufferPlacement updates.

Diff Detail

Event Timeline

dfki-mako created this revision.Jun 15 2020, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2020, 5:08 AM
dfki-mako edited the summary of this revision. (Show Details)Jun 15 2020, 5:09 AM
dfki-mako added a reviewer: pifon2a.
dfki-mako updated this revision to Diff 270725.Jun 15 2020, 5:18 AM

Added an additional comment and change to code to use the implicit OperandRange conversion operator.

pifon2a accepted this revision.Jun 15 2020, 5:30 AM

Accepted, but after
OperandRange range = successorOperand;

Value sourceValue = range[0];

is rewritten.

mlir/lib/Transforms/BufferPlacement.cpp
335

i bet this can be written simpler without converting to OperandRange.

This revision is now accepted and ready to land.Jun 15 2020, 5:30 AM
Harbormaster completed remote builds in B60289: Diff 270725.
dfki-mako marked 2 inline comments as done.Jun 15 2020, 6:03 AM
dfki-mako added inline comments.
mlir/lib/Transforms/BufferPlacement.cpp
335

As discussed offline, a possible alternative would be OperandRange{successorOperand}.begin.

dfki-mako updated this revision to Diff 270734.Jun 15 2020, 6:24 AM
dfki-mako marked an inline comment as done.

Refactored access to getSuccessorOperands to distinguish between read-only and write-enabled accesses.

This revision was automatically updated to reflect the committed changes.