Page MenuHomePhabricator

Add OpenBSD support in lib/tsan/go/buildgo.sh
ClosedPublic

Authored by qbit on May 23 2020, 7:06 AM.

Details

Summary

Enable OpenBSD support in buildgo.sh.

With the race_debug_openbsd_amd64.syso file created via this diff, Go's race detector is able to detect a race in the example code from this link: https://golang.org/doc/articles/race_detector.html

Diff Detail

Event Timeline

qbit created this revision.May 23 2020, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2020, 7:06 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.May 26 2020, 9:49 AM
krytarowski added a subscriber: dvyukov.

It looks fine to me, but I will defer it to @dvyukov

Please use clang-format.

qbit added a comment.May 28 2020, 1:51 PM

It looks fine to me, but I will defer it to @dvyukov

Please use clang-format.

I wasn't sure about using clang-format, it changes a lot of stuff that isn't part of this initial diff - is that OK?

@qbit, if you use git clang-format, it should format only the code around your diff (https://llvm.org/docs/Contributing.html#how-to-submit-a-patch). On OpenBSD, pkg_add llvm installs clang-format.

qbit updated this revision to Diff 267088.May 28 2020, 5:03 PM

ran clang-format - thanks for the pointer!

dvyukov accepted this revision.May 28 2020, 10:47 PM
qbit added a comment.Jun 8 2020, 7:17 AM

Is anything else needed from me?