This is an archive of the discontinued LLVM Phabricator instance.

Updating GettingStarted documentation to reference CMake as the preferred way to build LLVM.
ClosedPublic

Authored by beanz on Mar 3 2015, 2:50 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 21149.Mar 3 2015, 2:50 PM
beanz retitled this revision from to Updating GettingStarted documentation to reference CMake as the preferred way to build LLVM..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: chandlerc, samsonov, echristo.
beanz added a subscriber: Unknown Object (MLST).
samsonov added inline comments.Mar 3 2015, 3:12 PM
docs/GettingStarted.rst
715 ↗(On Diff #21149)

This variable is already mentioned above.

721 ↗(On Diff #21149)

Probably, we should specifiy that this is a semicolon-separated list of strings.

722 ↗(On Diff #21149)

s/equivolent/equivalent

730 ↗(On Diff #21149)

s/nad/and

735 ↗(On Diff #21149)

s/nad/and

876 ↗(On Diff #21149)

I feel like example will be better.

$ cd llvm_build_dir
$ find lib/Support/ -name APFloat*
lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o
chandlerc edited edge metadata.Mar 3 2015, 3:22 PM

I'm happy for Alexey and others to review, I just wanted to say....

WOOOOOT!

beanz updated this revision to Diff 21161.Mar 3 2015, 6:01 PM
beanz edited edge metadata.

Updates based on Alexey's feedback.

mehdi_amini added inline comments.
docs/GettingStarted.rst
718 ↗(On Diff #21161)

s/TARGEST/TARGET/

729 ↗(On Diff #21161)

s/soruce/source/

734 ↗(On Diff #21161)

s/soruce/source/

876 ↗(On Diff #21161)

s/cooresponding/corresponding/

beanz updated this revision to Diff 21162.Mar 3 2015, 6:17 PM

Obviously I can't spell or type (spell check module installed).

beanz updated this revision to Diff 21225.Mar 4 2015, 2:09 PM
  • Adding documentation for LLVM_BUILD_LLVM_DYLIB
  • Fixing a doc build issue
beanz updated this revision to Diff 21632.Mar 10 2015, 2:07 PM

Addind documentation for LLVM_OPTIMIZED_TABLEGEN, which was just landed in r231842.

samsonov added inline comments.Mar 11 2015, 5:25 PM
docs/BuildingLLVMWithAutotools.rst
2 ↗(On Diff #21632)

Update the page name?

298 ↗(On Diff #21632)

Please fix

docs/GettingStarted.rst
73 ↗(On Diff #21632)

make-compatible

76 ↗(On Diff #21632)

Probably you should add "." or ";" at the end of bullets.

88 ↗(On Diff #21632)

FTR existing LLVM CMake page uses ON/OFF instead of Yes/No

161 ↗(On Diff #21632)

See above. Specify -DBUILD_SHARED_LIBS=ON?

698 ↗(On Diff #21632)

"are passed to CMake"?

724 ↗(On Diff #21632)

The order of sentences is weird. LLVM_ALL_TARGETS refers to all, and sentence about list format should be either at the very beginning, or at the end.

725 ↗(On Diff #21632)

s/semi-colon/semicolon

729 ↗(On Diff #21632)

I'd shorten it to "Build doxygen-based documentation from the source code. ..."

734 ↗(On Diff #21632)

Ditto - I'd shorten it to "Build sphinx-based documentation from the source code. ..."

744 ↗(On Diff #21632)

Do you really need to specify all the list items here? I'm pretty sure it will soon get out of date.

837 ↗(On Diff #21632)

I think you need a comma before "this"

838 ↗(On Diff #21632)

... generate a directory `OBJ_ROOT/docs/html` with HTML documentation.

851 ↗(On Diff #21632)

"a Mac" -> "Mac OS X" ?

852 ↗(On Diff #21632)

why not just "latest Xcode"?

beanz updated this revision to Diff 21872.Mar 12 2015, 1:31 PM

Fixes based on feedback from samsonov.

samsonov accepted this revision.Mar 12 2015, 5:40 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 12 2015, 5:40 PM
echristo edited edge metadata.Mar 12 2015, 5:46 PM

No need to wait on me here, you've gotten other approvals.

Thanks!

-eric

emaste added a subscriber: emaste.Mar 12 2015, 5:51 PM
This revision was automatically updated to reflect the committed changes.