Page MenuHomePhabricator

[libc++] Improve the detection of whether the blocks runtime is available
ClosedPublic

Authored by ldionne on Apr 23 2020, 1:50 PM.

Details

Summary

The runtime for Blocks may not be available even though the Blocks
language extension _is_ available. Instead of potentially failing,
this commit is much more conservative and assumes the runtime for
Blocks is only provided on Apple platforms.

Diff Detail

Event Timeline

ldionne created this revision.Apr 23 2020, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2020, 1:50 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
compnerd accepted this revision.Apr 23 2020, 2:23 PM
compnerd added a subscriber: compnerd.

We should be able to check for this in CMake, but that can be improved in the future. (Note that the blocks runtime is in compiler-rt, so we should actually be able to build and use that on all targets)

ldionne accepted this revision as: Restricted Project.Apr 24 2020, 4:17 AM
This revision is now accepted and ready to land.Apr 24 2020, 4:17 AM
This revision was automatically updated to reflect the committed changes.