Use checks_on_target for libunwind and libc++abi tests on cross-builders

[broadwaylamb]

Summary

This allows specifying lit arguments on a per-target basis.

Right now the libc++ check displays the number of passes/failures/unsupported tests, while libunwind and libc++abi checks don't:

We need to pass the -v -vv flags so that the output contains the status of each test. We can't do it through CMake using the LLVM_LIT_FLAGS variable (like we do it now), because the flags specified in that variable are only propagated to llvm, clang and lld tests, but not the runtimes tests (and this is very unlikely to change), so we specify them by invoking llvm-lit directly.

[andreil99]

Thanks, Sergej!

[broadwaylamb]

Committed as 5d7dae912c7ac81b6a6ca9827383bd68d1699dbe.

buildbot/osuosl/master/config/builders.py

return [
          'mergeRequests': True,
          'factory': XToolchainBuilder.getCmakeWithMSVCBuildFactory(
                       vs="autodetect",
                       clean=True,
                       checks=[
                         "check-llvm",
                         "check-clang",
                         "check-lld",
-                        "check-unwind",
-                        "check-cxxabi",
                       ],
                       checks_on_target = [
+                        ("libunwind",
+                         ["python", "bin/llvm-lit.py",
+                          "-v", "-vv", "--threads=32",
+                          "runtimes/runtimes-bins/libunwind/test"]),
+                        ("libc++abi",
+                         ["python", "bin/llvm-lit.py",
+                          "-v", "-vv", "--threads=32",
+                          "runtimes/runtimes-bins/libcxxabi/test"]),
                         ("libc++",
                          ['python', 'bin/llvm-lit.py',
                           '-v', '-vv', '--threads=32',
                           'runtimes/runtimes-bins/libcxx/test',
                          ])
                       ],
                       extra_configure_args=[
                         "-DDEFAULT_SYSROOT=C:/buildbot/.arm-ubuntu",
return [
          'mergeRequests': True,
          'factory': XToolchainBuilder.getCmakeWithMSVCBuildFactory(
                       vs="autodetect",
                       clean=True,
                       checks=[
                         "check-llvm",
                         "check-clang",
                         "check-lld",
-                        "check-unwind",
-                        "check-cxxabi",
+                      ],
+                      checks_on_target = [
+                        ("libunwind",
+                         ["python", "bin/llvm-lit.py",
+                          "-v", "-vv", "--threads=32",
+                          "runtimes/runtimes-bins/libunwind/test"]),
+                        ("libc++abi",
+                         ["python", "bin/llvm-lit.py",
+                          "-v", "-vv", "--threads=32",
+                          "runtimes/runtimes-bins/libcxxabi/test"]),
                       ],
                       extra_configure_args=[
                         "-DLLVM_TARGETS_TO_BUILD=AArch64",
                         "-DCMAKE_C_COMPILER_TARGET=aarch64-linux-gnu",
                         "-DDEFAULT_SYSROOT=C:/buildbot/.aarch64-ubuntu",
                         "-DLLVM_LIT_ARGS=-v -vv --threads=32",
                         WithProperties("%(remote_test_host:+-DREMOTE_TEST_HOST=)s%(remote_test_host:-)s"),
                         WithProperties("%(remote_test_user:+-DREMOTE_TEST_USER=)s%(remote_test_user:-)s"),