Page MenuHomePhabricator

aorlov (Alex Orlov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2019, 1:07 PM (71 w, 6 d)

Recent Activity

Sat, Feb 27

aorlov added inline comments to D96883: Add support for JSON output style to llvm-symbolizer.
Sat, Feb 27, 12:08 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.

Used json::OStream directly to omit null and default values.
Added error handling and the error code/message printout in JSON.

Sat, Feb 27, 12:03 PM · Restricted Project

Thu, Feb 25

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Thanks for the comments, James!
I will address them later.
With all these issues this draft is still provide quite good idea of the level of the changes if we will decide JSON.
As you mentioned, I’d like us to choose before making further changes.

Thu, Feb 25, 11:54 AM · Restricted Project

Wed, Feb 24

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Ping

Wed, Feb 24, 9:12 AM · Restricted Project

Tue, Feb 23

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Just one more ping!

Tue, Feb 23, 9:55 AM · Restricted Project, Restricted Project

Mon, Feb 22

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

This patch is a continuation of the discussion https://reviews.llvm.org/D96289

Mon, Feb 22, 6:59 AM · Restricted Project

Thu, Feb 18

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Thu, Feb 18, 2:46 AM · Restricted Project

Wed, Feb 17

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Wed, Feb 17, 12:12 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Wed, Feb 17, 11:45 AM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Wed, Feb 17, 11:29 AM · Restricted Project
aorlov added a comment to D96289: Add support for YAML output style to llvm-symbolizer.

Here is the patch for supporting JSON - https://reviews.llvm.org/D96883
Now we can look at the changes side by side and decide which one is the way to go.

Wed, Feb 17, 10:59 AM · Restricted Project
aorlov requested review of D96883: Add support for JSON output style to llvm-symbolizer.
Wed, Feb 17, 10:58 AM · Restricted Project

Tue, Feb 16

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Ping! Please, don't pass by this patch. I need your competent evaluation to load it!

Tue, Feb 16, 10:01 AM · Restricted Project, Restricted Project

Sun, Feb 14

aorlov added a comment to D96289: Add support for YAML output style to llvm-symbolizer.

The line based output can be straightforwardly parsed

And this is fine. I do not see how this patch could prevent your users from parsing the line based output. It is quite the opposite, they are even better protected, as any change in YAML output style would not change what they depend on.

Sun, Feb 14, 9:42 PM · Restricted Project
aorlov updated the diff for D96289: Add support for YAML output style to llvm-symbolizer.
Sun, Feb 14, 9:38 PM · Restricted Project
aorlov added inline comments to D96289: Add support for YAML output style to llvm-symbolizer.
Sun, Feb 14, 9:32 PM · Restricted Project

Wed, Feb 10

aorlov updated the diff for D96289: Add support for YAML output style to llvm-symbolizer.

I have updated the patch. It

  • addresses the review comments,
  • adds more tests for YAML output style similar to the existing tests we have for other output styles. In particular output-style-yaml-data.test is based on untag-addresses.test, output-style-yaml-frame.test is based on frame-types.s.
  • updates llvm-symbolizer documentation.
Wed, Feb 10, 12:35 PM · Restricted Project

Tue, Feb 9

aorlov added a comment to D96289: Add support for YAML output style to llvm-symbolizer.

Thanks for the comments, James! I’ll post the updated patch shortly.

Tue, Feb 9, 12:39 PM · Restricted Project

Mon, Feb 8

aorlov requested review of D96289: Add support for YAML output style to llvm-symbolizer.
Mon, Feb 8, 1:20 PM · Restricted Project
aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Hi, community. I kindly ask you to review this patch.

Mon, Feb 8, 6:26 AM · Restricted Project, Restricted Project

Jan 28 2021

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

One more ping. Please, pay attention to this patch.

Jan 28 2021, 11:13 AM · Restricted Project, Restricted Project

Jan 22 2021

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Please, look at my solution. Is it worth to be accepted?

Jan 22 2021, 10:24 AM · Restricted Project, Restricted Project

Jan 18 2021

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Just a ping.

Jan 18 2021, 8:18 AM · Restricted Project, Restricted Project

Jan 11 2021

aorlov added inline comments to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Jan 11 2021, 9:30 AM · Restricted Project, Restricted Project
aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

@Quuxplusone
Thank you for your comments. I updated the patch according to your suggestions.
Does anyone else from the review list want to waste some time to look at this patch? I would appreciate this.

Jan 11 2021, 9:29 AM · Restricted Project, Restricted Project

Dec 23 2020

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Please, somebody look at this patch.

Dec 23 2020, 9:24 AM · Restricted Project, Restricted Project

Dec 22 2020

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

One more ping!

Dec 22 2020, 10:00 AM · Restricted Project, Restricted Project

Dec 21 2020

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Hi, community. I kindly ask you to review this patch.

Dec 21 2020, 8:53 AM · Restricted Project, Restricted Project

Dec 13 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Updated. Disabled function parameters access checking in function templates.
Hi, @broadwaylamb, @rsmith, @saar.raz, @doug.gregor, @mibintc, @hokein. Could you please look at this patch?

Dec 13 2020, 12:55 AM · Restricted Project, Restricted Project

Dec 8 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Simplify the patch.
@Quuxplusone,
Actually you've pushed me to some thinking of what more syntactic cases it could be. And I came to that we can get rid of this hack and simplify the patch pretty much. Hope, this fix will be more admissible.

Dec 8 2020, 9:04 PM · Restricted Project, Restricted Project
aorlov added inline comments to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Dec 8 2020, 8:29 AM · Restricted Project, Restricted Project

Dec 7 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Added test cases for explicit instantiations.

@Quuxplusone,
In particular, I'm very interested to know if P0692 is intended to have any effect on the legality of https://godbolt.org/z/fqfo8q

I've checked your particular case. It hasn't been affected by this patch. It works as before. I also added it to func.spec.cpp.

Dec 7 2020, 10:59 AM · Restricted Project, Restricted Project

Dec 4 2020

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

The subject line says "access checking on specializations and instantiations," but I don't see any tests for explicit instantiations here — just specializations. In particular, I'm very interested to know if P0692 is intended to have any effect on the legality of https://godbolt.org/z/fqfo8q

Thank you for your important suggestion! I'll add test cases for explicit instantiations.

It would also be good to document which of the two proposed wordings from http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0692r1.html is actually being adopted in this patch.

AFAIK there are four options in the paper. This patch covers option *A*. I'll mention this in the summary.
Both wordings relate to option A only, thus both wordings have been adopted.

Dec 4 2020, 11:28 PM · Restricted Project, Restricted Project
aorlov updated the summary of D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Dec 4 2020, 11:24 PM · Restricted Project, Restricted Project

Dec 3 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Fixed typos. Made minor changes in test cases.

Dec 3 2020, 7:32 AM · Restricted Project, Restricted Project

Nov 30 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Improved solution. Added more tests.

Nov 30 2020, 8:07 AM · Restricted Project, Restricted Project

Nov 24 2020

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Nov 24 2020, 3:14 PM · Restricted Project, Restricted Project
aorlov requested review of D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Nov 24 2020, 5:59 AM · Restricted Project, Restricted Project

Nov 3 2020

aorlov committed rZORG4188d05872df: Added compiler-rt tests to run on ARM target. (authored by aorlov).
Added compiler-rt tests to run on ARM target.
Nov 3 2020, 2:05 PM
aorlov updated the diff for D90491: Added compiler-rt tests to run on ARM target..
Nov 3 2020, 1:58 PM · Restricted Project

Oct 31 2020

aorlov committed rZORG477485f2fbf7: Added compiler-rt tests to run on ARM target. (authored by aorlov).
Added compiler-rt tests to run on ARM target.
Oct 31 2020, 7:21 AM
aorlov closed D90491: Added compiler-rt tests to run on ARM target..
Oct 31 2020, 7:21 AM · Restricted Project

Oct 30 2020

aorlov requested review of D90491: Added compiler-rt tests to run on ARM target..
Oct 30 2020, 12:44 PM · Restricted Project

Oct 29 2020

aorlov committed rG8aaafa06b2af: Added remotely ran compiler-rt tests. (authored by aorlov).
Added remotely ran compiler-rt tests.
Oct 29 2020, 1:11 PM
aorlov closed D90054: Added remotely ran compiler-rt tests..
Oct 29 2020, 1:11 PM · Restricted Project, Restricted Project

Oct 26 2020

aorlov updated the diff for D90054: Added remotely ran compiler-rt tests..

Disable compiler-rt crt tests for cross ARM builders since the tests are broken.

Oct 26 2020, 9:52 AM · Restricted Project, Restricted Project

Oct 23 2020

aorlov committed rG9df832d1c3aa: These compiler-rt tests should be UNSUPPORTED instead of XFAIL. (authored by aorlov).
These compiler-rt tests should be UNSUPPORTED instead of XFAIL.
Oct 23 2020, 9:57 AM
aorlov closed D89840: These compiler-rt tests should be UNSUPPORTED instead of XFAIL..
Oct 23 2020, 9:57 AM · Restricted Project, Restricted Project
aorlov committed rGdc98923a8c09: Added utility to launch tests on a target remotely. (authored by aorlov).
Added utility to launch tests on a target remotely.
Oct 23 2020, 9:53 AM
aorlov closed D89349: Added utility to launch tests on a target remotely..
Oct 23 2020, 9:53 AM · Restricted Project, Restricted Project
aorlov added a comment to D89349: Added utility to launch tests on a target remotely..

Since we use this utility in multiple projects now, it is better to have it outside the libc++ project, so we would not introduce unneeded inter-project dependencies just because of shared tools.

Oct 23 2020, 9:23 AM · Restricted Project, Restricted Project
aorlov requested review of D90054: Added remotely ran compiler-rt tests..
Oct 23 2020, 9:07 AM · Restricted Project, Restricted Project

Oct 22 2020

aorlov updated the diff for D89840: These compiler-rt tests should be UNSUPPORTED instead of XFAIL..
Oct 22 2020, 12:56 PM · Restricted Project, Restricted Project

Oct 20 2020

aorlov requested review of D89840: These compiler-rt tests should be UNSUPPORTED instead of XFAIL..
Oct 20 2020, 5:37 PM · Restricted Project, Restricted Project

Oct 16 2020

aorlov updated the diff for D89349: Added utility to launch tests on a target remotely..

Changed the parameter --test-executable to --exec-pattern;
Used regex instead of fnmatch;
Fixed bugs that appeared in case of complicated command line.
Note I used the following command line for tests:
python remote-exec.py --host user@host --execdir llvm-project/build/runtimes/runtimes-bins/libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/Output/cin.sh.cpp.dir --codesign_identity "" --env "" -- echo "123" "|" llvm-project/build/runtimes/runtimes-bins/libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/Output/cin.sh.cpp.dir/t.tmp.exe ">" t.tmp.out "&&" grep -e "The number is 123!" t.tmp.out

Oct 16 2020, 2:04 PM · Restricted Project, Restricted Project

Oct 13 2020

aorlov added a comment to D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py.

I have created a review https://reviews.llvm.org/D89349 for llvm/utils/remote-exec.py as discussed here.

Oct 13 2020, 4:39 PM · Restricted Project
aorlov requested review of D89349: Added utility to launch tests on a target remotely..
Oct 13 2020, 4:32 PM · Restricted Project, Restricted Project

Apr 19 2020

aorlov closed D78472: Change llvm-clang-win-x-armv7l to run libc++ tests on a remote target..
Apr 19 2020, 11:25 PM · Restricted Project
aorlov committed rZORGb139e230f4fd: Change llvm-clang-win-x-armv7l to run libc++ tests on a remote target. (authored by aorlov).
Change llvm-clang-win-x-armv7l to run libc++ tests on a remote target.
Apr 19 2020, 11:25 PM
aorlov created D78472: Change llvm-clang-win-x-armv7l to run libc++ tests on a remote target..
Apr 19 2020, 10:57 PM · Restricted Project
aorlov committed rZORG60635b4fcbdd: Added ability to XToolchainBuilder have extra steps to run checks on a remote… (authored by aorlov).
Added ability to XToolchainBuilder have extra steps to run checks on a remote…
Apr 19 2020, 10:25 PM
aorlov closed D78469: Added ability to XToolchainBuilder have extra steps to run checks on a remote target..
Apr 19 2020, 10:25 PM · Restricted Project
aorlov created D78469: Added ability to XToolchainBuilder have extra steps to run checks on a remote target..
Apr 19 2020, 9:21 PM · Restricted Project

Mar 5 2020

aorlov closed D68955: Change SphinxDocsBuilder to use UnifiedTreeBuilder.
Mar 5 2020, 8:11 PM · Restricted Project, Restricted Project

Mar 3 2020

aorlov closed D69154: Added LLVMPoller to work with github..
Mar 3 2020, 10:21 PM · Restricted Project, Restricted Project

Jan 9 2020

aorlov accepted D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file.
Jan 9 2020, 8:34 PM · Restricted Project

Nov 11 2019

aorlov closed D70098: Added builders to build cross from Windows to ARMv7l and AArch64 LLVM toolchains..

Committed as 938392e5a2575dcf6a04132f172b091a6a7e05fe.

Nov 11 2019, 4:36 PM · Restricted Project, Restricted Project, Restricted Project
aorlov committed rZORG938392e5a257: Added builders to build cross from Windows to ARMv7l and AArch64 LLVM… (authored by aorlov).
Added builders to build cross from Windows to ARMv7l and AArch64 LLVM…
Nov 11 2019, 4:27 PM
aorlov committed rZORGfa464cc4ebc9: Upstream ninja does not support yet a format string from arguments. (authored by aorlov).
Upstream ninja does not support yet a format string from arguments.
Nov 11 2019, 2:11 PM
aorlov created D70098: Added builders to build cross from Windows to ARMv7l and AArch64 LLVM toolchains..
Nov 11 2019, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
aorlov committed rZORG12af0349225a: Added XToolchainBuilder to build cross toolchains. (authored by aorlov).
Added XToolchainBuilder to build cross toolchains.
Nov 11 2019, 12:40 PM
aorlov closed D70039: Added XToolchainBuilder to build cross toolchains..
Nov 11 2019, 12:40 PM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2019

aorlov created D70039: Added XToolchainBuilder to build cross toolchains..
Nov 8 2019, 8:37 PM · Restricted Project, Restricted Project, Restricted Project

Nov 1 2019

aorlov accepted D69703: Refactored PollyBuilder.getPollyBuildFactory to support github..
Nov 1 2019, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2019

aorlov created D69154: Added LLVMPoller to work with github..
Oct 17 2019, 7:25 PM · Restricted Project, Restricted Project

Oct 14 2019

aorlov created D68955: Change SphinxDocsBuilder to use UnifiedTreeBuilder.
Oct 14 2019, 2:33 PM · Restricted Project, Restricted Project