Page MenuHomePhabricator

[SYCL] Enable Open CL types required for implementing the SYCL headers.
Needs ReviewPublic

Authored by erichkeane on Apr 1 2020, 7:53 AM.

Details

Summary

This patch implements a few of the OpenCL types for SYCL, however
doesn't bother handling semantic analysis as these are not intended to
be used anywhere but in the SYCL implementation.

Signed-off-by: Erich Keane <erich.keane@intel.com>

Diff Detail

Event Timeline

erichkeane created this revision.Apr 1 2020, 7:53 AM

@bader : Is this what you meant? Feel free to add any reviewers you want for this. Note it is still dependent on D71016.

bader added a comment.Apr 2 2020, 8:46 AM

@bader : Is this what you meant? Feel free to add any reviewers you want for this. Note it is still dependent on D71016.

Thanks! I'll add more reviewers.

keryell added inline comments.Apr 2 2020, 7:05 PM
clang/lib/Sema/SemaSYCL.cpp
357

Curious. What is the purpose?

426

Can it be const?
Can the data structure be partially shared with the one from the previous function?

erichkeane marked 2 inline comments as done.Apr 3 2020, 6:16 AM
erichkeane added inline comments.
clang/lib/Sema/SemaSYCL.cpp
357

Ah, this is a fix that should actually be in the parent commit: https://reviews.llvm.org/D71016

Since that one was put up for review, the implicit conversion here was removed. I likely forgot to 'git' this out of this and into the cherry pick of the parent revision in my repo. I'll 'remove' it from this patch.

426

It can absolutely be const (change made in the incoming patch), but I don't see a way to combine the two without making matchQualifiedTypeName awkward.

erichkeane updated this revision to Diff 254768.Apr 3 2020, 6:17 AM

Seems reasonable from the OpenCL side.