Page MenuHomePhabricator

keryell (Ronan Keryell)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 10 2013, 11:30 AM (398 w, 4 d)

Recent Activity

Mon, Nov 2

keryell added inline comments to D78807: Fix gendered documentation.
Mon, Nov 2, 5:58 PM · Restricted Project, Restricted Project

Oct 15 2020

keryell retitled D74130: [clang] fix consteval call in default arguments from [clang] fix consteval call in default arguements to [clang] fix consteval call in default arguments.
Oct 15 2020, 2:54 PM · Restricted Project
keryell added inline comments to D74130: [clang] fix consteval call in default arguments.
Oct 15 2020, 2:54 PM · Restricted Project

Oct 12 2020

keryell added a reviewer for D76620: [SYCL] Implement __builtin_unique_stable_name.: Tyker.
Oct 12 2020, 7:17 PM · Restricted Project
keryell added inline comments to D88645: [Annotation] Allows annotation to carry some additional constant arguments..
Oct 12 2020, 7:13 PM · Restricted Project, Restricted Project
keryell added a reviewer for D76620: [SYCL] Implement __builtin_unique_stable_name.: Ralender.

Enabling this feature only with SYCL seems like an easy and quick mitigation, as SYCL compilers downstream can easily update their runtime to the new builtin name.
Otherwise, just removing a feature used for almost 6 months will cause some kind of forking pain...
Anyway, improving the feature and implementation at the same time with an RFC for a wider usage looks like a great idea.

Oct 12 2020, 6:47 PM · Restricted Project

Oct 10 2020

keryell added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

@erichkeane @alexandre.isoard @Naghasan: any feedback in the context of SYCL & HLS C++ about this feature extension?

Oct 10 2020, 2:44 PM · Restricted Project, Restricted Project

Oct 9 2020

keryell added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

Great feature for all the weird pieces of hardware all around the world! :-)

Oct 9 2020, 2:38 PM · Restricted Project, Restricted Project

Oct 2 2020

keryell added reviewers for D88645: [Annotation] Allows annotation to carry some additional constant arguments.: erichkeane, alexandre.isoard, Naghasan.
Oct 2 2020, 3:32 PM · Restricted Project, Restricted Project

Sep 28 2020

keryell added a comment to D87282: [SYCL] Assume SYCL device functions are convergent.

Be lazy

Sep 28 2020, 9:23 AM · Restricted Project

Jul 14 2020

keryell added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

The idea of this _ExtInt is to have some extensions.
Since it is an extension, why preventing its use?
For example if I want my 18 bit FPGA BRAM to be accessed atomically?
Or is there an assumption that atomic access can be enabled back with some other mode, such as SYCL or HLS C++?

Jul 14 2020, 11:56 AM · Restricted Project

Jul 6 2020

keryell added a reviewer for D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives.: Tyker.

Adding Tyker (Gauthier Harnisch) because of SYCL similarity

Jul 6 2020, 9:33 AM · Restricted Project, Restricted Project

Apr 2 2020

keryell added inline comments to D77220: [SYCL] Enable Open CL types required for implementing the SYCL headers..
Apr 2 2020, 7:32 PM

Feb 28 2020

keryell added a comment to D75285: Mark restrict pointer or reference to const as invariant.

I don't think that 'restrict' is a good match for this behavior. For c++, the alias_set proposal (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4150.pdf) would be a better match.

Feb 28 2020, 1:06 PM

Feb 27 2020

keryell added inline comments to D73967: Implement _ExtInt as an extended int type specifier..
Feb 27 2020, 10:44 AM · Restricted Project

Feb 18 2020

keryell added inline comments to D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version.
Feb 18 2020, 11:39 AM · Restricted Project

Feb 6 2020

keryell added a comment to D73967: Implement _ExtInt as an extended int type specifier..

At the moment it doesn't work because of parsing. I'm unaware of there is a deeper limitation, but I'll look at it. I was unaware that we allow integral types for _Complex, I'd looked it up on cppreference and only saw the FP types so I was basically just confused as to what your intent was.

Feb 6 2020, 12:24 PM · Restricted Project

Jan 31 2020

keryell requested changes to D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse.
Jan 31 2020, 7:08 PM · Restricted Project

Dec 10 2019

keryell added inline comments to D71016: [SYCL] Implement OpenCL kernel function generation.
Dec 10 2019, 6:09 PM · Restricted Project

Jul 9 2019

keryell added a comment to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Good improvement!

Jul 9 2019, 1:21 PM · Restricted Project

Jun 19 2019

keryell added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Jun 19 2019, 6:58 PM · Restricted Project

May 30 2019

vladimirlaz <vladimir.lazarev@intel.com> committed rG4e38c234e305: [SYCL] Fix some typos (authored by keryell).
[SYCL] Fix some typos
May 30 2019, 7:57 AM

May 7 2019

keryell added a comment to D61506: [OpenCL] Switch to C++17.

Per the OpenCL C++ 1.0 specification, section 2:

The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 N 3690 language specification (a.k.a. C++14 specification).

I think it would be reasonable to permit changing the base C++ standard in OpenCL C++ mode

May 7 2019, 12:33 PM · Restricted Project

May 3 2019

keryell added inline comments to D61506: [OpenCL] Switch to C++17.
May 3 2019, 2:34 PM · Restricted Project

May 1 2019

keryell added a comment to D61304: [OpenCL][PR41609] Deduce static data members to __global addr space.

Presumably a similar rule would apply to thread-locals if you supported them.

We don't support them in OpenCL.

May 1 2019, 7:37 PM · Restricted Project

Apr 18 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 18 2019, 9:03 PM · Restricted Project

Apr 17 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 17 2019, 8:30 AM · Restricted Project
keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

It would be better to rename clang/test/SemaSYCL/device-attrubutes.cpp to clang/test/SemaSYCL/device-attributes.cpp

Apr 17 2019, 8:12 AM · Restricted Project

Apr 15 2019

keryell accepted D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 15 2019, 5:57 PM · Restricted Project

Apr 9 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

While we are thinking about recycling some attributes across languages, we have to think about the fact that real applications are often made from various languages, such as SYCL + OpenMP 5 or whatever.
It would be nice not to forbid such a combination inside the same TU by design.

Apr 9 2019, 3:35 PM · Restricted Project

Mar 23 2019

keryell added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

Updated test to use root namespace (commented by Ronan).

Mar 23 2019, 11:51 AM · Restricted Project

Mar 20 2019

keryell added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

I was a little bit worried about

Mar 20 2019, 11:47 AM · Restricted Project

Feb 15 2019

keryell added a comment to D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

LGTM.

Feb 15 2019, 9:01 AM

Feb 5 2019

keryell accepted D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

That looks good. Thanks.

Feb 5 2019, 11:03 AM · Restricted Project

Nov 2 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 2 2018, 12:58 PM · Restricted Project

Nov 1 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 1 2018, 3:27 PM · Restricted Project
keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 1 2018, 10:55 AM · Restricted Project

Oct 30 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

I don't suppose there's any chance you can just tell Khronos to fix their stuff. It's a little funny to be more conservative about keywords in C++ when the C++ committee is actually much more aggressive about adding keywords in the non-reserved space than C is.

Oct 30 2018, 7:43 PM · Restricted Project
keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

We could submit to the standard an OpenCL C++ extension to accept the OpenCL C syntax...

Oct 30 2018, 7:31 PM · Restricted Project

Nov 19 2016

keryell added a comment to D26735: [OpenCL] Disable && (address of label) GNU extension for OpenCL.

+1
Please do not remove anything, since it may be useful in some contexts.

Nov 19 2016, 8:23 AM

Jan 12 2016

keryell added inline comments to D15914: [OpenCL] Pipe builtin functions.
Jan 12 2016, 11:52 AM

Feb 15 2015

keryell added a comment to D7647: OpenCL: Accept -cl-strict-aliasing.

Typo

Feb 15 2015, 9:57 AM