Utility to perform CallOp Dialect conversion, specifically handling cases where
an argument type has changed and the corresponding CallOp needs to be updated.
Details
- Reviewers
rriddle - Commits
- rGcd1212deffbe: [mlir] Introduced CallOp Dialect Conversion
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks good, just have a question about the location.
mlir/include/mlir/Dialect/StandardOps/Transforms/DialectConversion.h | ||
---|---|---|
1 | Would this make more sense in the Conversion directory? Say mlir/Conversion/StandardToStandard? | |
9 | This seems like it should be updated, likely should just mention that it contains patterns for lowering within standard dialect. | |
17 | I think we can trim all of these and just use forward declarations. | |
29 | operand and result types? | |
mlir/lib/Dialect/StandardOps/Transforms/DialectConversion.cpp | ||
1 | Missing a file header here. | |
6 | nit: prefer using namespace mlir in .cpp files |
mlir/include/mlir/Dialect/StandardOps/Transforms/DialectConversion.h | ||
---|---|---|
1 | Works for me. |
Would this make more sense in the Conversion directory? Say mlir/Conversion/StandardToStandard?