Page MenuHomePhabricator

[MLIR] Fix for MSVC
ClosedPublic

Authored by flaub on Mar 3 2020, 4:34 PM.

Details

Summary

Fix for VS2017 bug.

Apparently there is a bug in VS2017 concerning compile-time constant
expressions.
https://developercommunityapi.westus.cloudapp.azure.com/content/problem/110435/not-compile-time-constant-expression.html

This change works with any C++11 compiler (including VS2017) and is a little bit
easier to read.

Diff Detail

Event Timeline

flaub created this revision.Mar 3 2020, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 4:34 PM
flaub retitled this revision from Fix for MSVC to [MLIR] Fix for MSVC.Mar 3 2020, 4:42 PM
jpienaar accepted this revision.Mar 3 2020, 4:54 PM

Thanks!

This revision is now accepted and ready to land.Mar 3 2020, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Please look at https://reviews.llvm.org/D76031, it is pretty vanilla but I'd rather have someone test it on Windows.