Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (137 w, 1 d)

Recent Activity

Yesterday

stella.stamenova added inline comments to D88229: Reland "[lldb] Don't send invalid region addresses to lldb server".
Thu, Sep 24, 9:54 AM · Restricted Project

Wed, Sep 16

stella.stamenova added a comment to D86968: [IRSim] Adding IR Instruction Mapper.

This broke some bots:

Wed, Sep 16, 8:06 PM · Restricted Project
stella.stamenova added a reverting change for rGb04c1a9d3127: [IRSim] Adding IR Instruction Mapper: rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper".
Wed, Sep 16, 8:01 PM
stella.stamenova committed rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper" (authored by stella.stamenova).
Revert "[IRSim] Adding IR Instruction Mapper"
Wed, Sep 16, 8:01 PM
stella.stamenova added a reverting change for D86968: [IRSim] Adding IR Instruction Mapper: rGa895040eb022: Revert "[IRSim] Adding IR Instruction Mapper".
Wed, Sep 16, 8:01 PM · Restricted Project

Thu, Sep 10

stella.stamenova committed rGc464f1d8f9a0: [lldb, tests] Correctly configure the yaml2obj paths (authored by stella.stamenova).
[lldb, tests] Correctly configure the yaml2obj paths
Thu, Sep 10, 10:13 AM
stella.stamenova closed D87466: [lldb, tests] Correctly configure the yaml2obj paths.
Thu, Sep 10, 10:12 AM · Restricted Project
stella.stamenova requested review of D87466: [lldb, tests] Correctly configure the yaml2obj paths.
Thu, Sep 10, 10:04 AM · Restricted Project

Apr 9 2020

stella.stamenova added a comment to D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff..

It looks like this broke the windows lldb buildbot:

Apr 9 2020, 7:03 PM · Restricted Project, Restricted Project

Mar 11 2020

stella.stamenova added a reviewer for D76031: [mlir][CRunnerUtils] Enable compilation with C++11 toolchain on microcontroller platforms.: NathanielMcVicar.

Adding Nate who is going to own the Windows MLIR Buildbot during my maternity :).

Mar 11 2020, 4:06 PM · Restricted Project

Mar 5 2020

stella.stamenova committed rZORG7eeee2a196c0: [buildbot] Switch MLIR buildbot quotes around (authored by stella.stamenova).
[buildbot] Switch MLIR buildbot quotes around
Mar 5 2020, 4:27 PM

Mar 4 2020

stella.stamenova committed rZORG127adafa5158: [buildbot] Add an MLIR buildbot on Windows (authored by stella.stamenova).
[buildbot] Add an MLIR buildbot on Windows
Mar 4 2020, 1:31 PM
stella.stamenova closed D75495: [buildbot] Add an MLIR buildbot on Windows.
Mar 4 2020, 1:31 PM
stella.stamenova updated the diff for D75495: [buildbot] Add an MLIR buildbot on Windows.

Make check-mlir be the only checks that run

Mar 4 2020, 1:29 PM
stella.stamenova updated the diff for D75495: [buildbot] Add an MLIR buildbot on Windows.

Add AMDGPU and NVPTX to the targets

Mar 4 2020, 12:59 PM

Mar 3 2020

stella.stamenova added a comment to D75459: [mlir] Add padding to 1-D Vector in CRunnerUtils.h.
Mar 3 2020, 1:13 PM · Restricted Project
stella.stamenova added a comment to D75459: [mlir] Add padding to 1-D Vector in CRunnerUtils.h.

I'm seeing an error on Windows with this:

Mar 3 2020, 11:57 AM · Restricted Project
stella.stamenova accepted rGbcee8982a293: [mlir] Hotfix - Fix Windows build.

Thanks! This works.

Mar 3 2020, 10:56 AM

Mar 2 2020

stella.stamenova committed rZORGf2b445456044: [buildbot] Add an MLIR buildbot on Windows (authored by stella.stamenova).
[buildbot] Add an MLIR buildbot on Windows
Mar 2 2020, 5:48 PM
stella.stamenova created D75495: [buildbot] Add an MLIR buildbot on Windows.
Mar 2 2020, 5:25 PM
stella.stamenova added a comment to D75495: [buildbot] Add an MLIR buildbot on Windows.

@gkistanova: We have the machine setup to connect to silent master (buildmaster_host = 'lab.llvm.org', port = 9994) as we expect some failures. Let me know if we need to do anything else other than commit the patch and wait for a reboot. Thanks!

Mar 2 2020, 5:25 PM
stella.stamenova added a comment to D75257: [mlir] NFC - Split out RunnerUtils that don't require a C++ runtime.

This change broke the MLIR build on Windows.

Mar 2 2020, 5:14 PM · Restricted Project

Feb 27 2020

stella.stamenova accepted D75275: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3..
Feb 27 2020, 11:46 AM · Restricted Project

Feb 24 2020

stella.stamenova added a comment to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

It looks like this broke the Windows LLDB Buildbot:

Feb 24 2020, 1:25 PM · Restricted Project

Feb 21 2020

stella.stamenova added a comment to D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change.

The tests used wrong sh_flags caught by this assembler change.

Hopefully fixed by ebee131259719fa9c06cd346e21ace3fa8ac0888. I made a typo in my description. sh_flags was incorrect, not sh_type.

Feb 21 2020, 6:44 PM · Restricted Project
stella.stamenova added a comment to D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change.

Looks like this broke the Windows LLDB bot:

Feb 21 2020, 5:24 PM · Restricted Project
stella.stamenova committed rG215a31115f89: Revert "Allow customized relative PYTHONHOME" (authored by stella.stamenova).
Revert "Allow customized relative PYTHONHOME"
Feb 21 2020, 3:07 PM
stella.stamenova added a reverting change for rG0bb90628b5f7: Allow customized relative PYTHONHOME: rG215a31115f89: Revert "Allow customized relative PYTHONHOME".
Feb 21 2020, 3:07 PM
stella.stamenova added a comment to D74727: Allow customized relative PYTHONHOME.

It looks like this broke the Windows LLDB Buildbot:

Feb 21 2020, 1:34 PM · Restricted Project

Feb 19 2020

stella.stamenova committed rZORG3a4296e9c1cd: [lldb win buildbot] Add a couple people to the default notifications (authored by stella.stamenova).
[lldb win buildbot] Add a couple people to the default notifications
Feb 19 2020, 1:30 PM

Feb 18 2020

stella.stamenova added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet.

Feb 18 2020, 9:30 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
stella.stamenova added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet.

Feb 18 2020, 8:17 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
stella.stamenova added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

It looks like this broke the windows lldb bot:

Feb 18 2020, 7:30 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Feb 14 2020

stella.stamenova added a comment to D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite.

Yup, looks like that was it, the bot is green again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740

Feb 14 2020, 8:50 AM · Restricted Project

Feb 13 2020

stella.stamenova added a comment to D70993: Add lookup functions for efficient lookups of addresses when using GsymReader classes..

This broke the Windows LLDB Buildbot:

Feb 13 2020, 11:38 AM · Restricted Project
stella.stamenova added a comment to D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite.

Either this change or D74243 broke the windows bot and I do suspect D74243 but have not confirmed it yet:

Feb 13 2020, 11:01 AM · Restricted Project
stella.stamenova added a comment to D74243: [lldb] Introduce "RegInfoBasedABI".

Either this change or D74475 broke the windows bot and I suspect it's not D74475:

Feb 13 2020, 10:52 AM · Restricted Project

Feb 6 2020

stella.stamenova accepted D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite .

Thanks for doing this!

Feb 6 2020, 3:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
stella.stamenova added inline comments to D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite .
Feb 6 2020, 2:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
stella.stamenova committed rG733923a97dff: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi… (authored by stella.stamenova).
[lldb\utils] Place lldb-repro in a per-configuration directory to support multi…
Feb 6 2020, 12:34 PM
stella.stamenova closed D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators.
Feb 6 2020, 12:33 PM · Restricted Project
stella.stamenova added inline comments to D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators.
Feb 6 2020, 11:35 AM · Restricted Project
stella.stamenova created D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators.
Feb 6 2020, 11:07 AM · Restricted Project
stella.stamenova committed rGd53c8c6af522: [lldb/tests] Correctly configure the lldb dotest arguments (authored by stella.stamenova).
[lldb/tests] Correctly configure the lldb dotest arguments
Feb 6 2020, 10:31 AM
stella.stamenova closed D74093: [lldb/tests] Correctly configure the lldb dotest arguments.
Feb 6 2020, 10:30 AM · Restricted Project

Feb 5 2020

stella.stamenova created D74093: [lldb/tests] Correctly configure the lldb dotest arguments.
Feb 5 2020, 2:53 PM · Restricted Project
stella.stamenova added a comment to D73713: Fixed non-deterministic GPU intrinsic lowering..

If this is going to take more than a day or two to fix at this point, I think you should at least XFAIL the tests that are failing on Windows because any runs that include MLIR right now are red and will stay so until your fix lands. You can un-XFAIL them once you verify that they pass with the fix.

Feb 5 2020, 8:49 AM · Restricted Project

Jan 31 2020

stella.stamenova accepted D73809: eSupport] Don't modify the current EH context during stack unwinding.

LGTM and I verified that the test now passes.

Jan 31 2020, 2:53 PM · Restricted Project
stella.stamenova added a comment to D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..

CHECK-DAG makes no difference. The output simply does not contain the expected values as written. The test expects to find @_ocml_tanh_f32 (e.g. llvm.func @_ocml_tanh_f32(!llvm.float) -> !llvm.float), but the output is:

Jan 31 2020, 2:07 PM · Restricted Project

Jan 29 2020

stella.stamenova added a comment to D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL..

These two tests are failing on Windows like so:

Jan 29 2020, 2:17 PM · Restricted Project
stella.stamenova committed rGa111ffbb03f7: [lldb] Fix build break in ProcessDebugger due to StringRef usage changes (authored by stella.stamenova).
[lldb] Fix build break in ProcessDebugger due to StringRef usage changes
Jan 29 2020, 1:22 PM

Jan 21 2020

stella.stamenova added a comment to D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX.

This change is causing a build break on Windows (which was hidden by the Hexagon build break you just fixed :().

Jan 21 2020, 11:55 AM · Restricted Project

Jan 17 2020

stella.stamenova added a comment to D72957: [mlir] Unbreak MSVC build with implicit constructor.

With the latest VS 2019, the error is still the same (MSVC 19.24).

Jan 17 2020, 7:16 PM · Restricted Project
stella.stamenova added a comment to D72957: [mlir] Unbreak MSVC build with implicit constructor.

No difference (I would have been surprised, really, as the issue doesn't appear to be with the way the constructor is declared, but with how it is used):

Jan 17 2020, 2:43 PM · Restricted Project
stella.stamenova added a comment to D72310: [mlir][VectorOps] Implement strided_slice conversion.

my apologies, I lost track of this and do not have an easy repro atm, Aart is taking a shot at it.

Jan 17 2020, 10:32 AM · Restricted Project

Jan 14 2020

stella.stamenova committed rGab72db7fc852: [lldb/test] test_breakpoints_func_full from TestNamespace. (authored by stella.stamenova).
[lldb/test] test_breakpoints_func_full from TestNamespace.
Jan 14 2020, 11:23 AM

Jan 13 2020

stella.stamenova added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

This also broke a number of the tests on the Windows LLDB bot, so when you get around to resubmitting the change with a fix, please make sure the bot doesn't get broken again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12551

Jan 13 2020, 10:26 AM · debug-info, Restricted Project, Restricted Project
stella.stamenova added a comment to D72447: [lldb] Mark several tests as not dependent on debug info.

This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it):

Jan 13 2020, 10:25 AM · Restricted Project

Jan 8 2020

stella.stamenova committed rG48b14e58abc5: [MLIR] Fix ML IR build on Windows with Visual Studio (authored by stella.stamenova).
[MLIR] Fix ML IR build on Windows with Visual Studio
Jan 8 2020, 10:49 AM
stella.stamenova closed D72403: [MLIR] Fix ML IR build on Windows with Visual Studio.
Jan 8 2020, 10:49 AM · Restricted Project
stella.stamenova created D72403: [MLIR] Fix ML IR build on Windows with Visual Studio.
Jan 8 2020, 10:11 AM · Restricted Project

Dec 20 2019

stella.stamenova added a comment to D71306: [RFC] Change how we deal with optional dependencies.

This broke the Windows LLDB bot:

Dec 20 2019, 3:00 PM · Restricted Project
stella.stamenova added a comment to D71372: [lldb] Add additional validation on return address in 'thread step-out'.

It looks like this also caused a failure on the Windows LLDB bot:

Dec 20 2019, 1:25 PM · Restricted Project

Dec 17 2019

stella.stamenova added a comment to D71020: [ASTImporter] Friend class decl should not be visible in its context.

This broke the windows LLDB bot:

Dec 17 2019, 9:35 AM · Restricted Project

Dec 9 2019

stella.stamenova accepted D69535: build: improve python check for Windows.

Sorry, I was out on vacation until today :).

Dec 9 2019, 1:40 PM · Restricted Project

Oct 30 2019

stella.stamenova added a comment to D69555: [zorg] Fix LLDBCmakeBuildFactory.

Sadly, I think this broke the windows bot now (assuming it got applied to staging, otherwise I have to figure out what did):

Oct 30 2019, 3:01 PM

Oct 29 2019

stella.stamenova added a comment to D68961: Add support for DW_AT_export_symbols for anonymous structs .

This is broken on Windows. I moved the Buildbot to staging to resolve some of the issues with the move to the monorepo, so you can see the failures here:

Oct 29 2019, 11:04 AM · Restricted Project
stella.stamenova accepted D69555: [zorg] Fix LLDBCmakeBuildFactory.

Thanks @labath

Oct 29 2019, 9:48 AM

Oct 18 2019

stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Oh, and TestCallOverridenMethod still has some failures on Windows:

Oct 18 2019, 12:12 PM · Restricted Project
stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Yeah, seems like constructing objects in expressions isn't implemented on Windows. I'm not sure if there is a reliable way to test that constructors aren't shadowed by these global functions if constructors themselves don't work on Windows, but I filed llvm.org/pr43707 for the underlying bug and x-failed the tests. Will push in a few minutes.

Oct 18 2019, 10:21 AM · Restricted Project

Oct 17 2019

stella.stamenova added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Unfortunately, this is failing on the windows bot:

Oct 17 2019, 1:13 PM · Restricted Project
stella.stamenova requested changes to D69114: Disable TestProcessList on windows.

Please also file a bug and reference it in the skip statement.

Oct 17 2019, 9:46 AM · Restricted Project
stella.stamenova accepted D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests.

The tests passed in my setup. After you commit this, please monitor the windows Buildbot (it currently has a couple of failures, so you will have to check it and not rely on an email).

Oct 17 2019, 9:37 AM · Restricted Project
stella.stamenova added a comment to D68293: [android/process list] support showing process arguments.

This is causing a failure on the Windows Bot:

Oct 17 2019, 9:18 AM · Restricted Project

Oct 16 2019

stella.stamenova added inline comments to D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests.
Oct 16 2019, 11:05 AM · Restricted Project

Oct 15 2019

stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

The two things that come to mind are the path to clang-cl (which is sometimes a clang build and sometimes installed on the system as part of a VS installation or an LLVM installation) as well as the path to the linker when it is needed. This is most often an issue in the case of a VS install - I don't remember all the details any more, but I believe that before Zach added the script, we were often picking up the wrong clang-cl and ending up not being able to compile the tests at all.

Thanks.

Was this during a standalone lldb build? In a non-standalone build, lit should definitely prefer the just-built clang/lld (and if it doesn't, it should be fixed to do that). The situation is more complicated for a standalone build because the clang binary is sort of out of our control. But, in this case, I don't see how having build.py around can help, because the information about which clang to use has to come externally anyway...

How do tests like test/Shell/Register/x86*.test work in such standalone builds then? They use lines like these:

# XFAIL: system-windows
# REQUIRES: native && target-x86_64
# RUN: %clangxx -fomit-frame-pointer %p/Inputs/x86-64-gp-read.cpp -o %t
# RUN: %lldb -b -s %s %t | FileCheck %s

(The XFAIL for system-windows, at least in this test, when I tried it out, seemed to relate to the fact that register read --all on windows didn't include all the 32 bit subregisters.)

If tests already can use such constrcuts, I don't see why we couldn't use # RUN: %clang_cl .., as lit sets up %clang_cl in the same way as %clangxx.

Oct 15 2019, 1:00 PM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

Both. Again, it's been a long time, but when we use VS for building, the environment already contains a path to clang-cl so regardless of whether the build is standalone or not, the build gets confused about which clang-cl to use. @mstorsjo might want to update the tests to use clang-cl but then make sure that the update works on the Windows Buildbot (or similar environment) before committing.

Is there any way of checking whether it works on this buildbot, other than committing (after doing best effort testing of it in whatever comparable windows environments I have available)?

Oct 15 2019, 1:00 PM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

The two things that come to mind are the path to clang-cl (which is sometimes a clang build and sometimes installed on the system as part of a VS installation or an LLVM installation) as well as the path to the linker when it is needed. This is most often an issue in the case of a VS install - I don't remember all the details any more, but I believe that before Zach added the script, we were often picking up the wrong clang-cl and ending up not being able to compile the tests at all.

Thanks.

Was this during a standalone lldb build? In a non-standalone build, lit should definitely prefer the just-built clang/lld (and if it doesn't, it should be fixed to do that). The situation is more complicated for a standalone build because the clang binary is sort of out of our control. But, in this case, I don't see how having build.py around can help, because the information about which clang to use has to come externally anyway...

Oct 15 2019, 11:45 AM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

I suspect that using clang-cl directly will not work though - the script does a lot of the setup needed to run clang-cl correctly today (previously the environment for clang-cl was not setup correctly and the tests either didn't pass or passed for the wrong reasons, so using build.py has been a huge improvement).

Can you elaborate on what kind of setup do you have in mind here? Bear in mind that here we are only talking about tests that do not use any system libraries or headers, and which already run fine on a linux system which does not have any windows-specific stuff installed. With those restrictions, I don't see what can be possibly gained from using build.py. The only thing I can see it possibly doing is to clear some environment variables which might otherwise be present and confuse clang-cl. However, that's something that can be easily done in lit.

Oct 15 2019, 11:08 AM · Restricted Project
stella.stamenova added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

I haven't fully debugged this, but it looks like this change caused a failure on the Windows LLDB bot. There was already another failure, so you probably didn't get an email:

Oct 15 2019, 10:58 AM · Restricted Project
stella.stamenova added a comment to D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py.

This change looks fine assuming all the tests continue to pass.

Oct 15 2019, 10:48 AM · Restricted Project

Oct 14 2019

stella.stamenova accepted D68951: Fix test breakage caused by r374424.
Oct 14 2019, 11:49 AM · Restricted Project
stella.stamenova added a comment to D68738: update TestRunCommandInterpreterAPI to use SBFile.

This is still failing on the Windows bot. Please fix it ASAP or revert it.

Oct 14 2019, 9:20 AM · Restricted Project
stella.stamenova added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It looks like this changed fixed at least one of the XFAILed tests on Windows:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751

So now the test results would be red because of the unexpectedly passing test (if there wasn't another failure). Could you have a look at whether any of the other tests that were XFAILed for the same bug are also now passing and remove the expected failure tags as appropriate?

Oct 14 2019, 9:20 AM · Restricted Project, Restricted Project

Oct 11 2019

stella.stamenova added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

It looks like this changed fixed at least one of the XFAILed tests on Windows:

Oct 11 2019, 12:51 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D68738: update TestRunCommandInterpreterAPI to use SBFile.

This is failing on the windows bot. There was already another failure, so you probably didn't get an email:

Oct 11 2019, 9:37 AM · Restricted Project

Oct 8 2019

stella.stamenova added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

It looks like this broke one of the tests on the Windows LLDB bot:

Oct 8 2019, 9:47 AM · Restricted Project
stella.stamenova accepted D68613: [CMake] Fix building without python on Windows.
Oct 8 2019, 9:13 AM · Restricted Project

Oct 7 2019

stella.stamenova added a comment to D68354: [platform process list] add a flag for showing the processes of all users.

The windows LLDB bot also has the same failure: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9600

Oct 7 2019, 4:12 PM · Restricted Project

Oct 2 2019

stella.stamenova added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Thanks for taking care of this!

Oct 2 2019, 6:12 PM · Restricted Project
stella.stamenova added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

This broke the windows build: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. There was already a test broken from earlier today, so you might not have gotten an email.

Oct 2 2019, 3:05 PM · Restricted Project

Sep 30 2019

stella.stamenova added a comment to D68171: Remove unused "append" parameter from FindTypes API.

This broke the windows bot. A couple of other issues have shown up and been fixed since, but this change is still causing a break:

Sep 30 2019, 8:04 PM · Restricted Project

Sep 23 2019

stella.stamenova committed rG1962122c4d55: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows (authored by stella.stamenova).
[lldb-suite] TestCallOverriddenMethod.py is now passing on Windows
Sep 23 2019, 10:56 AM
stella.stamenova committed rL372634: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows.
[lldb-suite] TestCallOverriddenMethod.py is now passing on Windows
Sep 23 2019, 10:50 AM

Sep 11 2019

stella.stamenova added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

This broke the windows bot:

Sep 11 2019, 5:48 AM · Restricted Project, Restricted Project
stella.stamenova accepted D66574: [lit] Make internal diff work in pipelines.

LGTM as long as all the tests still pass

Sep 11 2019, 5:36 AM · Restricted Project

Aug 30 2019

stella.stamenova added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain.

Aug 30 2019, 11:27 AM · Restricted Project, Restricted Project

Aug 22 2019

stella.stamenova added a comment to D66546: Extend FindTypes w/ CompilerContext to allow filtering by language.

It looks like this broke the windows build bot:

Aug 22 2019, 1:26 PM · Restricted Project

Aug 20 2019

stella.stamenova accepted D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC).

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

Aug 20 2019, 2:51 PM · Restricted Project, Restricted Project
stella.stamenova accepted D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.

I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were to make it explicit when we will or we won't override the user-set compiler. As long as we are OK overriding it if they set it to an empty string (which is probably an error, anyway), this change is good.

Aug 20 2019, 10:40 AM · Restricted Project, Restricted Project