Page MenuHomePhabricator

stella.stamenova (Stella Stamenova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 7:04 PM (205 w, 6 d)

Recent Activity

Yesterday

stella.stamenova accepted D117637: Fix build break on CentOS due to gcc 7.3.1.

LGTM

Tue, Jan 18, 10:13 PM · Restricted Project
stella.stamenova added a comment to D117581: [lldb] Use lldb-server by default on Windows.

So, sadly, I am going to have to backtrack here. When I set LLDB_USE_LLDB_SERVER in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me.

Tue, Jan 18, 4:10 PM · Restricted Project
stella.stamenova requested review of D117599: [mlir] Configure mlir so that it can be directly included in a parent cmakelists.txt.
Tue, Jan 18, 1:13 PM · Restricted Project
stella.stamenova added a comment to D117113: [lldb] [llgs] Implement qXfer:siginfo:read.

This does not build correctly with gcc 7.3.1 on CentOS:

Tue, Jan 18, 10:25 AM · Restricted Project
stella.stamenova requested review of D117581: [lldb] Use lldb-server by default on Windows.
Tue, Jan 18, 10:12 AM · Restricted Project
stella.stamenova added a comment to D116972: [lldb] Run the test suite in verbose mode.

Since @omjavaid is working on a related change in https://reviews.llvm.org/D117363, perhaps he can make the necessary changes there to support -j for the tests?

Tue, Jan 18, 9:40 AM
stella.stamenova accepted D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB.

LGTM.

Tue, Jan 18, 9:28 AM · Restricted Project

Fri, Jan 14

stella.stamenova added a comment to D117363: LLDB Windows x64 buildbot set lit -j8.

I think they should be set in just one place to make the code more readable.

I was about to suggest the same.

It might be simpler and more straight forward to revert D116972 and just explicitly specify the needed LLVM_LIT_ARGS in the extra_cmake_args.
If you would like to set -v and -j by default, that could be done by something like this:

defult_lit_args = '-v'
if if jobs:
    defult_lit_args += " -j{jobs}".format(jobs=jobs)
CmakeCommand.applyDefaultOptions(cmake_options, [
        ('-DLLVM_LIT_ARGS=', defult_lit_args),
        ])
Fri, Jan 14, 3:30 PM · Restricted Project
stella.stamenova added inline comments to D117363: LLDB Windows x64 buildbot set lit -j8.
Fri, Jan 14, 2:55 PM · Restricted Project
stella.stamenova added a reviewer for D117363: LLDB Windows x64 buildbot set lit -j8: JDevlieghere.
Fri, Jan 14, 2:38 PM · Restricted Project
stella.stamenova added inline comments to D117363: LLDB Windows x64 buildbot set lit -j8.
Fri, Jan 14, 2:38 PM · Restricted Project

Thu, Jan 13

stella.stamenova retitled D117267: [lldb] Add support for choosing which checks to run on lldb builders from [lldb] Add support for choosing which checks to run to lldb builders to [lldb] Add support for choosing which checks to run on lldb builders.
Thu, Jan 13, 8:38 PM
stella.stamenova added inline comments to D117267: [lldb] Add support for choosing which checks to run on lldb builders.
Thu, Jan 13, 5:51 PM
stella.stamenova requested review of D117267: [lldb] Add support for choosing which checks to run on lldb builders.
Thu, Jan 13, 5:49 PM
stella.stamenova accepted D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.

LGTM.

Thu, Jan 13, 11:16 AM · Restricted Project
stella.stamenova added inline comments to D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.
Thu, Jan 13, 9:07 AM · Restricted Project

Wed, Jan 12

stella.stamenova committed rG8fec756c0b54: [lldb] Disable one more watchpoint test on Windows (authored by stella.stamenova).
[lldb] Disable one more watchpoint test on Windows
Wed, Jan 12, 8:56 AM
stella.stamenova added a reverting change for rG945aa520ef07: [LLDB][NativePDB] Add support for inlined functions: rG10bc3362a1a8: Revert "[LLDB][NativePDB] Add support for inlined functions".
Wed, Jan 12, 8:54 AM
stella.stamenova committed rG10bc3362a1a8: Revert "[LLDB][NativePDB] Add support for inlined functions" (authored by stella.stamenova).
Revert "[LLDB][NativePDB] Add support for inlined functions"
Wed, Jan 12, 8:54 AM
stella.stamenova added a reverting change for D116845: [LLDB][NativePDB] Add support for inlined functions: rG10bc3362a1a8: Revert "[LLDB][NativePDB] Add support for inlined functions".
Wed, Jan 12, 8:54 AM · Restricted Project

Mon, Jan 10

stella.stamenova accepted D116972: [lldb] Run the test suite in verbose mode.

LGTM

Mon, Jan 10, 2:26 PM
stella.stamenova committed rG9b5cf7267beb: [lldb] Disable several lldb tests that are flaky on Windows (authored by stella.stamenova).
[lldb] Disable several lldb tests that are flaky on Windows
Mon, Jan 10, 10:21 AM

Dec 16 2021

stella.stamenova added a comment to D114639: Raise the minimum Visual Studio version to VS2019.

@rnk @stella.stamenova How long do you think it will be before you can update your buildbots to VS2019 or VS2022 please?

The mlir buildbot was updated already. The lldb buildbot will be done this week - there's a test change that needs to happen in lldb before we can update the buildbot. I'll let you know once it's done.

Dec 16 2021, 3:44 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster..

The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to see if it would be appropriate to modify somehow so it would work:

Dec 16 2021, 3:42 PM · Restricted Project

Dec 14 2021

stella.stamenova committed rGf4abf28c0a0b: [lldb] Update the PDB tests to pass with the VS2019 toolset (authored by stella.stamenova).
[lldb] Update the PDB tests to pass with the VS2019 toolset
Dec 14 2021, 1:06 PM
stella.stamenova closed D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset.
Dec 14 2021, 1:06 PM · Restricted Project
stella.stamenova added a comment to D114639: Raise the minimum Visual Studio version to VS2019.

@rnk @stella.stamenova How long do you think it will be before you can update your buildbots to VS2019 or VS2022 please?

Dec 14 2021, 10:36 AM · Restricted Project, Restricted Project

Dec 9 2021

stella.stamenova added inline comments to D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset.
Dec 9 2021, 4:57 PM · Restricted Project
stella.stamenova requested review of D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset.
Dec 9 2021, 4:55 PM · Restricted Project

Dec 2 2021

stella.stamenova committed rGc24860118a7e: [lldb] Skip two lldb tests on Windows because they are flaky (authored by stella.stamenova).
[lldb] Skip two lldb tests on Windows because they are flaky
Dec 2 2021, 9:53 AM
stella.stamenova closed D114907: [lldb] Skip two lldb tests on Windows because they are flaky.
Dec 2 2021, 9:53 AM · Restricted Project

Dec 1 2021

stella.stamenova requested review of D114907: [lldb] Skip two lldb tests on Windows because they are flaky.
Dec 1 2021, 1:20 PM · Restricted Project

Nov 29 2021

stella.stamenova added a comment to D114639: Raise the minimum Visual Studio version to VS2019.

Have you checked whether there are any bots in the lab that will need to be updated?

I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and windows-gcebot2 machines, but there are others.

This bot as well: https://lab.llvm.org/buildbot/#/builders/13 ; adding @stella.stamenova here.

Nov 29 2021, 5:03 PM · Restricted Project, Restricted Project
stella.stamenova added a comment to D114467: [LLDB][NativePDB] Allow find functions by full names.

@zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413

Nov 29 2021, 10:57 AM · Restricted Project
stella.stamenova added a comment to D114467: [LLDB][NativePDB] Allow find functions by full names.

This broke the windows bot:

Nov 29 2021, 9:55 AM · Restricted Project

Nov 19 2021

stella.stamenova added a comment to D113881: [mlir] Move min/max ops from Std to Arith..

We've been seeing a failure in our Ubuntu builds since this change - specifically because of an unused function:

Nov 19 2021, 9:52 AM · Restricted Project

Nov 15 2021

stella.stamenova added a comment to D113821: [LLDB][NativePDB] Fix image lookup by address.

I think this broke the windows bot:

Nov 15 2021, 3:57 PM · Restricted Project

Nov 12 2021

stella.stamenova added a comment to D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.

This broke the build on Windows. The buildbot was, sadly, already red because of another test failure:

Nov 12 2021, 3:35 PM · Restricted Project
stella.stamenova added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red.

Nov 12 2021, 3:34 PM · Restricted Project

Nov 11 2021

stella.stamenova added inline comments to D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 11 2021, 10:01 AM · Restricted Project
stella.stamenova added inline comments to D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 11 2021, 9:42 AM · Restricted Project

Nov 10 2021

stella.stamenova added a comment to D112973: [lldb] make it easier to find LLDB's python.

Windows buildbot is broken:

Nov 10 2021, 12:23 PM · Restricted Project

Nov 3 2021

stella.stamenova added a comment to D113047: [lldb] update TestEchoCommands.

The Windows buildbot is still broken after this change:

Nov 3 2021, 10:42 AM · Restricted Project

Nov 2 2021

stella.stamenova added inline comments to D113047: [lldb] update TestEchoCommands.
Nov 2 2021, 4:03 PM · Restricted Project
stella.stamenova added a comment to D112988: [lldb] fix --source-quietly.

It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now):

Nov 2 2021, 1:16 PM · Restricted Project

Oct 13 2021

stella.stamenova committed rG58917054c298: [lldb] Skip several lldb tests that are flaky on Windows (authored by stella.stamenova).
[lldb] Skip several lldb tests that are flaky on Windows
Oct 13 2021, 9:47 AM
stella.stamenova closed D111659: [lldb] Skip several lldb tests that are flaky on Windows.
Oct 13 2021, 9:46 AM · Restricted Project

Oct 12 2021

stella.stamenova requested review of D111659: [lldb] Skip several lldb tests that are flaky on Windows.
Oct 12 2021, 10:03 AM · Restricted Project

Oct 8 2021

stella.stamenova added a comment to D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess.

This broke the windows lldb bot:

Oct 8 2021, 9:01 AM · Restricted Project

Oct 6 2021

stella.stamenova committed rG10f16bc7b2bf: Revert "[lldb] [ABI/X86] Split base x86 and i386 classes" (authored by stella.stamenova).
Revert "[lldb] [ABI/X86] Split base x86 and i386 classes"
Oct 6 2021, 10:57 AM
stella.stamenova added a reverting change for rGa30a36f66aea: [lldb] [ABI/X86] Split base x86 and i386 classes: rG10f16bc7b2bf: Revert "[lldb] [ABI/X86] Split base x86 and i386 classes".
Oct 6 2021, 10:57 AM
stella.stamenova added a reverting change for D111216: [lldb] [ABI/X86] Split plugin class and base i386 class: rG10f16bc7b2bf: Revert "[lldb] [ABI/X86] Split base x86 and i386 classes".
Oct 6 2021, 10:57 AM · Restricted Project

Sep 27 2021

stella.stamenova added a comment to D110489: Make windows resource generation more robust to misconfiguration..

LGTM. I find it easier to read if it's all done together (see comment), but it's fine either way.

Sep 27 2021, 1:16 PM · Restricted Project

Sep 21 2021

stella.stamenova added a comment to D110187: Avoid building the entire tree and testing LLVM itself on MLIR builders.

How much of a difference does it make in terms of build times?

Sep 21 2021, 10:35 AM

Sep 9 2021

stella.stamenova committed rG584a5d171eca: Remove obsolete msvc workaround from AddLLVM.cmake (authored by stella.stamenova).
Remove obsolete msvc workaround from AddLLVM.cmake
Sep 9 2021, 10:50 AM
stella.stamenova closed D109521: Remove obsolete msvc workaround from AddLLVM.cmake.
Sep 9 2021, 10:50 AM · Restricted Project
stella.stamenova requested review of D109521: Remove obsolete msvc workaround from AddLLVM.cmake.
Sep 9 2021, 9:27 AM · Restricted Project

Sep 8 2021

stella.stamenova added a comment to D105961: Defend early against operation created without a registered dialect.

The fix in AddLLVM.cmake seems best, I didn't quite get what we'd fix in the test itself?

Sep 8 2021, 10:00 AM · Restricted Project

Sep 7 2021

stella.stamenova added a comment to D105961: Defend early against operation created without a registered dialect.

Thanks for tracking it down @stella.stamenova ; indeed the original commit is:

commit b46fdac4609df2613177813d43a124e3d9a8a306
Author: Andrew Trick <atrick@apple.com>
Date:   Tue Jun 28 16:32:01 2011

    cmake: Our MSVC build does not support config-time build mode.
    
    llvm-svn: 134008

There isn't much more info. If you remove the special case for MSVC_IDE and it works that'd be ideal.
Otherwise there is also the option to disable this test on windows for now.

Sep 7 2021, 11:14 AM · Restricted Project

Sep 2 2021

stella.stamenova updated subscribers of D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW.

@thakis @int3 I spent some more time trying to diagnose the recent issues with lld and macho and I am starting to think that the problem is the race condition that this change was meant to fix. I am not sure why this is no longer "fixed", but the callstack and intermittent failure on Windows in debug seem to match the issue:

Sep 2 2021, 11:27 AM · Restricted Project
stella.stamenova added a comment to D104516: [mlir] Add a ThreadPool to MLIRContext and refactor MLIR threading usage.

So not an issue with the current implementation, but a note for any future improvements: the changes in https://reviews.llvm.org/D70447 that made parallel work on Windows were, I believe, necessary (I did not catch the original review, but I've recently run into some issues). Not only that, I believe something has recently (in the last few months) impacted the existing functionality such that lld now regularly exhibits the issues described in https://reviews.llvm.org/D70447, so I would caution using that until they've been resolved.

Sep 2 2021, 11:23 AM · Restricted Project, Restricted Project

Aug 30 2021

stella.stamenova added a comment to D105961: Defend early against operation created without a registered dialect.

This change introduced a failure on Windows, but only when compiling with Visual Studio which is why it did not impact the buildbots (or really, almost any other uses cases, since most people use ninja). It came up as part of onnx-mlir merge with the latest llvm (https://github.com/onnx/onnx-mlir/pull/814) and I can confirm that I see the same failure locally.

Aug 30 2021, 3:03 PM · Restricted Project

Aug 11 2021

stella.stamenova added a comment to D107838: [CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding.

This change introduced a race condition in the build and we saw it fail in our private buildbots on both Ubuntu and Windows because of a dependency on Attributes.inc (the target intrinsics_gen) which had previously been covered by the ProfileData library. I haven't confirmed whether https://reviews.llvm.org/rG68d6c3e4486c6743dfa419ec0d919d8e97fdad05 removed that dependency by removing the header from ProfileData, though it likely does, so I wanted to leave a note here for anyone else who runs into this - or if it recurs.

Aug 11 2021, 9:34 AM · Restricted Project

Aug 9 2021

stella.stamenova added a comment to D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance.

This change is causing failures on the Windows lldb bot:

Aug 9 2021, 10:18 AM · Restricted Project, Restricted Project

Aug 6 2021

stella.stamenova committed rG0b8cb87e0d6b: [MLIR][STD] Add safe scalar constant propagation for FPTruncOp (authored by max-kudr).
[MLIR][STD] Add safe scalar constant propagation for FPTruncOp
Aug 6 2021, 4:32 PM
stella.stamenova closed D107518: [MLIR][STD] Add safe scalar constant propagation for FPTruncOp.
Aug 6 2021, 4:32 PM · Restricted Project

Jul 30 2021

stella.stamenova added a reverting change for rG8dfd6cae9bd6: [lldb] [DWARF-5] Be lazier about loading .dwo files: rGdfb6f7b01595: Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files".
Jul 30 2021, 6:34 PM
stella.stamenova committed rGdfb6f7b01595: Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files" (authored by stella.stamenova).
Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files"
Jul 30 2021, 6:34 PM
stella.stamenova added a reverting change for D100299: Be lazier about loading .dwo files: rGdfb6f7b01595: Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files".
Jul 30 2021, 6:34 PM · Restricted Project
stella.stamenova added a comment to D100299: Be lazier about loading .dwo files.

Is arm hardware necessary to test this,

In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries and include files. I agree it was my mistake as the cross-compilation is easier in this case.

or can the test be modified to cross-compile to arm to see what is going on?

In fact it is visible already from the build log and it is then obvious from source code. I did not see it first from the default shortened dump.

Is there a way to determine what build target the test bot is using?

Yes, armv8l-unknown-linux-gnueabihf.

In any case the broken test doesn't exercise lldb at all so it could be separated from the patch.

If the test did not exercise LLDB it should have been removed. But it does exercise LLDB.

I have added to lldb/test/Shell/SymbolFile/DWARF/split-optimized.c:

+// ObjectFileELF::ApplyRelocations does not implement arm32.
+// XFAIL: target-arm && linux-gnu

Hopefully it will satisfy the buildbot now.

Jul 30 2021, 3:37 PM · Restricted Project

Jul 29 2021

stella.stamenova added a reverting change for rG77e9d10f0fbf: [lldb] Assert filecache and live memory match on debug under a setting: rG66ba4e3dc608: Revert "[lldb] Assert filecache and live memory match on debug under a setting".
Jul 29 2021, 10:49 AM
stella.stamenova committed rG66ba4e3dc608: Revert "[lldb] Assert filecache and live memory match on debug under a setting" (authored by stella.stamenova).
Revert "[lldb] Assert filecache and live memory match on debug under a setting"
Jul 29 2021, 10:49 AM

Jul 26 2021

stella.stamenova added a comment to D106759: [yaml2obj][MachO] Rename PayloadString to Content.

It looks like this broke some lldb tests:

Jul 26 2021, 9:52 AM · Restricted Project, Restricted Project

Jul 23 2021

stella.stamenova committed rG328bb2caae81: [cmake] Export LLVM_HOST_TRIPLE in the LLVMConfig.cmake (authored by stella.stamenova).
[cmake] Export LLVM_HOST_TRIPLE in the LLVMConfig.cmake
Jul 23 2021, 3:54 PM
stella.stamenova closed D106686: [cmake] Export LLVM_HOST_TRIPLE in the LLVMConfig.cmake.
Jul 23 2021, 3:53 PM · Restricted Project
stella.stamenova requested review of D106686: [cmake] Export LLVM_HOST_TRIPLE in the LLVMConfig.cmake.
Jul 23 2021, 10:12 AM · Restricted Project

Jul 22 2021

stella.stamenova added a comment to D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0.

I think this change broke the Windows LLDB bot. More specifically the TestStructTypes test:

https://lab.llvm.org/buildbot/#/builders/83/builds/8528

Jul 22 2021, 8:14 AM · Restricted Project
stella.stamenova added a comment to D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0.

I think this change broke the Windows LLDB bot. More specifically the TestStructTypes test:

Jul 22 2021, 8:11 AM · Restricted Project

Jul 9 2021

stella.stamenova added a comment to D105653: [IR] Don't accept nullptr as GEP element type.

This change broke the windows and debian lldb bots:

Jul 9 2021, 11:34 AM · Restricted Project
stella.stamenova added a reverting change for rG5035e7be1a8a: [IR] Don't accept nullptr as GEP element type: rGa821df993def: Revert "[IR] Don't accept nullptr as GEP element type".
Jul 9 2021, 11:34 AM
stella.stamenova committed rGa821df993def: Revert "[IR] Don't accept nullptr as GEP element type" (authored by stella.stamenova).
Revert "[IR] Don't accept nullptr as GEP element type"
Jul 9 2021, 11:33 AM
stella.stamenova added a reverting change for D105653: [IR] Don't accept nullptr as GEP element type: rGa821df993def: Revert "[IR] Don't accept nullptr as GEP element type".
Jul 9 2021, 11:33 AM · Restricted Project

Jul 2 2021

stella.stamenova added a comment to D105359: [mlir][Vector] NFC - Compress vector to outerproduct lowering..

This change broke the Windows mlir bot:

Jul 2 2021, 10:39 AM · Restricted Project

Jul 1 2021

stella.stamenova added a comment to D100670: [ADT] Add makeVisitor to STLExtras.h.

A couple of the new test cases are consistently failing on Windows when building Debug. They do pass in Release

Jul 1 2021, 9:42 AM · Restricted Project
stella.stamenova added a comment to D105126: [mlir:Async] Change async-parallel-for block size/count calculation.

After this change kMaxOvershading is unused, causing warnings in the clang build:

Jul 1 2021, 9:27 AM · Restricted Project

Jun 29 2021

stella.stamenova added a comment to D105160: Create synthetic symbol names on demand to improve memory consumption and startup times..

@stella.stamenova all test suite failures should be fixed now. This is a redo on https://reviews.llvm.org/D104488 which was reverted in less that a day...

Jun 29 2021, 4:40 PM · Restricted Project
stella.stamenova committed rGc8a9c78e170e: [lldb] Fix debug_loc.s which was broken after https://reviews.llvm.org/D103502 (authored by stella.stamenova).
[lldb] Fix debug_loc.s which was broken after https://reviews.llvm.org/D103502
Jun 29 2021, 1:55 PM
stella.stamenova added a comment to D103502: [DebugInfo] Bug 41152 - Improve dumping of empty location expressions.

It looks like these change broken some lldb tests. The windows bot already had a couple of failures, so you may have missed it:

Jun 29 2021, 1:45 PM · debug-info, Restricted Project
stella.stamenova committed rG9952d591ccc4: [lldb] Fix globals-bss.cpp which was broken in https://reviews.llvm.org/D105055 (authored by stella.stamenova).
[lldb] Fix globals-bss.cpp which was broken in https://reviews.llvm.org/D105055
Jun 29 2021, 1:39 PM
stella.stamenova committed rGbb2cfca2f323: Revert D104488 and friends since it broke the windows bot (authored by stella.stamenova).
Revert D104488 and friends since it broke the windows bot
Jun 29 2021, 1:00 PM
stella.stamenova added a reverting change for D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.: rGbb2cfca2f323: Revert D104488 and friends since it broke the windows bot.
Jun 29 2021, 12:59 PM · Restricted Project
stella.stamenova added a comment to D104488: Create synthetic symbol names on demand to improve memory consumption and startup times..

This broke the windows lldb bot and the follow up changes did not fix it:

Jun 29 2021, 9:16 AM · Restricted Project

Jun 22 2021

stella.stamenova added a comment to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

The newly added test is flaky and it fails on the Windows bot every few runs. I also saw it fail on Ubuntu in our private buildbots.
Failing build:
https://lab.llvm.org/buildbot/#/builders/13/builds/8922

Jun 22 2021, 3:22 PM · Restricted Project

Jun 21 2021

stella.stamenova added a comment to D101128: [lldb-vscode] only report long running progress events.

I'm reverting it asap

Jun 21 2021, 11:14 AM · Restricted Project
stella.stamenova added a comment to D101128: [lldb-vscode] only report long running progress events.

@wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look:

Jun 21 2021, 10:47 AM · Restricted Project

Jun 18 2021

stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

We also see check-all timeout recently (fairly consistently), see https://bugs.chromium.org/p/chromium/issues/detail?id=1221702

Since Stella reported problems with this too, I speculatively reverted it (and follow-ups) in fb32de9e97af0921242a021e30020ffacf7aa6e2 for now.

Jun 18 2021, 3:57 PM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm now running all of the clang tests repeatedly to see if I can get a repro that way.

Jun 18 2021, 9:26 AM · Restricted Project

Jun 17 2021

stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

This is the best I can do from the online builds. I'll try and repro locally as well:

Jun 17 2021, 1:22 PM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

Interesting, are the logs from the runs available? I have run the test ~10000 times locally and its been stable. Perhaps the logs can show what is going on.

Jun 17 2021, 11:31 AM · Restricted Project
stella.stamenova added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to reproduce locally.

Jun 17 2021, 11:24 AM · Restricted Project