This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Construct __start_std_streams at high init priority
AbandonedPublic

Authored by ldionne on Feb 19 2020, 7:55 PM.

Details

Reviewers
EricWF
mclow.lists
sbc100
Group Reviewers
Restricted Project
Summary

This allows normal static constructors use use std::cout, etc.

We've been patching this in emscripten for a long time now.
See https://github.com/emscripten-core/emscripten/issues/3824

Fixes: PR28954

Diff Detail

Event Timeline

sbc100 created this revision.Feb 19 2020, 7:55 PM
Herald added a project: Restricted Project. · View Herald Transcript
sbc100 edited the summary of this revision. (Show Details)Feb 19 2020, 7:57 PM

Oops, I saw you already have https://reviews.llvm.org/D31413 out .. for a while now. And the associated bug: http://llvm.org/PR28954

sbc100 edited the summary of this revision. (Show Details)Feb 19 2020, 8:06 PM
ldionne requested changes to this revision.Feb 20 2020, 6:54 AM

Also, please coordinate with @EricWF on https://reviews.llvm.org/D31413. I haven't followed the whole thing, but what are we blocked on? It seems like a fairly serious issue that's worth fixing.

libcxx/src/iostream.cpp
83

Building the dylib on Apple isn't supported with GCC. It may happen to work, but that's not maintained. Please don't add a code path to support it -- it just makes things slightly more complex while giving a false impression of support.

This revision now requires changes to proceed.Feb 20 2020, 6:54 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2020, 5:58 PM
ldionne commandeered this revision.Sep 16 2020, 9:17 AM
ldionne edited reviewers, added: sbc100; removed: ldionne.

Let's close this in favour of https://reviews.llvm.org/D31413 to clean things up.

This revision now requires review to proceed.Sep 16 2020, 9:17 AM