Page MenuHomePhabricator

[mlir][spirv] Add dialect-specific attribute for target environment
ClosedPublic

Authored by antiagainst on Feb 4 2020, 5:37 AM.

Details

Summary

We were using normal dictionary attribute for target environment
specification. It becomes cumbersome with more and more fields.
This commit changes the modelling to a dialect-specific attribute,
where we can have control over its storage and assembly form.

Diff Detail

Event Timeline

antiagainst created this revision.Feb 4 2020, 5:37 AM

Unit tests: pass. 62440 tests passed, 0 failed and 845 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

denis13 added inline comments.Feb 4 2020, 2:22 PM
mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
742

s/attribbutes/attributes/ ?

benvanik accepted this revision.Feb 4 2020, 6:20 PM
V_1_3, [], [Shader, GroupNonUniformArithmetic],

Beautiful!

This revision is now accepted and ready to land.Feb 4 2020, 6:20 PM
antiagainst marked an inline comment as done.Feb 4 2020, 6:33 PM
This revision was automatically updated to reflect the committed changes.