This is an archive of the discontinued LLVM Phabricator instance.

Add a 'no-asserts' requirement option to LIT.
AbandonedPublic

Authored by resistor on Feb 3 2015, 11:03 AM.

Download Raw Diff

Details

Reviewers

Summary

This is useful when checking diagnostics and annotations that are only enabled in asserts mode. Today we can only test the positive case (when asserts are enabled) but not the negative case.

Diff Detail

Repository: rL LLVM

Event Timeline

resistor updated this revision to Diff 19251.Feb 3 2015, 11:03 AM

resistor retitled this revision from to Add a 'no-asserts' requirement option to LIT..

resistor updated this object.

resistor edited the test plan for this revision. (Show Details)

resistor added reviewers: chandlerc, mehdi_amini.

resistor set the repository for this revision to rL LLVM.

resistor added a subscriber: Unknown Object (MLST).

mehdi_amini removed a reviewer: mehdi_amini.Mar 8 2015, 10:09 PM

Do we document the possible arguments to REQUIRES somewhere?
I'm always having to troll through the lit code to figure them out.
--paulr

I don't understand the requested change...

We already have the ability to say 'REQUIRES: asserts' when checking things only enabled in asserts builds.

It sounds like you want to check for things only enabled in *no-*asserts builds? I'm surprised any such things exist. My inclination is to say "we shouldn't have no-asserts emit data that we don't emit in asserts".

This revision now requires changes to proceed.Mar 29 2015, 4:45 PM

resistor abandoned this revision.Apr 1 2015, 9:51 AM

Revision Contents

Path

Size

test/

lit.cfg

2 lines

Diff 19251

test/lit.cfg

Context not available.

	if re.search(r'ON', llvm_config_cmd.stdout.read().decode('ascii')):	if re.search(r'ON', llvm_config_cmd.stdout.read().decode('ascii')):
	config.available_features.add('asserts')	config.available_features.add('asserts')
		else:
		config.available_features.add('no-asserts')
	llvm_config_cmd.wait()	llvm_config_cmd.wait()

	if 'darwin' == sys.platform:	if 'darwin' == sys.platform:
Context not available.