Page MenuHomePhabricator

[libunwind] Treat assembly files as C on mingw
ClosedPublic

Authored by mstorsjo on Jan 26 2020, 12:20 PM.

Details

Summary

When targeting mingw, current CMake (3.16) fails to get the right flags for assembly source files for windows gnu/clang targets (see https://gitlab.kitware.com/cmake/cmake/merge_requests/4287 for a fix), causing builds to fail due to -fPIC being unsupported in clang for mingw targets.

In the meantime, restore the behaviour from before c48974ffd7d1676 selectively on mingw targets, treating the assembly files as C.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 26 2020, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2020, 12:20 PM
smeenai accepted this revision.Jan 26 2020, 4:01 PM

LGTM

libunwind/src/CMakeLists.txt
28

Maybe you could clarify that it's all CMake versions as of 3.16 that have this issue, not just 3.16 specifically.

This revision is now accepted and ready to land.Jan 26 2020, 4:01 PM
This revision was automatically updated to reflect the committed changes.