This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Implement semantic action for ENTRY linker script command
ClosedPublic

Authored by davide on Jan 31 2015, 4:59 PM.

Reviewers

davide retitled this revision from to [ELF] Implement semantic action for ENTRY linker script command.

davide updated this object.

davide edited the test plan for this revision. (Show Details)

davide set the repository for this revision to rL LLVM.

davide added a project: lld.

davide added subscribers: emaste, Unknown Object (MLST).

LGTM.

This revision is now accepted and ready to land.Jan 31 2015, 6:13 PM

LGTM

lib/Driver/GnuLdDriver.cpp
292	nit: I'd choose a shorter name for entrySymbol, like e or entry, because the scope of the variable is very short (two lines).

Path

Size

lib/

Driver/

2 lines

unittests/

DriverTests/

13 lines

Context not available.
	return ec;	return ec;
	if (auto *searchDir = dyn_cast<script::SearchDir>(c))	if (auto *searchDir = dyn_cast<script::SearchDir>(c))
	ctx.addSearchPath(searchDir->getSearchPath());	ctx.addSearchPath(searchDir->getSearchPath());
		if (auto *entrySymbol = dyn_cast<script::Entry>(c))
		ruiuUnsubmitted Not Done Reply Inline Actions nit: I'd choose a shorter name for entrySymbol, like e or entry, because the scope of the variable is very short (two lines). ruiu: nit: I'd choose a shorter name for entrySymbol, like e or entry, because the scope of the…
		ctx.setEntrySymbolName(entrySymbol->getEntryName());
	}	}
	return std::error_code();	return std::error_code();
	}	}
Context not available.

Context not available.
	EXPECT_EQ((size_t)2, searchPaths.size());	EXPECT_EQ((size_t)2, searchPaths.size());
	EXPECT_EQ("/foo/bar", searchPaths[1]);	EXPECT_EQ("/foo/bar", searchPaths[1]);
	}	}

		TEST_F(GnuLdParserTest, LinkerScriptEntry) {
		parse("ld", "a.o", nullptr);
		std::unique_ptr<MemoryBuffer> mb = MemoryBuffer::getMemBuffer(
		"ENTRY(blah)", "foo.so");
		std::string s;
		raw_string_ostream out(s);
		std::error_code ec = GnuLdDriver::evalLinkerScript(
		*_context, std::move(mb), out);
		EXPECT_FALSE(ec);
		StringRef entrySymbol = _context->entrySymbolName();
		EXPECT_EQ("blah", entrySymbol);
		}
Context not available.