Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (299 w, 3 d)

Recent Activity

Wed, Aug 5

davide added a comment to D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

auto_ptr is deprecated since C++11 and will be removed in C++17.

Wed, Aug 5, 10:28 PM · Restricted Project
davide accepted D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

This is correct to the best of my understanding. Thank you Jason.

Wed, Aug 5, 10:04 PM · Restricted Project
davide accepted D85388: [lldb] Fix bug in skipIfRosetta decorator.

yes, this makes sense. We could refine the check in future.

Wed, Aug 5, 8:48 PM · Restricted Project
davide added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Wed, Aug 5, 6:00 PM
davide requested changes to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Wed, Aug 5, 5:58 PM
davide added inline comments to D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary.
Wed, Aug 5, 4:08 PM · Restricted Project
davide accepted D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests..

I assume we're still allowing to put the decorator on a test-by-test basis, and that seems the case from what I see.
If so, LG.

Wed, Aug 5, 3:19 PM · Restricted Project

Tue, Aug 4

davide accepted D85172: Teach SROA to handle allocas with more than one dbg.declare..

LGTM with Saleem's comment addressed.

Tue, Aug 4, 1:52 PM · Restricted Project, debug-info

Mon, Aug 3

davide closed D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7

Mon, Aug 3, 3:43 PM

Thu, Jul 30

davide committed rG57605758b5de: [debugserver/Apple Silicon] Handoff connections when attaching to translated… (authored by davide).
[debugserver/Apple Silicon] Handoff connections when attaching to translated…
Thu, Jul 30, 4:21 PM
davide accepted D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Reviewed by Jason privately.

Thu, Jul 30, 4:20 PM
davide updated the diff for D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Added the check that Jason requested.

Thu, Jul 30, 4:07 PM

Tue, Jul 28

davide added a comment to D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef.

Florian, can you take a look?

Tue, Jul 28, 12:35 PM · Restricted Project, Restricted Project

Wed, Jul 22

davide requested changes to D84272: Add checks for ValueObjectSP in Cocoa summary providers.

why? Do you have a testcase?

Wed, Jul 22, 4:33 PM · Restricted Project
davide accepted D84333: build: always add support for assembly targets on Darwin.
Wed, Jul 22, 2:57 PM · Restricted Project
davide added a comment to D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

yeah, I think it's reasonable.

Wed, Jul 22, 12:45 PM

Tue, Jul 21

davide created D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.
Tue, Jul 21, 12:16 PM

Mon, Jul 20

davide committed rGb1a6d373d5e0: [PlatformMacOSX] Remove unused variable. NFC. (authored by davide).
[PlatformMacOSX] Remove unused variable. NFC.
Mon, Jul 20, 9:19 PM
davide committed rGcd05406b1053: [testsuite] Adapt lldb-server base test helper to run on arm64 (authored by davide).
[testsuite] Adapt lldb-server base test helper to run on arm64
Mon, Jul 20, 9:18 PM
davide committed rG001c8e1fd9f0: [PlatformDarwin] Add support for Apple Silicon. (authored by davide).
[PlatformDarwin] Add support for Apple Silicon.
Mon, Jul 20, 9:18 PM

Tue, Jul 14

davide committed rG61cf9f4e723b: [ObjectFilePECOFF] Try to avoid unaligned access. (authored by davide).
[ObjectFilePECOFF] Try to avoid unaligned access.
Tue, Jul 14, 6:53 PM
GitHub <noreply@github.com> committed rG6b2ea6155b2a: Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b… (authored by davide).
Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b…
Tue, Jul 14, 4:57 PM
GitHub <noreply@github.com> committed rG9d6a47061e5a: Merge pull request #1216 from dcci/bacini-bacetti (authored by davide).
Merge pull request #1216 from dcci/bacini-bacetti
Tue, Jul 14, 4:50 PM
davide committed rGd9df0a95abce: [arm64] Remove an old special case that's not needed anymore. (authored by davide).
[arm64] Remove an old special case that's not needed anymore.
Tue, Jul 14, 4:50 PM
davide committed rGe74c51648cde: [TestIndirectSymbol] This tests an Apple-specific feature. (authored by davide).
[TestIndirectSymbol] This tests an Apple-specific feature.
Tue, Jul 14, 4:50 PM
davide committed rG432ed54f2aad: [TestIndirectSymbols] This now runs and works on iOS (arm64). (authored by davide).
[TestIndirectSymbols] This now runs and works on iOS (arm64).
Tue, Jul 14, 4:50 PM
GitHub <noreply@github.com> committed rG49d1724deaee: Merge pull request #1143 from dcci/gisel-di-fixes (authored by davide).
Merge pull request #1143 from dcci/gisel-di-fixes
Tue, Jul 14, 4:48 PM
davide committed rGb560a12efc87: [GlobalISel] Assign the correct debug location when combining G_ANYEXT/G_ZEXT (authored by davide).
[GlobalISel] Assign the correct debug location when combining G_ANYEXT/G_ZEXT
Tue, Jul 14, 4:48 PM
davide committed rG68f608b0f70d: [GlobalISel] Remove debug locations when emitting constants. (authored by davide).
[GlobalISel] Remove debug locations when emitting constants.
Tue, Jul 14, 4:48 PM
GitHub <noreply@github.com> committed rG2675c47d6b92: Merge pull request #1085 from dcci/rdar61750950 (authored by davide).
Merge pull request #1085 from dcci/rdar61750950
Tue, Jul 14, 4:43 PM
davide committed rGec5d6803fa6e: [LICM] Try to merge debug locations when sinking. (authored by davide).
[LICM] Try to merge debug locations when sinking.
Tue, Jul 14, 4:43 PM
GitHub <noreply@github.com> committed rGd02ff1a07a63: Merge pull request #1044 from dcci/children-of-bodom (authored by davide).
Merge pull request #1044 from dcci/children-of-bodom
Tue, Jul 14, 4:40 PM
davide committed rG0b060b656b6f: [DWARF] Not all the constant variables are "static". (authored by davide).
[DWARF] Not all the constant variables are "static".
Tue, Jul 14, 4:40 PM
davide committed rGeab0476dead4: [ManualDWARFIndex] Remove dead code, in preparation for moving this function. (authored by davide).
[ManualDWARFIndex] Remove dead code, in preparation for moving this function.
Tue, Jul 14, 4:40 PM
davide committed rG45090b212f08: [MachineCSE] Don't carry the wrong location when hoisting (authored by davide).
[MachineCSE] Don't carry the wrong location when hoisting
Tue, Jul 14, 4:39 PM
GitHub <noreply@github.com> committed rG30511ca94344: Merge pull request #1036 from dcci/machine-cse (authored by davide).
Merge pull request #1036 from dcci/machine-cse
Tue, Jul 14, 4:39 PM
GitHub <noreply@github.com> committed rG7c1258ea4a12: Merge pull request #1008 from dcci/father-i-need-help (authored by davide).
Merge pull request #1008 from dcci/father-i-need-help
Tue, Jul 14, 4:38 PM
davide committed rG6676c3a90de3: [debugserver/ARM64] Make sure watchpoints hit are attributed correctly. (authored by davide).
[debugserver/ARM64] Make sure watchpoints hit are attributed correctly.
Tue, Jul 14, 4:38 PM
GitHub <noreply@github.com> committed rG7bc1819d9e73: Merge pull request #969 from dcci/think-about-yourself (authored by davide).
Merge pull request #969 from dcci/think-about-yourself
Tue, Jul 14, 4:37 PM
davide committed rG0b4d1868d76f: [Darwin] Add another hint to find the kernel. NFC. (authored by davide).
[Darwin] Add another hint to find the kernel. NFC.
Tue, Jul 14, 4:37 PM
GitHub <noreply@github.com> committed rG3b805237e66f: Merge pull request #956 from dcci/dirt-by-alice-in-chains (authored by davide).
Merge pull request #956 from dcci/dirt-by-alice-in-chains
Tue, Jul 14, 4:36 PM
davide committed rG70cfcc8c0d8e: [StopHook] Use wildcard matching. Pointed out by Jim Ingham. (authored by davide).
[StopHook] Use wildcard matching. Pointed out by Jim Ingham.
Tue, Jul 14, 4:36 PM
davide committed rG9207e4a85428: [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved. (authored by davide).
[AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.
Tue, Jul 14, 4:36 PM
davide committed rG3b0da7e1ba1c: [ObjC] Dynamic type resolution logging should go to the types log. (authored by davide).
[ObjC] Dynamic type resolution logging should go to the types log.
Tue, Jul 14, 4:36 PM
davide committed rGabc6cf3f0c81: [AppleObjCRuntimeV2] Rewrite GetClassDescriptor, reducing indentation. (authored by davide).
[AppleObjCRuntimeV2] Rewrite GetClassDescriptor, reducing indentation.
Tue, Jul 14, 4:36 PM
GitHub <noreply@github.com> committed rG33120c870899: Merge pull request #885 from dcci/friday-im-in-love (authored by davide).
Merge pull request #885 from dcci/friday-im-in-love
Tue, Jul 14, 4:32 PM
davide committed rG3f9f76bff87c: [ObjectFileMachO] Fix a build error on embedded. (authored by davide).
[ObjectFileMachO] Fix a build error on embedded.
Tue, Jul 14, 4:32 PM
GitHub <noreply@github.com> committed rGdf4a102e327b: Merge pull request #629 from dcci/bowie-birthday-device (authored by davide).
Merge pull request #629 from dcci/bowie-birthday-device
Tue, Jul 14, 4:15 PM
davide committed rG9752a615d1ce: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly. (authored by davide).
[FastISel] Lower `llvm.dbg.value(undef, ...` correctly.
Tue, Jul 14, 4:15 PM
davide committed rG42a65e87ac66: [TestQuoting] Use the fully qualified path for remote platforms. (authored by davide).
[TestQuoting] Use the fully qualified path for remote platforms.
Tue, Jul 14, 4:15 PM
GitHub <noreply@github.com> committed rG1abba77e240d: Merge pull request #632 from dcci/nana-supergirl-new-birthday (authored by davide).
Merge pull request #632 from dcci/nana-supergirl-new-birthday
Tue, Jul 14, 4:15 PM
davide committed rG03b77e974ffe: [TestStdModuleSysroot] Only run locally. (authored by davide).
[TestStdModuleSysroot] Only run locally.
Tue, Jul 14, 4:15 PM
davide committed rG3f2d880a9329: [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR… (authored by davide).
[ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR…
Tue, Jul 14, 11:26 AM
davide closed D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations.
Tue, Jul 14, 11:26 AM · Restricted Project
davide created D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations.
Tue, Jul 14, 11:13 AM · Restricted Project
davide accepted D83217: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast value.
Tue, Jul 14, 9:16 AM · Restricted Project

Mon, Jul 13

davide added a comment to D82817: [llvm] Native size estimator for training -Oz inliner.

Tried repro-ing this on a macosx.

cmake -GNinja -DLLVM_ENABLE_MODULES=On -DCMAKE_BUILD_TYPE=Release ../llvm

ninja opt

I got a warning - missing submodule 'LLVM_Analysis.InlineSizeEstimatorAnalysis' - but no error.

Could you please point me to the specific bot, I'm probably missing something else in the cmake config - thanks!

This broke the modules build.

In file included from <module-includes>:109:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Analysis/Utils/TFUtils.h:12:10: fatal error: 'tensorflow/c/c_api.h' file not found
#include "tensorflow/c/c_api.h"
         ^~~~~~~~~~~~~~~~~~~~~~
While building module 'LLVM_Backend' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/BranchFolding.h:14:
In file included from <module-includes>:3:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/AntiDepBreaker.h:20:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/ScheduleDAG.h:24:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/TargetLowering.h:34:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:32:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachineFunction.h:27:10: fatal error: could not build module 'LLVM_Analysis'
#include "llvm/Analysis/EHPersonalities.h"
 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To reproduce, pass -DLLVM_ENABLE_MODULES=On. Please let me know if you need anything else to repro.

In the meanwhile, reverted this in:

commit 9908a3b9f521c954cbf6adcec35b14b2f6c8da49 (HEAD -> master, origin/master, origin/HEAD)
Author: Davide Italiano <ditaliano@apple.com>
Date:   Mon Jul 13 12:59:16 2020 -0700

    Revert "[llvm] Native size estimator for training -Oz inliner"
    
    This reverts commit 83080a294ad7d145d758821bcf4354ad0cb7d299 as
    it breaks the macOS modules build.
Mon, Jul 13, 3:21 PM · Restricted Project
davide added a comment to D82817: [llvm] Native size estimator for training -Oz inliner.

This broke the modules build.

Mon, Jul 13, 1:15 PM · Restricted Project
davide committed rG9908a3b9f521: Revert "[llvm] Native size estimator for training -Oz inliner" (authored by davide).
Revert "[llvm] Native size estimator for training -Oz inliner"
Mon, Jul 13, 1:14 PM
davide added a reverting change for rG83080a294ad7: [llvm] Native size estimator for training -Oz inliner: rG9908a3b9f521: Revert "[llvm] Native size estimator for training -Oz inliner".
Mon, Jul 13, 1:14 PM

Fri, Jul 10

davide accepted D83600: Add a decorator to skip tests when running under Rosetta.

Good, one minor suggestion.

Fri, Jul 10, 8:12 PM · Restricted Project
davide accepted D83582: Fix nesting of #ifdef.

LGTM

Fri, Jul 10, 12:46 PM · Restricted Project
davide added a comment to D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes.

Reverted in:

Fri, Jul 10, 11:19 AM · Restricted Project
davide committed rGfdb7856d54a1: Revert "[NFC] Derive from PassInfoMixin for no-op/printing passes" (authored by davide).
Revert "[NFC] Derive from PassInfoMixin for no-op/printing passes"
Fri, Jul 10, 11:19 AM
davide added a reverting change for rG8039d2c3bf14: [NFC] Derive from PassInfoMixin for no-op/printing passes: rGfdb7856d54a1: Revert "[NFC] Derive from PassInfoMixin for no-op/printing passes".
Fri, Jul 10, 11:19 AM
davide added a comment to D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes.

on any recent'ish macOS (although, I don't think the OS quite matters)

Fri, Jul 10, 11:18 AM · Restricted Project
davide added a comment to D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes.

This broke the modules build on macOS.

Fri, Jul 10, 11:17 AM · Restricted Project

Jul 8 2020

davide added a comment to D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true).

This broke macOS:

Jul 8 2020, 1:11 PM · Restricted Project
davide added a reverting change for rG695b33a56919: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true): rG27d52cd86a2c: Revert "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment….
Jul 8 2020, 1:09 PM
davide committed rG27d52cd86a2c: Revert "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment… (authored by davide).
Revert "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment…
Jul 8 2020, 1:09 PM

Jul 7 2020

davide committed rG4dba3f4e030a: [dotest] Log a warning when --server and --out-of-tree-debugserver are set (authored by davide).
[dotest] Log a warning when --server and --out-of-tree-debugserver are set
Jul 7 2020, 3:03 PM
davide committed rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide).
Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.
Jul 7 2020, 3:01 PM
davide closed D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed..
Jul 7 2020, 3:01 PM · Restricted Project
davide added a comment to D83327: [lldb/Core] Fix incomplete type variable dereferencing crash..

Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are we calling this code _at all_ if the type is incomplete?

Doing so allows one to write a synthetic child provider that provides the fields for an incomplete type. This is useful if you don't have debug info for a given type but know its layouts by some other means.

Jul 7 2020, 11:21 AM · Restricted Project
davide added a comment to D83327: [lldb/Core] Fix incomplete type variable dereferencing crash..

Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are we calling this code _at all_ if the type is incomplete?

Jul 7 2020, 10:50 AM · Restricted Project

Jul 1 2020

davide abandoned D35142: WIP! [CFG] Create a new removeUnreachable utility that updates the dom in place.

Cleaning up my queue.

Jul 1 2020, 4:13 PM
davide abandoned D43048: [lldb-test/WIP] Allow a way to test autocompletion.

Cleaning up my queue.

Jul 1 2020, 4:13 PM
davide abandoned D28177: [SCCP] Integrate `undef` in the solver.
Jul 1 2020, 4:13 PM
davide updated subscribers of D28177: [SCCP] Integrate `undef` in the solver.

This is ancient history. Florian (@fhahn) did a bunch of work in the area and can probably pick some of this up if he wants to.

Jul 1 2020, 4:13 PM

Jun 30 2020

davide committed rG983a4b520ea3: Skip arm-(fp|gp)-read.test on Darwin. (authored by davide).
Skip arm-(fp|gp)-read.test on Darwin.
Jun 30 2020, 1:05 PM
davide committed rG4f1f253ce509: [TestReturnValue] Skip based on architecutre, not platform. (authored by davide).
[TestReturnValue] Skip based on architecutre, not platform.
Jun 30 2020, 1:04 PM
davide added inline comments to D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.
Jun 30 2020, 10:50 AM
davide accepted D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb.

Thanks.

Jun 30 2020, 10:49 AM · Restricted Project

Jun 29 2020

davide added inline comments to D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.
Jun 29 2020, 8:24 PM
davide added inline comments to D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed..
Jun 29 2020, 3:18 PM · Restricted Project
davide updated the diff for D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.
Jun 29 2020, 3:00 PM
davide added inline comments to D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.
Jun 29 2020, 2:59 PM
davide added inline comments to D82491: [Apple Silicon] Initial support for Rosetta.
Jun 29 2020, 2:59 PM
davide created D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.
Jun 29 2020, 2:58 PM
davide created D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed..
Jun 29 2020, 2:12 PM · Restricted Project
davide committed rG300bbbcb707a: [ProcessGDBRemote] Get rid of an unused function. (authored by davide).
[ProcessGDBRemote] Get rid of an unused function.
Jun 29 2020, 1:02 PM

Jun 25 2020

davide committed rGc7eb06a88052: [test] XFail TestStepNoDebug based on arch rather than OS (authored by davide).
[test] XFail TestStepNoDebug based on arch rather than OS
Jun 25 2020, 4:24 PM
davide committed rG38135b2a7fff: [test] XFail TestSigtrampUnwind based on arch rather than OS (authored by davide).
[test] XFail TestSigtrampUnwind based on arch rather than OS
Jun 25 2020, 4:24 PM
davide committed rG0df7be234412: [lldb/test] XFAIL TestHWBreakMultiThread on arch rather platform. (authored by davide).
[lldb/test] XFAIL TestHWBreakMultiThread on arch rather platform.
Jun 25 2020, 4:24 PM
davide committed rGd358ec463943: [lldb/test] Skip TestBreakpointThumbCodesection on arm64. (authored by davide).
[lldb/test] Skip TestBreakpointThumbCodesection on arm64.
Jun 25 2020, 4:24 PM

Jun 24 2020

davide committed rG2010444e5e5f: [Apple Silicon] Handle macOS in PlatformDarwin (authored by davide).
[Apple Silicon] Handle macOS in PlatformDarwin
Jun 24 2020, 4:53 PM
davide committed rG47ac45332e25: [HostInfoMacOS] Parse correctly the triple for Apple Silicon. (authored by davide).
[HostInfoMacOS] Parse correctly the triple for Apple Silicon.
Jun 24 2020, 4:52 PM
davide committed rG58de2a385139: [ProcessGDBRemote] Placate the Windows buildbot. (authored by davide).
[ProcessGDBRemote] Placate the Windows buildbot.
Jun 24 2020, 1:35 PM
davide committed rGb4fdddf971b1: [Apple Silicon] Debugging of process under Rosetta is supported. (authored by davide).
[Apple Silicon] Debugging of process under Rosetta is supported.
Jun 24 2020, 1:02 PM
davide created D82495: [Apple Silicon] Support attach by name correctly for Rosetta..
Jun 24 2020, 1:01 PM