Page MenuHomePhabricator

davide (Davide Italiano)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 1:58 PM (367 w, 3 d)

Recent Activity

Mon, Nov 8

davide requested review of D113456: Allow protocol metadata to be deduplicated within dylibs.
Mon, Nov 8, 9:44 PM · Restricted Project

Oct 22 2021

davide added a comment to D112124: [ThinLTO] Append original object file name to ThinLTO generated object file's name, so that it can be recorded in link map file..

The best solution might still be the linker to map the intermediate file to the original object file since the added file name here is still another level of indirection you need to figure out. @davide for his opinion.

Oct 22 2021, 10:46 AM · Restricted Project

Aug 6 2021

davide committed rG5b9a94414eb9: [MachO] Introduce chained fixups related load commands. (authored by davide).
[MachO] Introduce chained fixups related load commands.
Aug 6 2021, 12:38 PM

May 19 2021

davide removed a reviewer for D93838: [SCCP] Add Function Specialization pass: davide.
May 19 2021, 10:33 AM · Restricted Project

Apr 27 2021

davide edited reviewers for D100322: [ConstantMerge] Don't merge thread_local constants with non-thread_local constants, added: fhahn; removed: davide.
Apr 27 2021, 11:10 PM · Restricted Project

Apr 20 2021

davide removed a reviewer for D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529): davide.
Apr 20 2021, 11:55 AM · Restricted Project

Mar 22 2021

davide added a comment to D99105: [lld-macho] LTO: Unset VisibleToRegularObj where possible.

removing davide
+ steven

Mar 22 2021, 12:50 PM · Restricted Project, Restricted Project
davide edited reviewers for D99105: [lld-macho] LTO: Unset VisibleToRegularObj where possible, added: steven_wu; removed: davide.
Mar 22 2021, 12:50 PM · Restricted Project, Restricted Project

Mar 17 2021

davide accepted D98739: [Object][MachO] Handle end iterator in getSymbolType().

Sure.

Mar 17 2021, 12:37 PM · Restricted Project

Mar 11 2021

davide added a comment to D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

+ Lang, who probably has a better understanding of this, for visibility.
I don't think this should be blocked further, but he might have a chance to comment.

Mar 11 2021, 3:40 PM · Restricted Project
davide added a reviewer for D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue": lhames.
Mar 11 2021, 3:40 PM · Restricted Project
davide accepted D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

LGTM.

Mar 11 2021, 3:39 PM · Restricted Project
davide added a comment to D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue".

Mach-O doesn't support dso_local and this change broke XNU because of the use of dso_local.

Can you elaborate on the unsupportness? For example, the backend can ignore dso_local if it does not want to support it.

The main purpose is to reduce target differences: currently both COFF and ELF can use dso_local. If Mach-O doesn't like dso_local, there is an additional difference.

Mar 11 2021, 3:39 PM · Restricted Project

Feb 26 2021

davide removed a reviewer for D85770: Build a flat LLDB.framework for embedded Darwin targets: davide.
Feb 26 2021, 5:34 PM · Unknown Object (Project)

Jan 11 2021

davide removed a reviewer for D94448: [NewPM] Run non-trivial loop unswitching under -O2/3/s/z: davide.
Jan 11 2021, 1:59 PM · Restricted Project

Dec 7 2020

davide removed a reviewer for D92488: [LICM] Add a maximum for the number of instructions to be hoisted: davide.
Dec 7 2020, 11:22 AM · Restricted Project

Dec 1 2020

davide added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

I apologize, but I don't work on this anymore.

Dec 1 2020, 2:26 PM · Restricted Project
davide removed a reviewer for D92431: [SROA] Remove Dead Instructions while creating speculative instructions: davide.
Dec 1 2020, 2:25 PM · Restricted Project

Oct 23 2020

davide removed a reviewer for D78972: Treat hasWeakODRLinkage symbols as external in REPL computations: davide.
Oct 23 2020, 3:12 PM · Unknown Object (Project)

Oct 12 2020

davide added a comment to D88468: [llvm-readobj] Don't print out section names for STABS symbols.

I'm sorry, I haven't touched this code in a long time and I don't feel qualified to review it.

Oct 12 2020, 2:23 PM · Restricted Project
davide removed a reviewer for D88468: [llvm-readobj] Don't print out section names for STABS symbols: davide.
Oct 12 2020, 2:23 PM · Restricted Project

Sep 21 2020

davide closed D88061: [Testsuite] allow a linker to be specified.
Sep 21 2020, 6:06 PM
davide added a comment to D88061: [Testsuite] allow a linker to be specified.

Committed thusly

Sep 21 2020, 6:06 PM
davide requested review of D88061: [Testsuite] allow a linker to be specified.
Sep 21 2020, 5:57 PM

Sep 14 2020

davide committed rG26c293c23d3b: [BinaryFormat/MachO] Add a missing constant. (authored by davide).
[BinaryFormat/MachO] Add a missing constant.
Sep 14 2020, 10:31 PM

Sep 3 2020

davide abandoned D82495: [Apple Silicon] Support attach by name correctly for Rosetta..

This landed in a different form.

Sep 3 2020, 12:51 PM
davide closed D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files.

Somebody will pick this up, probably in a different form.

Sep 3 2020, 12:51 PM
davide abandoned D80602: [BranchFolding] Drop location when hoisting.

I won't have time to look at this in the future.

Sep 3 2020, 12:51 PM · Restricted Project

Aug 27 2020

davide accepted D86722: [lldb] Make lldb-argdumper a dependency of liblldb.
Aug 27 2020, 9:21 AM · Unknown Object (Project)

Aug 24 2020

davide added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:26 AM · Unknown Object (Project)
davide updated subscribers of D86436: [lldb] Fix Type::GetByteSize for pointer types.

@labath something I noticed when finding this (and related bugs) is that frame var carries a decent diagnostic

Aug 24 2020, 10:23 AM · Unknown Object (Project)
davide added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:15 AM · Unknown Object (Project)
davide accepted D86436: [lldb] Fix Type::GetByteSize for pointer types.

I came to the same conclusion when analyzing https://bugs.llvm.org/show_bug.cgi?id=47257 (but you beat me to the punch).

Aug 24 2020, 9:26 AM · Unknown Object (Project)

Aug 21 2020

davide added a comment to D86337: Remove raw_sha1_ostream.

I think this is fine. @mehdi_amini ?

Aug 21 2020, 10:48 AM · Restricted Project
davide accepted D86338: Remove TaskQueue.
Aug 21 2020, 10:47 AM · Restricted Project

Aug 14 2020

davide committed rG0cceb54366b4: [TestPtrRefsObjC] Prefer `command script import`. (authored by davide).
[TestPtrRefsObjC] Prefer `command script import`.
Aug 14 2020, 3:31 PM
davide committed rG8fcfe2862fd4: [TestPtrRefs] Prefer `command script import`. (authored by davide).
[TestPtrRefs] Prefer `command script import`.
Aug 14 2020, 3:31 PM

Aug 11 2020

davide added a reviewer for D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.: vsk.
Aug 11 2020, 11:04 AM · Restricted Project, Unknown Object (Project)

Aug 5 2020

davide added a comment to D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

auto_ptr is deprecated since C++11 and will be removed in C++17.

Aug 5 2020, 10:28 PM · Unknown Object (Project)
davide accepted D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

This is correct to the best of my understanding. Thank you Jason.

Aug 5 2020, 10:04 PM · Unknown Object (Project)
davide accepted D85388: [lldb] Fix bug in skipIfRosetta decorator.

yes, this makes sense. We could refine the check in future.

Aug 5 2020, 8:48 PM · Unknown Object (Project)
davide added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 5 2020, 6:00 PM · Unknown Object (Project)
davide requested changes to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 5 2020, 5:58 PM · Unknown Object (Project)
davide added inline comments to D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary.
Aug 5 2020, 4:08 PM · Unknown Object (Project)
davide accepted D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests..

I assume we're still allowing to put the decorator on a test-by-test basis, and that seems the case from what I see.
If so, LG.

Aug 5 2020, 3:19 PM · Unknown Object (Project)

Aug 4 2020

davide accepted D85172: Teach SROA to handle allocas with more than one dbg.declare..

LGTM with Saleem's comment addressed.

Aug 4 2020, 1:52 PM · Restricted Project, debug-info

Aug 3 2020

davide closed D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7

Aug 3 2020, 3:43 PM

Jul 30 2020

davide committed rG57605758b5de: [debugserver/Apple Silicon] Handoff connections when attaching to translated… (authored by davide).
[debugserver/Apple Silicon] Handoff connections when attaching to translated…
Jul 30 2020, 4:21 PM
davide accepted D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Reviewed by Jason privately.

Jul 30 2020, 4:20 PM
davide updated the diff for D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

Added the check that Jason requested.

Jul 30 2020, 4:07 PM

Jul 28 2020

davide added a comment to D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef.

Florian, can you take a look?

Jul 28 2020, 12:35 PM · Restricted Project, Restricted Project

Jul 22 2020

davide requested changes to D84272: Add checks for ValueObjectSP in Cocoa summary providers.

why? Do you have a testcase?

Jul 22 2020, 4:33 PM · Unknown Object (Project)
davide accepted D84333: build: always add support for assembly targets on Darwin.
Jul 22 2020, 2:57 PM · Restricted Project
davide added a comment to D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

yeah, I think it's reasonable.

Jul 22 2020, 12:45 PM

Jul 21 2020

davide created D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.
Jul 21 2020, 12:16 PM

Jul 20 2020

davide committed rGb1a6d373d5e0: [PlatformMacOSX] Remove unused variable. NFC. (authored by davide).
[PlatformMacOSX] Remove unused variable. NFC.
Jul 20 2020, 9:19 PM
davide committed rGcd05406b1053: [testsuite] Adapt lldb-server base test helper to run on arm64 (authored by davide).
[testsuite] Adapt lldb-server base test helper to run on arm64
Jul 20 2020, 9:18 PM
davide committed rG001c8e1fd9f0: [PlatformDarwin] Add support for Apple Silicon. (authored by davide).
[PlatformDarwin] Add support for Apple Silicon.
Jul 20 2020, 9:18 PM

Jul 14 2020

davide committed rG61cf9f4e723b: [ObjectFilePECOFF] Try to avoid unaligned access. (authored by davide).
[ObjectFilePECOFF] Try to avoid unaligned access.
Jul 14 2020, 6:53 PM
GitHub <noreply@github.com> committed rG6b2ea6155b2a: Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b… (authored by davide).
Merge pull request #1426 from Teemperor/cherry/de0175d04bc3679c7bd8dc64520e790b…
Jul 14 2020, 4:57 PM
GitHub <noreply@github.com> committed rG9d6a47061e5a: Merge pull request #1216 from dcci/bacini-bacetti (authored by davide).
Merge pull request #1216 from dcci/bacini-bacetti
Jul 14 2020, 4:50 PM
davide committed rGd9df0a95abce: [arm64] Remove an old special case that's not needed anymore. (authored by davide).
[arm64] Remove an old special case that's not needed anymore.
Jul 14 2020, 4:50 PM
davide committed rGe74c51648cde: [TestIndirectSymbol] This tests an Apple-specific feature. (authored by davide).
[TestIndirectSymbol] This tests an Apple-specific feature.
Jul 14 2020, 4:50 PM
davide committed rG432ed54f2aad: [TestIndirectSymbols] This now runs and works on iOS (arm64). (authored by davide).
[TestIndirectSymbols] This now runs and works on iOS (arm64).
Jul 14 2020, 4:50 PM
GitHub <noreply@github.com> committed rG49d1724deaee: Merge pull request #1143 from dcci/gisel-di-fixes (authored by davide).
Merge pull request #1143 from dcci/gisel-di-fixes
Jul 14 2020, 4:48 PM
davide committed rGb560a12efc87: [GlobalISel] Assign the correct debug location when combining G_ANYEXT/G_ZEXT (authored by davide).
[GlobalISel] Assign the correct debug location when combining G_ANYEXT/G_ZEXT
Jul 14 2020, 4:48 PM
davide committed rG68f608b0f70d: [GlobalISel] Remove debug locations when emitting constants. (authored by davide).
[GlobalISel] Remove debug locations when emitting constants.
Jul 14 2020, 4:48 PM
GitHub <noreply@github.com> committed rG2675c47d6b92: Merge pull request #1085 from dcci/rdar61750950 (authored by davide).
Merge pull request #1085 from dcci/rdar61750950
Jul 14 2020, 4:43 PM
davide committed rGec5d6803fa6e: [LICM] Try to merge debug locations when sinking. (authored by davide).
[LICM] Try to merge debug locations when sinking.
Jul 14 2020, 4:43 PM
GitHub <noreply@github.com> committed rGd02ff1a07a63: Merge pull request #1044 from dcci/children-of-bodom (authored by davide).
Merge pull request #1044 from dcci/children-of-bodom
Jul 14 2020, 4:40 PM
davide committed rG0b060b656b6f: [DWARF] Not all the constant variables are "static". (authored by davide).
[DWARF] Not all the constant variables are "static".
Jul 14 2020, 4:40 PM
davide committed rGeab0476dead4: [ManualDWARFIndex] Remove dead code, in preparation for moving this function. (authored by davide).
[ManualDWARFIndex] Remove dead code, in preparation for moving this function.
Jul 14 2020, 4:40 PM
davide committed rG45090b212f08: [MachineCSE] Don't carry the wrong location when hoisting (authored by davide).
[MachineCSE] Don't carry the wrong location when hoisting
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rG30511ca94344: Merge pull request #1036 from dcci/machine-cse (authored by davide).
Merge pull request #1036 from dcci/machine-cse
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rG7c1258ea4a12: Merge pull request #1008 from dcci/father-i-need-help (authored by davide).
Merge pull request #1008 from dcci/father-i-need-help
Jul 14 2020, 4:38 PM
davide committed rG6676c3a90de3: [debugserver/ARM64] Make sure watchpoints hit are attributed correctly. (authored by davide).
[debugserver/ARM64] Make sure watchpoints hit are attributed correctly.
Jul 14 2020, 4:38 PM
GitHub <noreply@github.com> committed rG7bc1819d9e73: Merge pull request #969 from dcci/think-about-yourself (authored by davide).
Merge pull request #969 from dcci/think-about-yourself
Jul 14 2020, 4:37 PM
davide committed rG0b4d1868d76f: [Darwin] Add another hint to find the kernel. NFC. (authored by davide).
[Darwin] Add another hint to find the kernel. NFC.
Jul 14 2020, 4:37 PM
GitHub <noreply@github.com> committed rG3b805237e66f: Merge pull request #956 from dcci/dirt-by-alice-in-chains (authored by davide).
Merge pull request #956 from dcci/dirt-by-alice-in-chains
Jul 14 2020, 4:36 PM
davide committed rG70cfcc8c0d8e: [StopHook] Use wildcard matching. Pointed out by Jim Ingham. (authored by davide).
[StopHook] Use wildcard matching. Pointed out by Jim Ingham.
Jul 14 2020, 4:36 PM
davide committed rG9207e4a85428: [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved. (authored by davide).
[AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.
Jul 14 2020, 4:36 PM
davide committed rG3b0da7e1ba1c: [ObjC] Dynamic type resolution logging should go to the types log. (authored by davide).
[ObjC] Dynamic type resolution logging should go to the types log.
Jul 14 2020, 4:36 PM
davide committed rGabc6cf3f0c81: [AppleObjCRuntimeV2] Rewrite GetClassDescriptor, reducing indentation. (authored by davide).
[AppleObjCRuntimeV2] Rewrite GetClassDescriptor, reducing indentation.
Jul 14 2020, 4:36 PM
GitHub <noreply@github.com> committed rG33120c870899: Merge pull request #885 from dcci/friday-im-in-love (authored by davide).
Merge pull request #885 from dcci/friday-im-in-love
Jul 14 2020, 4:32 PM
davide committed rG3f9f76bff87c: [ObjectFileMachO] Fix a build error on embedded. (authored by davide).
[ObjectFileMachO] Fix a build error on embedded.
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rGdf4a102e327b: Merge pull request #629 from dcci/bowie-birthday-device (authored by davide).
Merge pull request #629 from dcci/bowie-birthday-device
Jul 14 2020, 4:15 PM
davide committed rG9752a615d1ce: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly. (authored by davide).
[FastISel] Lower `llvm.dbg.value(undef, ...` correctly.
Jul 14 2020, 4:15 PM
davide committed rG42a65e87ac66: [TestQuoting] Use the fully qualified path for remote platforms. (authored by davide).
[TestQuoting] Use the fully qualified path for remote platforms.
Jul 14 2020, 4:15 PM
GitHub <noreply@github.com> committed rG1abba77e240d: Merge pull request #632 from dcci/nana-supergirl-new-birthday (authored by davide).
Merge pull request #632 from dcci/nana-supergirl-new-birthday
Jul 14 2020, 4:15 PM
davide committed rG03b77e974ffe: [TestStdModuleSysroot] Only run locally. (authored by davide).
[TestStdModuleSysroot] Only run locally.
Jul 14 2020, 4:15 PM
davide committed rG3f2d880a9329: [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR… (authored by davide).
[ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR…
Jul 14 2020, 11:26 AM
davide closed D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations.
Jul 14 2020, 11:26 AM · Unknown Object (Project)
davide created D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations.
Jul 14 2020, 11:13 AM · Unknown Object (Project)
davide accepted D83217: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast value.
Jul 14 2020, 9:16 AM · Unknown Object (Project)

Jul 13 2020

davide added a comment to D82817: [llvm] Native size estimator for training -Oz inliner.

Tried repro-ing this on a macosx.

cmake -GNinja -DLLVM_ENABLE_MODULES=On -DCMAKE_BUILD_TYPE=Release ../llvm

ninja opt

I got a warning - missing submodule 'LLVM_Analysis.InlineSizeEstimatorAnalysis' - but no error.

Could you please point me to the specific bot, I'm probably missing something else in the cmake config - thanks!

This broke the modules build.

In file included from <module-includes>:109:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Analysis/Utils/TFUtils.h:12:10: fatal error: 'tensorflow/c/c_api.h' file not found
#include "tensorflow/c/c_api.h"
         ^~~~~~~~~~~~~~~~~~~~~~
While building module 'LLVM_Backend' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/BranchFolding.h:14:
In file included from <module-includes>:3:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/AntiDepBreaker.h:20:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/ScheduleDAG.h:24:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/TargetLowering.h:34:
In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:32:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachineFunction.h:27:10: fatal error: could not build module 'LLVM_Analysis'
#include "llvm/Analysis/EHPersonalities.h"
 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To reproduce, pass -DLLVM_ENABLE_MODULES=On. Please let me know if you need anything else to repro.

In the meanwhile, reverted this in:

commit 9908a3b9f521c954cbf6adcec35b14b2f6c8da49 (HEAD -> master, origin/master, origin/HEAD)
Author: Davide Italiano <ditaliano@apple.com>
Date:   Mon Jul 13 12:59:16 2020 -0700

    Revert "[llvm] Native size estimator for training -Oz inliner"
    
    This reverts commit 83080a294ad7d145d758821bcf4354ad0cb7d299 as
    it breaks the macOS modules build.
Jul 13 2020, 3:21 PM · Restricted Project
davide added a comment to D82817: [llvm] Native size estimator for training -Oz inliner.

This broke the modules build.

Jul 13 2020, 1:15 PM · Restricted Project
davide committed rG9908a3b9f521: Revert "[llvm] Native size estimator for training -Oz inliner" (authored by davide).
Revert "[llvm] Native size estimator for training -Oz inliner"
Jul 13 2020, 1:14 PM
davide added a reverting change for rG83080a294ad7: [llvm] Native size estimator for training -Oz inliner: rG9908a3b9f521: Revert "[llvm] Native size estimator for training -Oz inliner".
Jul 13 2020, 1:14 PM

Jul 10 2020

davide accepted D83600: Add a decorator to skip tests when running under Rosetta.

Good, one minor suggestion.

Jul 10 2020, 8:12 PM · Unknown Object (Project)
davide accepted D83582: Fix nesting of #ifdef.

LGTM

Jul 10 2020, 12:46 PM · Restricted Project