This is an archive of the discontinued LLVM Phabricator instance.

Enable testing ASAN on AArch64
ClosedPublic

Authored by christophe.lyon on Jan 29 2015, 2:27 AM.

Download Raw Diff

Details

Reviewers

kcc
rengolin

Summary

This patch is related to http://reviews.llvm.org/D7243, and enables testing ASAN on AArch64.

When both patches are applied, I can see 2 failures in the testsuite:
Asan-aarch64-inline-Test/AddressSanitizer.BuiltinLongJmpTest
Asan-aarch64-with-calls-Test/AddressSanitizer.BuiltinLongJmpTest

I have tried to debug them, and I am not wondering if these tests should be skipped as on ARM, PowerPC.
As a matter of fact, I have extracted a sample program which does run when compiled with GCC, but loops & crashes when compiled with clang: maybe __builtin_longjmp is broken on AArch64 in Clang/LLVM?

Thanks.

Diff Detail

Event Timeline

christophe.lyon updated this revision to Diff 18942.Jan 29 2015, 2:27 AM

christophe.lyon retitled this revision from to Enable testing ASAN on AArch64.

christophe.lyon updated this object.

christophe.lyon edited the test plan for this revision. (Show Details)

christophe.lyon added reviewers: rengolin, kcc.

christophe.lyon added a subscriber: Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptJan 29 2015, 2:27 AM

Hi Christophe,

We don't care much for longjump on ARM/AArhc64, that's why I made them fail on ARM. I think the same reasoning apply to AArch64, so I'd be in favour of setting them XFAIL on aarch64, too.

However, I'd like to see that patch land in before this one, so we don't break the bots.

cheers,
--renato

christophe.lyon edited edge metadata.Jan 29 2015, 7:31 AM

Here is an update, with the offending longjmp test disabled on aarch64.

rengolin accepted this revision.Feb 3 2015, 3:28 AM

rengolin edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 3:28 AM

Committed in r227966.

Revision Contents

Path

Size

cmake/

config-ix.cmake

2 lines

lib/

asan/

tests/

asan_test.cc

3 lines

Diff 18968

cmake/config-ix.cmake

Context not available.
	filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH	filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH
	x86_64 i386 i686 powerpc64 powerpc64le arm aarch64 mips mips64 mipsel mips64el)	x86_64 i386 i686 powerpc64 powerpc64le arm aarch64 mips mips64 mipsel mips64el)
	filter_available_targets(ASAN_SUPPORTED_ARCH	filter_available_targets(ASAN_SUPPORTED_ARCH
	x86_64 i386 i686 powerpc64 powerpc64le arm mips mipsel mips64 mips64el)	x86_64 i386 i686 powerpc64 powerpc64le arm aarch64 mips mipsel mips64 mips64el)
	filter_available_targets(DFSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)	filter_available_targets(DFSAN_SUPPORTED_ARCH x86_64 mips64 mips64el)
	filter_available_targets(LSAN_SUPPORTED_ARCH x86_64)	filter_available_targets(LSAN_SUPPORTED_ARCH x86_64)
	# LSan common files should be available on all architectures supported	# LSan common files should be available on all architectures supported
Context not available.

lib/asan/tests/asan_test.cc

Context not available.
	}	}

	#if !defined(__ANDROID__) && !defined(__arm__) && \	#if !defined(__ANDROID__) && !defined(__arm__) && \
	!defined(__powerpc64__) && !defined(__powerpc__)	!defined(__powerpc64__) && !defined(__powerpc__) && \
		!defined(__aarch64__)
	// Does not work on Power and ARM:	// Does not work on Power and ARM:
	// https://code.google.com/p/address-sanitizer/issues/detail?id=185	// https://code.google.com/p/address-sanitizer/issues/detail?id=185
	TEST(AddressSanitizer, BuiltinLongJmpTest) {	TEST(AddressSanitizer, BuiltinLongJmpTest) {
Context not available.