This is an archive of the discontinued LLVM Phabricator instance.

Add AArch64 support to ASan instrumentation
ClosedPublic

Authored by christophe.lyon on Jan 29 2015, 2:21 AM.

Details

Reviewers
kcc
rengolin
Summary

Hi,

The attached patch adds AArch64 support to ASan instrumentation.
For the time being, it is still hardcoded to support only the 39 VA bits variant, I plan to work on supporting 42 and 48 VA bits variants, but I don't have access to such hardware at the moment.

I have another patch (for compiler-rt) to activate the tests (submitted separately).

Diff Detail

Event Timeline

christophe.lyon retitled this revision from to Add AArch64 support to ASan instrumentation.
christophe.lyon updated this object.
christophe.lyon edited the test plan for this revision. (Show Details)
christophe.lyon added reviewers: rengolin, kcc.
christophe.lyon added a subscriber: Unknown Object (MLST).Jan 29 2015, 2:22 AM
kcc accepted this revision.Jan 29 2015, 10:03 AM
kcc edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Jan 29 2015, 10:03 AM
rengolin closed this revision.Feb 3 2015, 3:22 AM
rengolin edited edge metadata.

Committed in r227965

Thank you Renato for committing on my behalf.

Kostya, Renato, is my other request OK? (http://reviews.llvm.org/D7244)
It enables testing ASAN on AArch64.

Thanks.

Yes, I just committed. Keep an eye on the bot:

http://lab.llvm.org:8011/builders/clang-native-aarch64-full

Right now it's failing on Clang, but it shouldn't fail on RT as well.

cheers,
--renato