This is an archive of the discontinued LLVM Phabricator instance.

Differential D7044

GNU LD option export-dynamic can accept single dash flag
ClosedPublic

Authored by davide on Jan 18 2015, 2:28 PM.

Details

Reviewers
rafaelauler
ruiu
Commits
rGbf2625d42b6c: GNU LD option export-dynamic can accept single dash flag.
rLLD227631: GNU LD option export-dynamic can accept single dash flag.
Summary

Some Makefiles on FreeBSD use -export-dynamic rather than --export-dynamic.
We're gonna patch them in the FreeBSD tree, but as long as this is supposed to be a drop-in replacement for GNU ld, I think supporting single dash flag is fine.

Diff Detail

Event Timeline

davide updated this revision to Diff 18361.Jan 18 2015, 2:28 PM
davide retitled this revision from to GNU LD option export-dynamic can accept single dash flag .
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added reviewers: rui314, rafaelauler.
davide added a project: lld.
davide added subscribers: emaste, Unknown Object (MLST).
ruiu edited reviewers, added: ruiu; removed: rui314.Jan 18 2015, 2:42 PM
ruiu accepted this revision.Jan 18 2015, 2:44 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 18 2015, 2:44 PM
davide mentioned this in rL227631: GNU LD option export-dynamic can accept single dash flag..Jan 30 2015, 2:58 PM
davide closed this revision.Feb 1 2015, 10:30 PM

Revision Contents

PathSize
lib/
Driver/
2 lines

Diff 18361

lib/Driver/GnuLdOptions.td

Context not available.
def rpath_link : Separate<["-"], "rpath-link">, def rpath_link : Separate<["-"], "rpath-link">,
HelpText<"Specifies the first set of directories to search">, HelpText<"Specifies the first set of directories to search">,
Group<grp_dynlibexec>; Group<grp_dynlibexec>;
def export_dynamic : Flag<["--"], "export-dynamic">, def export_dynamic : Flag<["-", "--"], "export-dynamic">,
HelpText<"Add all symbols to the dynamic symbol table" HelpText<"Add all symbols to the dynamic symbol table"
" when creating executables">, " when creating executables">,
Group<grp_main>; Group<grp_main>;
Context not available.