This is an archive of the discontinued LLVM Phabricator instance.

Merge the directive-eabi_attribute.s and directive-eabi_attribute-2.s tests.
ClosedPublic

Authored by chatur01 on Oct 29 2014, 2:41 AM.

Details

Reviewers
rengolin
Summary

test/MC/ARM/directive-eabi_attribute.s had gotten out-of-sync with test/MC/ARM/directive-eabi_attribute-2.s. The former tests the encoding of build attributes in object files, and the latter the encoding in assembly files. Since both these tests need to be updated at the same time, it makes sense to combine them into a single test. The object file encodings are being checked against the ouput of -arm-attributes rather than by direct byte comparisons which makes for easier reading.

Diff Detail

Event Timeline

chatur01 retitled this revision from to Update the directive-eabi_attribute tests..
chatur01 updated this object.
chatur01 edited the test plan for this revision. (Show Details)
chatur01 set the repository for this revision to rL LLVM.
chatur01 added a subscriber: Unknown Object (MLST).

Hi Charlie,

A couple of suggestions:

test/MC/ARM/directive-eabi_attribute-2.s
2–3

I think it'd be better to combine these two files, if the input needs to be identical in each. You can run separate commands and use different FileCheck prefixes for the asm vs the text output.

test/MC/ARM/directive-eabi_attribute.s
13

If you can change this without the test breaking, it probably has limited value.

chatur01 retitled this revision from Update the directive-eabi_attribute tests. to Merge the directive-eabi_attribute.s and directive-eabi_attribute-2.s tests..
chatur01 updated this object.
chatur01 set the repository for this revision to rL LLVM.

I have merged the directive-eabi_attribute.s and directive-eabi_attribute-2.s tests into a single test. I thought I should add the extra object file tests from the previous differential revision as a separate patch.

rengolin added inline comments.
test/MC/ARM/directive-eabi_attribute.s
3

You can use

llvm-readobj -arm-attributes

That'll give you a better textual output and a more expressive test to CHECK on.

chatur01 updated this object.
chatur01 added a reviewer: rengolin.

Update the object file test to check against the output of the -arm-attributes flag to llvm-readobj rather performing byte comparisons.

Use of the arm-attributes flag was suggested by Renato.

Thanks for the review Renato!

rengolin accepted this revision.Nov 3 2014, 6:51 AM
rengolin edited edge metadata.

Hi Charlie,

LGTM, thanks!

cheers,
--renato

This revision is now accepted and ready to land.Nov 3 2014, 6:51 AM
rengolin closed this revision.Mar 10 2015, 6:01 AM