test/MC/ARM/directive-eabi_attribute.s had gotten out-of-sync with test/MC/ARM/directive-eabi_attribute-2.s. The former tests the encoding of build attributes in object files, and the latter the encoding in assembly files. Since both these tests need to be updated at the same time, it makes sense to combine them into a single test. The object file encodings are being checked against the ouput of -arm-attributes rather than by direct byte comparisons which makes for easier reading.
Details
Diff Detail
Event Timeline
Hi Charlie,
A couple of suggestions:
test/MC/ARM/directive-eabi_attribute-2.s | ||
---|---|---|
2–3 | I think it'd be better to combine these two files, if the input needs to be identical in each. You can run separate commands and use different FileCheck prefixes for the asm vs the text output. | |
test/MC/ARM/directive-eabi_attribute.s | ||
13 | If you can change this without the test breaking, it probably has limited value. |
I have merged the directive-eabi_attribute.s and directive-eabi_attribute-2.s tests into a single test. I thought I should add the extra object file tests from the previous differential revision as a separate patch.
test/MC/ARM/directive-eabi_attribute.s | ||
---|---|---|
3 | You can use llvm-readobj -arm-attributes That'll give you a better textual output and a more expressive test to CHECK on. |
Update the object file test to check against the output of the -arm-attributes flag to llvm-readobj rather performing byte comparisons.
Use of the arm-attributes flag was suggested by Renato.
Thanks for the review Renato!
You can use
That'll give you a better textual output and a more expressive test to CHECK on.