This is an archive of the discontinued LLVM Phabricator instance.

[opaque pointer types] Pass function types to InvokeInst creation.
ClosedPublic

Authored by jyknight on Jan 24 2019, 10:54 AM.

Details

Summary

This cleans up all InvokeInst creation in LLVM to explicitly pass a
function type rather than deriving it from the pointer's element-type.

Event Timeline

jyknight created this revision.Jan 24 2019, 10:54 AM
dblaikie accepted this revision.Jan 24 2019, 1:20 PM

Looks good!

(same question as the CallInst::Create version - is it worth having an overload that does take a Function and derives the function type from that?)

This revision is now accepted and ready to land.Jan 24 2019, 1:20 PM
jyknight updated this revision to Diff 183797.Jan 27 2019, 8:49 PM

Update after creating FunctionCallee in D57315.

(ah, I assume you're just waiting to commit the FunctionCallee refactoring before committing these (this one as well as D57173 and D57174), and you don't need another review/sign off on the updates/rebase? I'm certainly fine with that)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 12:43 PM