This is an archive of the discontinued LLVM Phabricator instance.

test-suite: divide avx512 tests to instruction set subdirectories
ClosedPublic

Authored by itaraban on Dec 12 2018, 8:38 AM.

Details

Summary

This patch separates current avx512 tests to avx512f, avx512bw and other instruction set directories.
This allows to specify tests sets on specific avx512 hardware, for example, knl.

Diff Detail

Event Timeline

itaraban created this revision.Dec 12 2018, 8:38 AM

Thanks - this approach makes more sense to me. @craig.topper @MatzeB Any other comments?

Makes sense to me.

This revision is now accepted and ready to land.Dec 13 2018, 12:49 AM
itaraban updated this revision to Diff 178028.EditedDec 13 2018, 3:05 AM

I found few issues and added changes to patch:

  • added knl to CMakeLists.txt(SingleSource/UnitTests/Vector/CMakeLists.txt) to test correctness of CMakeLists and Makefile.
  • changed march values in Makefile(SingleSource/UnitTests/Vector/AVX512F/Makefile) to use "native" and "-mavx512f" in case of cross compilation.
  • changed march values in CMakeLists to use X86CPU_ARCH
itaraban updated this revision to Diff 178032.Dec 13 2018, 3:42 AM

fix comments and generated test names in CMakeLists and Makefile.

RKSimon accepted this revision.Dec 13 2018, 3:44 AM

LGTM

This revision was automatically updated to reflect the committed changes.
SingleSource/UnitTests/Vector/AVX512/xor_or_m512_epi64.c