This is an archive of the discontinued LLVM Phabricator instance.

Add useful helpers to AddrSpaceCastInst
ClosedPublic

Authored by arsenm on Sep 12 2014, 11:57 AM.

Details

Reviewers
arsenm

Diff Detail

Event Timeline

arsenm updated this revision to Diff 13652.Sep 12 2014, 11:57 AM
arsenm retitled this revision from to Add useful helpers to AddrSpaceCastInst .
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
silvas added a subscriber: silvas.Sep 12 2014, 1:40 PM

Could you just add these as needed when refactoring? Adding these helpers seems like a no-brainer once the code needs them.

I usually prefer to add things like this separately from their uses

arsenm accepted this revision.Apr 25 2016, 12:33 PM
arsenm added a reviewer: arsenm.

r267450

This revision is now accepted and ready to land.Apr 25 2016, 12:33 PM
arsenm closed this revision.Apr 25 2016, 12:33 PM