Using __isascii (POSIX) instead of isascii (deprecated).

[curdeius]

Summary

Newer MinGW versions fail with a linker error because of undefined reference to isascii.
This function is deprecated and __isascii (POSIX conformant) should be used.

See: http://msdn.microsoft.com/fr-fr/library/5wcd48xw.aspx
See: http://stackoverflow.com/questions/19564168/how-can-solve-undefined-reference-to-isascii-when-build-openocd-in-win-7-cy

[rengolin]

Hi,

Looks harmless enough. Have you tested on non-Windows platforms?

cheers,
--renato

[thakis]

This directory contains https://code.google.com/p/googletest/ . I think the way to go about changing it is to get the change merged upstream, and then update this directory to what's in the upstream repo (?)

[curdeius]

In D5185#6, @rengolin wrote:

Looks harmless enough. Have you tested on non-Windows platforms?

Not yet, but I'll do this soon.

[curdeius]

Tested on Arch Linux with GCC 4.9.1 and Clang 3.5.0, works fine.

[curdeius]

In D5185#7, @thakis wrote:

This directory contains https://code.google.com/p/googletest/ . I think the way to go about changing it is to get the change merged upstream, and then update this directory to what's in the upstream repo (?)

I checked the googletest page. The current version does not have this problem, because isascii is not used in 1.7.0.
LLVM uses a slightly modified version 1.6.0, so I see two possibilities:

1. Update googletest in LLVM to 1.7.0 (However, I do not know the general policy for handling external dependencies in LLVM)
2. Patch current version (That is what I propose, a short-term solution)

utils/unittest/googletest/src/gtest-printers.cc

 // The array starts at *begin, the length is len, it may include L'\0'
 // characters and may not be null-terminated.
 static void PrintWideCharsAsStringTo(const wchar_t* begin, size_t len,
                                      ostream* os) {
   *os << "L\"";
   bool is_previous_hex = false;
   for (size_t index = 0; index < len; ++index) {
     const wchar_t cur = begin[index];
-    if (is_previous_hex && isascii(cur) && IsXDigit(static_cast<char>(cur))) {
+    if (is_previous_hex && __isascii(cur) && IsXDigit(static_cast<char>(cur))) {
       // Previous character is of '\x..' form and this character can be
       // interpreted as another hexadecimal digit in its number. Break string to
       // disambiguate.
       *os << "\" L\"";
     }
     is_previous_hex = PrintAsWideStringLiteralTo(cur, os) == kHexEscape;
   }
   *os << "\"";