This is an archive of the discontinued LLVM Phabricator instance.

[Support] fix the ULEB128 decoding bug.
ClosedPublic

Authored by arphaman on Aug 22 2014, 9:30 AM.

Details

Summary

This patch fixes the ULEB128 decoding which currently overflows when evaluating (*p & 0x7f) << Shift were *p = 0x10 and Shift is 28.

Diff Detail

Event Timeline

arphaman updated this revision to Diff 12845.Aug 22 2014, 9:30 AM
arphaman retitled this revision from to [Support] fix the ULEB128 decoding bug..
arphaman updated this object.
arphaman edited the test plan for this revision. (Show Details)
arphaman added reviewers: bob.wilson, bogner, dexonsmith.
arphaman set the repository for this revision to rL LLVM.
arphaman added a subscriber: Unknown Object (MLST).
dexonsmith edited edge metadata.Aug 22 2014, 9:33 AM

Ouch. LGTM!

arphaman closed this revision.Aug 22 2014, 9:39 AM
arphaman updated this revision to Diff 12846.

Closed by commit rL216268 (authored by @arphaman).