This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Rename cxx_headers back to cxx-headers.
ClosedPublic

Authored by ab on Jun 27 2018, 9:07 PM.

Details

Summary

r334477 renamed the cxx-headers target to cxx_headers, but various pieces sort-of expect the target names to match the component (e.g., LLVM_DISTRIBUTION_COMPONENTS in the various bootstrap caches, which, via some magic foreign to me, seems to expect cxx-headers, install-cxx-headers, and install-cxx-headers-stripped to exist)

We're still finding places that need to be changed, so, unless there was a reason for that change, revert back to cxx-headers (which, anecdotally, matches "clang-headers" for the clang lib/Headers/)

Otherwise, perhaps we should have target "aliases" (it seems like that's the reason why there are both *libcxx-headers* and *cxx-headers* variants of a few targets)

Diff Detail

Repository
rCXX libc++

Event Timeline

ab created this revision.Jun 27 2018, 9:07 PM
phosek accepted this revision.Jun 28 2018, 1:40 AM

LGTM

This revision is now accepted and ready to land.Jun 28 2018, 1:40 AM

It's not obvious to me how anything could depend on cxx-headers target (not the component) since that target did not exist until r334468 which has landed only recently (just before r334477). The motivation behind this change was just consistency since all other targets in libc++ use underscores rather than dashes, so reverting that change is fine with me if it's breaking you.

This revision was automatically updated to reflect the committed changes.