This is an archive of the discontinued LLVM Phabricator instance.

Add support for scalarizing ctlz_zero_undef
ClosedPublic

Authored by petarj on Jul 23 2014, 12:44 PM.

Details

Summary

Fix the missing case in ScalarizeVectorResult() that was exposed with
libclcore.bc in Android.

Diff Detail

Repository
rL LLVM

Event Timeline

petarj updated this revision to Diff 11817.Jul 23 2014, 12:44 PM
petarj retitled this revision from to Add support for scalarizing ctlz_zero_undef.
petarj updated this object.
petarj edited the test plan for this revision. (Show Details)
petarj added a reviewer: chandlerc.
petarj added a project: deleted.
petarj added subscribers: Unknown Object (MLST), sstankovic.
arsenm accepted this revision.Jul 29 2014, 11:59 AM
arsenm added a reviewer: arsenm.
arsenm added a subscriber: arsenm.

LGTM

This revision is now accepted and ready to land.Jul 29 2014, 11:59 AM
chandlerc edited edge metadata.Jul 29 2014, 12:04 PM

This seems fine (as Matt said) but don't you need to do the same for CTTZ?

In D4645#12, @chandlerc wrote:

This seems fine (as Matt said) but don't you need to do the same for CTTZ?

I was solving a particular failure, so this is why I have not included CTTZ_ZERO_UNDEF. But, yes, it should be done for CTTZ too.

I can update the case in ScalarizeVectorResult() with CTTZ.
(Or it should be another patch with additional test case?)

petarj closed this revision.Jul 29 2014, 5:53 PM
petarj updated this revision to Diff 12003.

Closed by commit rL214266 (authored by @petarj).