This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Include assembly files in builtins library build
ClosedPublic

Authored by sgundapa on Jul 21 2014, 9:35 PM.

Details

Summary

This patch address the PR20360. The CMake assembler build system
ignores the .S assembly files in builtins library build. This patch
fixes the issue.

Diff Detail

Event Timeline

sgundapa updated this revision to Diff 11738.Jul 21 2014, 9:35 PM
sgundapa retitled this revision from to [compiler-rt] Include assembly files in builtins library build.
sgundapa updated this object.
sgundapa edited the test plan for this revision. (Show Details)
rengolin accepted this revision.Jul 22 2014, 4:51 AM
rengolin edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2014, 4:51 AM
compnerd accepted this revision.Jul 22 2014, 9:25 AM
compnerd edited edge metadata.

I don't have commit access.
Can some one merge this ?

rengolin closed this revision.Jul 22 2014, 2:08 PM

r213684

Reverted in r213724 since it broke the sanitizer bot:

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/4016

cheers,
--renato

I will check on what the issue is