Add a matcher for SubstNonTypeTemplateParmExpr.

[djasper]

Looks good.

include/clang/ASTMatchers/ASTMatchers.h

689

While you are here, can you replace "initList()" with "initListExpr()"?

701

Replace initList() with the correct matcher.

[alexfh]

include/clang/ASTMatchers/ASTMatchers.h

689

Done.

701

Done.

[dblaikie]

Another review where, from my perspective, the patch itself never made
it to the mailing list - is this just another case of starting a
review, then adding the mailing list to the review?

From inspection of http://reviews.llvm.org/D4327 it looks like
(maybe?) the cfe-commits list was added when the review was created
(at least at the same timestamp), so I'm not sure why the initial
mailing wouldn't've reached the mailing list/my inbox.

[klimek]

Same here - uiuc blocked all phab mails on June 27th (and only on that day)

include/clang/ASTMatchers/ASTMatchers.h

 /// \brief Matches init list expressions.
 ///
 /// Given
 /// \code
 ///   int a[] = { 1, 2 };
 ///   struct B { int x, y; };
 ///   B b = { 5, 6 };
 /// \endcode
 /// initList()
 ///   matches "{ 1, 2 }" and "{ 5, 6 }"
 const internal::VariadicDynCastAllOfMatcher<Stmt, InitListExpr> initListExpr;
 
+/// \brief Matches substitutions of non-type template parameters.
+///
+/// Given
+/// \code
+///   template <int N>
+///   struct A { static const int n = N; };
+///   struct B : public A<42> {};
+/// \endcode
+/// initList()
+///   matches "N" in the right-hand side of "static const int n = N;"
+const internal::VariadicDynCastAllOfMatcher<Stmt, SubstNonTypeTemplateParmExpr>
+substNonTypeTemplateParmExpr;
+
 /// \brief Matches using declarations.
 ///
 /// Given
 /// \code
 ///   namespace X { int x; }
 ///   using X::x;
 /// \endcode
 /// usingDecl()

unittests/ASTMatchers/ASTMatchersTest.cpp

 TEST(Matcher, ForRange) {
   EXPECT_TRUE(matches("int as[] = { 1, 2, 3 };"
                       "void f() { for (auto &a : as); }",
                       forRangeStmt()));
   EXPECT_TRUE(notMatches("void f() { for (int i; i<5; ++i); }",
                          forRangeStmt()));
 }
 
+TEST(Matcher, SubstNonTypeTemplateParm) {
+  EXPECT_FALSE(matches("template<int N>\n"
+                       "struct A {  static const int n = 0; };\n"
+                       "struct B : public A<42> {};",
+                       substNonTypeTemplateParmExpr()));
+  EXPECT_TRUE(matches("template<int N>\n"
+                      "struct A {  static const int n = N; };\n"
+                      "struct B : public A<42> {};",
+                      substNonTypeTemplateParmExpr()));
+}
+
 TEST(Matcher, UserDefinedLiteral) {
   EXPECT_TRUE(matches("constexpr char operator \"\" _inc (const char i) {"
                       "  return i + 1;"
                       "}"
                       "char c = 'a'_inc;",
                       userDefinedLiteral()));
 }