This is an archive of the discontinued LLVM Phabricator instance.

MC: rename EmitWin64EH routines
ClosedPublic

Authored by compnerd on Jun 12 2014, 9:50 AM.

Details

Reviewers
echristo
rnk
Summary

Rename the routines to reflect the reality that they are more related to call
frame information than to Win64 EH. Although EH is implemented in an intertwined
manner by augmenting with an exception handler and an associated parameter, the
majority of these routines emit information required to unwind the frames. This
also helps identify that these routines are generic for most windows platforms
(they apply equally to nearly all architectures except x86) although the
encoding of the information is architecture dependent.

Unwinding data is emitted via EmitWinCFI* and exception handling information via
EmitWinEH*.

Diff Detail

Event Timeline

compnerd updated this revision to Diff 10367.Jun 12 2014, 9:50 AM
compnerd retitled this revision from to MC: rename EmitWin64EH routines.
compnerd updated this object.
compnerd edited the test plan for this revision. (Show Details)
compnerd added reviewers: echristo, rnk.
compnerd set the repository for this revision to rL LLVM.
compnerd added a subscriber: Unknown Object (MLST).
compnerd updated this revision to Diff 10427.Jun 15 2014, 12:22 PM
compnerd updated this object.
compnerd updated this revision to Diff 10515.Jun 17 2014, 2:39 PM
compnerd updated this object.
rnk accepted this revision.Jun 24 2014, 3:41 PM
rnk edited edge metadata.

lgtm

Either SEH or WinCFI seem like reasonable names to me. The information in question is analogous to DWARF's call frame information (CFI). MinGW chose to call these directives .seh_foo, even though this stuff is more CFI-related than EH-related. So, we could either standardize on the slightly weird directive names, or try to call it what it is.

This revision is now accepted and ready to land.Jun 24 2014, 3:41 PM

Committed as SVN r211994.

compnerd closed this revision.Jun 28 2014, 7:01 PM

Meant to close the differential.