This is an archive of the discontinued LLVM Phabricator instance.

test-suite: add avx512 tests with math intrinsics
ClosedPublic

Authored by itaraban on Dec 14 2017, 11:00 AM.

Details

Summary

Here is the bunch of tests. In each test we do some operations with intrinsics and also check result.
This set depends on cpu features, so it needs support to identify avx512 features in cmake and makefile approaches of test-suite. Here are patches for makefile and cmake: D38182, D38484

Diff Detail

Event Timeline

itaraban created this revision.Dec 14 2017, 11:00 AM
itaraban set the repository for this revision to rOLDT svn-test-suite.Dec 14 2017, 11:01 AM
MatzeB accepted this revision.Dec 14 2017, 11:58 AM

I didn't really read all the tests in detail, but from a high level this looks fine.

SingleSource/UnitTests/Vector/AVX512/minmax_shift.c
1151–1157

This pattern repeats in every test, why not put it into a function?

And to be nitpicky I think printing FAILED/PASSED is unnecessary: In the PASSED case it's perfectly fine to print nothing and return 0 IMO, in the FAILED case you should have already seen an error message anyway.

This revision is now accepted and ready to land.Dec 14 2017, 11:58 AM
This revision was automatically updated to reflect the committed changes.