This is an archive of the discontinued LLVM Phabricator instance.

[mips][mips64r6] [ls][wd]c2 were re-encoded with 11-bit signed immediates rather than 16-bit in MIPS32r6/MIPS64r6
ClosedPublic

Authored by dsanders on Jun 12 2014, 5:49 AM.

Details

Summary

The error message for the invalid.s cases isn't very helpful. It happens because
there is an instruction with a wider immediate that would have matched if the
NotMips32r6 predicate were true. I have some WIP to improve the message but it
affects most error messages for removed/re-encoded instructions on
MIPS32r6/MIPS64r6 and should therefore be a separate commit.

Depens on D4115

Diff Detail

Event Timeline

dsanders updated this revision to Diff 10354.Jun 12 2014, 5:49 AM
dsanders retitled this revision from to [mips][mips64r6] [ls][wd]c2 were re-encoded with 11-bit signed immediates rather than 16-bit in MIPS32r6/MIPS64r6.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders updated this object.Jun 16 2014, 1:45 AM
vmedic accepted this revision.Jun 16 2014, 2:12 AM
vmedic edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 16 2014, 2:12 AM
dsanders closed this revision.Jun 16 2014, 3:08 AM