This is an archive of the discontinued LLVM Phabricator instance.

Differential D4004

[mips][mips64r6] prefx is not available on MIPS32r6/MIPS64r6
ClosedPublic

Authored by dsanders on Jun 3 2014, 5:14 AM.

Details

Reviewers
jkolek
vmedic
zoran.jovanovic
Commits
rG6c97d979dfe4: [mips][mips64r6] prefx is not available on MIPS32r6/MIPS64r6
rL210779: [mips][mips64r6] prefx is not available on MIPS32r6/MIPS64r6
Summary

We haven't implemented this instruction so we only add a test case.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 10053.Jun 3 2014, 5:14 AM
dsanders retitled this revision from to [mips][mips64r6] prefx is not available on MIPS32r6/MIPS64r6.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added reviewers: vmedic, zoran.jovanovic, jkolek.
jkolek accepted this revision.Jun 12 2014, 2:26 AM
jkolek edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jun 12 2014, 2:26 AM
dsanders added a parent revision: D4003: [mips][mips64r6] c.cond.fmt, mov[fntz], and mov[fntz].[ds] are not available on MIPS32r6/MIPS64r6.Jun 12 2014, 6:51 AM
dsanders closed this revision.Jun 12 2014, 6:59 AM

Revision Contents

PathSize
lib/
Target/
Mips/
1 line
test/
MC/
Mips/
mips32r6/
21 lines
mips64r6/
21 lines

Diff 10053

lib/Target/Mips/Mips32r6InstrInfo.td

Show All 28 Lines
// Removed: bc2[ft] // Removed: bc2[ft]
// Removed: bc2f, bc2t // Removed: bc2f, bc2t
// Removed: bgezal // Removed: bgezal
// Removed: bltzal // Removed: bltzal
// Removed: bc1[ft] // Removed: bc1[ft]
// Removed: ldxc1 // Removed: ldxc1
// Removed: luxc1 // Removed: luxc1
// Removed: lwxc1 // Removed: lwxc1
// Removed: prefx
// Removed: sdxc1 // Removed: sdxc1
// Removed: suxc1 // Removed: suxc1
// Removed: swxc1 // Removed: swxc1
// Rencoded: [ls][wd]c2 // Rencoded: [ls][wd]c2
def brtarget21 : Operand<OtherVT> { def brtarget21 : Operand<OtherVT> {
let EncoderMethod = "getBranchTarget21OpValue"; let EncoderMethod = "getBranchTarget21OpValue";
let OperandType = "OPERAND_PCREL"; let OperandType = "OPERAND_PCREL";
▲ Show 20 Lines • Show All 630 Lines • Show Last 20 Lines

test/MC/Mips/mips32r6/invalid-mips4-wrong-error.s

  • This file was added.
# Instructions that are invalid and are correctly rejected but use the wrong
# error message at the moment.
#
# RUN: not llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips32r6 \
# RUN: 2>%t1
# RUN: FileCheck %s < %t1
.set noat
beql $1,$2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgezall $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgezl $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgtzl $4,16 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
blezl $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bltzall $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bltzl $4,16 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bnel $1,$2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1tl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1fl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc2tl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc2fl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
prefx 0,$2($31) # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction

test/MC/Mips/mips64r6/invalid-mips4-wrong-error.s

  • This file was added.
# Instructions that are invalid and are correctly rejected but use the wrong
# error message at the moment.
#
# RUN: not llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips32r6 \
# RUN: 2>%t1
# RUN: FileCheck %s < %t1
.set noat
beql $1,$2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgezall $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgezl $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bgtzl $4,16 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
blezl $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bltzall $3,8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bltzl $4,16 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bnel $1,$2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1tl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1fl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc2tl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc2fl 4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
prefx 0,$2($31) # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction