This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Rename Bonaire target to be gfx704; remove gfx800 and make Iceland and Tonga both use gfx802; update target feature handling
ClosedPublic

Authored by t-tye on Nov 14 2017, 3:05 PM.

Details

Summary
  • Rename Bonaire target to be gfx704.
  • Eliminate gfx800 and make Iceland and Tonga both use gfx802 as they use the same code.
  • List target features supported by each processor in the processor table together with the default value.
  • Add xnack flag to e_flags.
  • Remove xnack from kernel metadata and kernel descriptor since it is now a whole code object property.

Diff Detail

Repository
rL LLVM

Event Timeline

t-tye created this revision.Nov 14 2017, 3:05 PM
nhaehnle edited edge metadata.Nov 16 2017, 9:57 AM

Fine with me.

t-tye updated this revision to Diff 123286.Nov 16 2017, 6:21 PM
t-tye retitled this revision from AMDGPU: Rename Bonaire target to be gfx704 to AMDGPU: Rename Bonaire target to be gfx704; make target feature defaul processor specific.
t-tye edited the summary of this revision. (Show Details)

List target features supported by each processor in the processor table together with the default value.

t-tye updated this revision to Diff 123395.Nov 17 2017, 12:28 PM
t-tye retitled this revision from AMDGPU: Rename Bonaire target to be gfx704; make target feature defaul processor specific to AMDGPU: Rename Bonaire target to be gfx704; update target feature handling.
t-tye edited the summary of this revision. (Show Details)
  • Add xnack flag to e_flags.
kzhuravl edited edge metadata.Nov 17 2017, 12:30 PM
  • Add xnack flag to e_flags.

Do we still need to record xnack presence in metadata?

  • Add xnack flag to e_flags.

Do we still need to record xnack presence in metadata?

Also likely remove from kernel_code_t too.

t-tye updated this revision to Diff 123411.Nov 17 2017, 1:37 PM
t-tye edited the summary of this revision. (Show Details)

Remove xnack from kernel metadata and kernel descriptor since it is now a whole code object property.

t-tye updated this revision to Diff 123417.Nov 17 2017, 2:17 PM
t-tye edited the summary of this revision. (Show Details)

Eliminate gfx800 and make Iceland and Tonga both use gfx802 as they use the same code.

Eliminate gfx800 and make Iceland and Tonga both use gfx802 as they use the same code.

Is this correct? IIRC, Tonga's atomic add/sub must always have the glc bit enabled (iceland does not need that). This was the reason for having them as separate ccs.

kzhuravl added inline comments.Nov 20 2017, 9:00 AM
docs/AMDGPUUsage.rst
126 ↗(On Diff #123417)

Should this APU have an xnack on by default? I remember we talked about defaulting xnack to on for all APUs.

144 ↗(On Diff #123417)

Should this APU have an xnack on by default? I remember we talked about defaulting xnack to on for all APUs.

523–528 ↗(On Diff #123417)

Should we mention anything about the fact that we will not link code objects with different xnack settings?

b-sumner edited edge metadata.Nov 27 2017, 2:16 PM

Looks good to me.

t-tye added inline comments.Nov 27 2017, 9:32 PM
docs/AMDGPUUsage.rst
126 ↗(On Diff #123417)

I do not believe hardware added XNACK support until GFX8.

144 ↗(On Diff #123417)

I do not believe hardware added XNACK support until GFX8.

This revision is now accepted and ready to land.Nov 28 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.
t-tye retitled this revision from AMDGPU: Rename Bonaire target to be gfx704; update target feature handling to AMDGPU: Rename Bonaire target to be gfx704; remove gfx800 and make Iceland and Tonga both use gfx802; update target feature handling.Dec 11 2017, 9:43 PM