This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Tighten up CHECK lines in a test
ClosedPublic

Authored by olista01 on Oct 24 2017, 6:26 AM.

Details

Summary

These tests checked for the line number without a leading ":", so for example, a missed diagnostic on line 123 could match one on line 1123, 2123, etc, desynchronising the test for hundreds of lines.

This couldn't cause it to incorrectly pass or fail, but made it hard to track down test failures.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Oct 24 2017, 6:26 AM
rengolin accepted this revision.Oct 24 2017, 6:33 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 24 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.