This is an archive of the discontinued LLVM Phabricator instance.

[X86][AVX512] lowering broadcastm intrinsic - llvm part
ClosedPublic

Authored by jina.nahias on Oct 9 2017, 3:55 AM.

Diff Detail

Event Timeline

RKSimon edited edge metadata.Oct 9 2017, 5:22 AM

Please add fast-isel tests that match the builtin tests from D38683

adding fast-isel tests

RKSimon added inline comments.Oct 10 2017, 6:03 AM
test/CodeGen/X86/avx512cd-intrinsics-fast-isel.ll
5

Strip the attributes

test/CodeGen/X86/avx512vlcd-intrinsics-fast-isel.ll
5

Strip the attributes

zvi accepted this revision.Oct 30 2017, 4:08 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2017, 4:08 AM
RKSimon added inline comments.Oct 30 2017, 5:02 AM
test/CodeGen/X86/avx512vlcd-intrinsics-fast-isel.ll
8

Why do the avx512vlcd fast-isel cases use the vpbroadcastmb2 instructions but the avx512cd cases go through the GPRs?

making broadcastm working without VL in 512 bit intrinsics @RKSimon @igorb @zvi

RKSimon accepted this revision.Oct 31 2017, 9:22 AM

LGTM with one minor

lib/Target/X86/X86ISelLowering.cpp
6782 ↗(On Diff #120989)

clang-format this

This revision was automatically updated to reflect the committed changes.