This is an archive of the discontinued LLVM Phabricator instance.

[ELF] [fix] Using statically linked lld leads to segmentation fault on linking ELF
ClosedPublic

Authored by emankov on Sep 21 2017, 5:24 AM.

Diff Detail

Event Timeline

emankov created this revision.Sep 21 2017, 5:24 AM
grimar added inline comments.
ELF/Driver.cpp
83

It probably will not be enough.

For example we have synthetic sections which are statics now, like `InX::DynSymTab'.
Doesn't seem them are cleared properly. If first call uses it and second - don't, it seems
to me it will fail.

So I want to say this change looks fine for me, but problem will not be solved completely anyways I think,

ruiu accepted this revision.Sep 21 2017, 10:54 AM

LGTM

ELF/Driver.cpp
83

It does worth it. You just have to fix all these problems.

This revision is now accepted and ready to land.Sep 21 2017, 10:54 AM
This revision was automatically updated to reflect the committed changes.