This is an archive of the discontinued LLVM Phabricator instance.

[mips] Marked up instructions added in MIPS-III and tested that IAS for -mcpu=mips[12] does not accept them
ClosedPublic

Authored by dsanders on May 8 2014, 6:54 AM.

Details

Summary

This required a new instruction group representing the 32-bit subset of
MIPS-III that was available in MIPS32

A small number of instructions are correctly rejected but with the wrong error
message. These have been placed in a separate test for now.

There's some obvious InstAlias's that ought to be marked MIPS-III but arent.
This is because they are not currently tested. I intend to catch these with
a final pass through the tablegen records to find tablegen records without
ISA annotations.

Depends on D3674

Diff Detail

Event Timeline

dsanders updated this revision to Diff 9216.May 8 2014, 6:54 AM
dsanders retitled this revision from to [mips] Marked up instructions added in MIPS-III and tested that IAS for -mcpu=mips[12] does not accept them.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added a reviewer: vmedic.
vmedic accepted this revision.May 9 2014, 2:43 AM
vmedic edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 9 2014, 2:43 AM
dsanders updated this revision to Diff 9243.May 9 2014, 3:55 AM
dsanders edited edge metadata.

Refresh patch before commit

dsanders closed this revision.May 9 2014, 6:09 AM