This is an archive of the discontinued LLVM Phabricator instance.

Add %run to all compiler-rt lit tests
ClosedPublic

Authored by garious on Apr 29 2014, 2:16 PM.

Details

Summary

This patch adds %run before invoking any executables. In conjunction with http://reviews.llvm.org/D3425, this allows us to test the sanitizers in cross-compiled environments by setting COMPILER_RT_EMULATOR to qemu-arm. Alternatively, the user may point COMPILER_RT_EMULATOR to a custom script that uploads the executable to a device and executes it remotely.

Diff Detail

Event Timeline

garious updated this revision to Diff 8942.Apr 29 2014, 2:16 PM
garious retitled this revision from to Add %run to all compiler-rt lit tests.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added reviewers: samsonov, rengolin, eugenis.
garious added a subscriber: Unknown Object (MLST).Apr 29 2014, 5:16 PM
samsonov edited edge metadata.Apr 29 2014, 5:33 PM

I defer to Evgeniy's opinion here.

eugenis accepted this revision.Apr 30 2014, 1:18 AM
eugenis edited edge metadata.

LGTM

This does not solve the issue of shared libraries (ex. in test/asan/TestCases/shared-lib-test.cc %t-so.so won't be copied to the device). I guess that's not an issue for qemu?

This revision is now accepted and ready to land.Apr 30 2014, 1:18 AM
rengolin edited edge metadata.Apr 30 2014, 1:23 AM

IIRC, if the binaries are linked statically, qemu-user works fine, otherwise you need sysroots and co.

Committed in r207709

rengolin closed this revision.May 2 2014, 3:39 AM