Allow compiler-rt tests to be run on a simulator or remotely

[garious]

Summary

With this patch, tests can add "%run" to run executables on a simulator or remotely. This patch only adds %run to the 'profile' test. A following patch adds "%run" to the test cases.

[garious]

Rebased

[rengolin]

Hi Greg,

I can't say I understand this patch, but the change would be much appreciated! ;)

From what I can see, it seems similar to what the others around it are, and you're using COMPILER_RT flags rather than ASAN (I'm assuming they're set directly somewhere else).

What I don't understand is how you turn %run off if you're not cross compiling.

cheers,
--renato

[garious]

Fixed get_required_attr(). An empty string is a valid set of target_cflags.

[garious]

Committed in r207707

test/asan/CMakeLists.txt

   get_filename_component(ASAN_TEST_LLVM_TOOLS_DIR ${CMAKE_C_COMPILER} PATH)
   set(ASAN_TEST_CONFIG_SUFFIX "-arm-android")
   set(ASAN_TEST_BITS "32")
-  get_target_flags_for_arch(arm_android ASAN_TEST_TARGET_CFLAGS)
+  get_target_flags_for_arch(arm_android COMPILER_RT_TEST_COMPILER_CFLAGS)
   configure_lit_site_cfg(
     ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
     ${CMAKE_CURRENT_BINARY_DIR}/ARMAndroidConfig/lit.site.cfg

   list(APPEND ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/ARMAndroidConfig)
 endif()
 
+if(CAN_TARGET_arm)
+  # This is only true if we are cross-compiling.
+  # Build all tests with host compiler and use host tools.
+  set(ASAN_TEST_TARGET_CC ${COMPILER_RT_TEST_COMPILER})
+  set(ASAN_TEST_CONFIG_SUFFIX "-arm-linux")
+  set(ASAN_TEST_BITS "32")
+  set(ASAN_TEST_DYNAMIC False)
+  configure_lit_site_cfg(
+    ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
+    ${CMAKE_CURRENT_BINARY_DIR}/ARMLinuxConfig/lit.site.cfg
+    )
+  list(APPEND ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/ARMLinuxConfig)
+endif()
+
 if(CAN_TARGET_x86_64 OR CAN_TARGET_powerpc64)
   set(ASAN_TEST_CONFIG_SUFFIX "64")
   set(ASAN_TEST_BITS "64")
-  set(ASAN_TEST_TARGET_CFLAGS ${TARGET_64_BIT_CFLAGS})
+  set(COMPILER_RT_TEST_COMPILER_CFLAGS ${TARGET_64_BIT_CFLAGS})
   set(ASAN_TEST_DYNAMIC False)
   configure_lit_site_cfg(
     ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in

 if(CAN_TARGET_i386)
   set(ASAN_TEST_CONFIG_SUFFIX "32")
   set(ASAN_TEST_BITS "32")
-  set(ASAN_TEST_TARGET_CFLAGS ${TARGET_32_BIT_CFLAGS})
+  set(COMPILER_RT_TEST_COMPILER_CFLAGS ${TARGET_32_BIT_CFLAGS})
   set(ASAN_TEST_DYNAMIC False)
   set(ASAN_TEST_TARGET_ARCH "i386")
   configure_lit_site_cfg(

test/asan/lit.cfg

 
 def get_required_attr(config, attr_name):
   attr_value = getattr(config, attr_name, None)
-  if not attr_value:
+  if attr_value == None:
     lit_config.fatal(
       "No attribute %r in test configuration! You may need to run "
       "tests from your build directory or add this attribute "

test/asan/lit.site.cfg.in

 # Tool-specific config options.
 config.name_suffix = "@ASAN_TEST_CONFIG_SUFFIX@"
 config.asan_lit_source_dir = "@ASAN_LIT_SOURCE_DIR@"
-config.target_cflags = "@ASAN_TEST_TARGET_CFLAGS@"
 config.clang = "@ASAN_TEST_TARGET_CC@"
 config.llvm_tools_dir = "@ASAN_TEST_LLVM_TOOLS_DIR@"
 config.bits = "@ASAN_TEST_BITS@"

test/lit.common.cfg

     (' clang', """\n\n*** Do not use 'clangXXX' in tests,
      instead define '%clangXXX' substitution in lit config. ***\n\n""") )
 
+# Allow tests to be executed on a simulator or remotely.
+config.substitutions.append( ('%run', config.emulator) )
+
 # Add supported compiler_rt architectures to a list of available features.
 compiler_rt_arch = getattr(config, 'compiler_rt_arch', None)
 if compiler_rt_arch:

test/lit.common.configured.in

     
 # Generic config options for all compiler-rt lit tests.
 set_default("target_triple", "@TARGET_TRIPLE@")
+set_default("target_cflags", "@COMPILER_RT_TEST_COMPILER_FLAGS@")
 set_default("host_arch", "@HOST_ARCH@")
 set_default("target_arch", "@HOST_ARCH@")
 set_default("host_os", "@HOST_OS@")

 set_default("python_executable", "@PYTHON_EXECUTABLE@")
 set_default("compiler_rt_debug", @COMPILER_RT_DEBUG_PYBOOL@)
 set_default("compiler_rt_libdir", "@COMPILER_RT_LIBRARY_OUTPUT_DIR@")
+set_default("emulator", "@COMPILER_RT_EMULATOR@")
 
 # LLVM tools dir can be passed in lit parameters, so try to
 # apply substitution.

test/lsan/lit.common.cfg

 
 def get_required_attr(config, attr_name):
   attr_value = getattr(config, attr_name, None)
-  if not attr_value:
+  if attr_value == None:
     lit_config.fatal(
       "No attribute %r in test configuration! You may need to run "
       "tests from your build directory or add this attribute "

test/profile/instrprof-basic.c

 // RUN: %clang_profgen -o %t -O3 %s
-// RUN: env LLVM_PROFILE_FILE=%t.profraw %t
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
 // RUN: llvm-profdata merge -o %t.profdata %t.profraw
 // RUN: %clang_profuse=%t.profdata -o - -S -emit-llvm %s | FileCheck %s
 

test/profile/lit.cfg

 # Test suffixes.
 config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm', '.ll', '.test']
 
+# Clang flags.
+clang_cflags = [config.target_cflags]
+
+def build_invocation(compile_flags):
+  return " " + " ".join([config.clang] + compile_flags) + " "
+
 # Add clang substitutions.
-config.substitutions.append( ("%clang ", config.clang + " ") )
-config.substitutions.append( ("%clang_profgen ", config.clang + " -fprofile-instr-generate ") )
-config.substitutions.append( ("%clang_profuse=", config.clang + " -fprofile-instr-use=") )
+config.substitutions.append( ("%clang ", build_invocation([])) )
+config.substitutions.append( ("%clang_profgen ", build_invocation(clang_cflags) + " -fprofile-instr-generate ") )
+config.substitutions.append( ("%clang_profuse=", build_invocation(clang_cflags) + " -fprofile-instr-use=") )
 
 # Profile tests are currently supported on Linux and Darwin only.
 if config.host_os not in ['Linux', 'Darwin']:

test/ubsan/lit.common.cfg

 
 def get_required_attr(config, attr_name):
   attr_value = getattr(config, attr_name, None)
-  if not attr_value:
+  if attr_value == None:
     lit_config.fatal(
       "No attribute %r in test configuration! You may need to run "
       "tests from your build directory or add this attribute "